Re: [Phpslash-devel] embracing the future

[Peter C. <li...@cr...>]

On Tuesday 28 Oct 2003 4:45 pm, Joe Stewart wrote:
...

> > A move to 0.8 might be the chance to change config.ini.php to
> > consistently use the dot notation for naming settings (db.host,
> > skin.default,
> > search.maxresults etc). Just a thought.
>
> A very good thought too.  It really does help clean up the variables.

Yup. There may be other tidying up that could be done at the same time?

...

>   {rootdir}/include/modules/{modulename}/templates/
>
> And if a template exists in the lang/skin it overrides this one.
>
> > with a skin.ini that points to:
> > {rootdir}/include/templates/en/{skinname}/
>
>                                      ^ parentskin

I'll have a play.

> > > One thing I don't like.  If your new whiz bang module adds a block
> > > type, The _render.class file has to go in modules/block/blocktypes.
> >
> > Perhaps if psl_block_type had an extra field to record the block's
> > module? The
>
> I even had a paragraph written proposing something like this for module
> registration, naming, and path.  Then I remembered that you can use a
> "module" block type and reduce the number of blocktypes needed
> tremendously.

But modules are (kind of) registered in the $_PSL['module'] array - that could 
be used for building a list of directories to look for Block_render_* files 
in? There may be other reasons not to distribute the block-rendering code 
around the place tho. 

I'm still getting my head round the move to rending modules through the block 
mechanism. Seems a great idea tho.

> > page building code would then know where to look.
> > - the existing block adding/removing code would have to be changed tho.
> > (Is it used much?)
>
> I don't think this would be a big hurdle.  It might be a db hit and then
> loaded in the session.
>
> > [Other points are specific to the CVS]
> >
> > > > - Not sure what the point of the show_admin_on_navbar option is. The
> > > > current note got me confused...
> > >
> > > May be time for it to go away.  It's whether you want the login/logout
> > > in the navbar.
> >
> > If I enable show_admin_on_navbar, the navbar has:
> > [Logout nobody] [Login] ...
>
>        ^ didn't realize it did this now.  I think its time to silently
>        drop this option.  It should also say Login.
>
> > and once I'm logged in:
> > [Logout god] [Logout] ...
>
>                   ^ This one is the stuff in the menu array.
> 	^ This one is the option your asking about.
>
> > Which just don't seem right ;-)
>
> The argument for it remaining was that it knew your name when logged in I
> guess.

What about getting rid of the option + maybe creating an identity block or 
making the username available to the templates?

> > New query:
> > Not sure if it's just my setup, but I checked the Remember Me box, and
> > I've not been able to properly logout - when I click logout, I get the
> > login form (as you'd expect), but when I go to other pages, I'm still
> > logged in as god.
> >
> > ...
>
> What browser and rooturl?
>
> Mozilla/Netscape can set cookies it can't delete.

OK. It'll see if it stays a problem. (Mozilla 1.3.1 on Mandrake 9.1, rooturl = 
//192.168.1.100/phpslash) - but I'm not consistently reproducing this 
behavior, so best leave it for now.

...

> > Anyway, all I was saying is that the links in the demo data were to
> > http://localhost/phpslash/public_html/ . . . not a big deal, and since
> > the instal is aimed at people unfamiliar with PSL the data is probably
> > right .
>
> I can't find this in phpslash-dev/tables/0.7/slash-all.sql.

You're right - not sure what happended there

A couple of false alarms then!

P
-- 
As in certain cults it is possible to kill a process if you know its true 
name.
		-- Ken Thompson and Dennis M. Ritchie