Re: [Phpslash-devel] config.php vs. config-dist.php

[Joe S. <joe...@us...>]

On Fri, Mar 07, 2003 at 12:14:08PM -0800, Ajay Sharma wrote:
> > Now for you guys input on this:
> > 
> > 1.  delete config.php from cvs entirely
> > 
> > 2.  move config-dist.php to config.php
> > 
> > 3.  change config.php to only contain text that phpslsash is not 
> > configured and to read the install documentation.
> > 
> > All three seem to have pros and cons to me.
> 
> just for consistancy reasons, I would choose number 1 because we don't 
> distribute a config.ini.php file, so right now there are three config 
> files:
>

I lean to this one because the config files don't get written over 
accidently :)
 
> config.php
> config-dist.php
> config-dist.ini.php
> 
> config.php is just out of place and should be removed.  Then in the 
> install docs, we should specify that the first thing you should do when 
> installing phpslash is:
> 
> mv config-dist.php config.php
> mv config-dist.ini.php config.ini.php
> 

The regular install already says to copy these:

http://www.phpslash.org/article.php3?story_id=32&topic_id=39&section_id=8#ss2.5

However, for the release I did the copy to reduce questions. Probably 
not a good idea though.  So the quick install didn't mention copying 
config-dist.php tp config.php.


> >  Another small issue - the poll list cache is not deleted when a new
> > poll is added. If someone would tell me a quick regex for "string
> > contains poll and not question_id" this would be fixed too.
> 
> does it have to be a regex:
> 
> if (strstr('poll',$string) and !strstr('question_id',$string)) {
>

When a poll is added, the poll.php can still be pulled from a cache 
unless we do some garbage collection.

// expire cache for this question_id
jpcache_gc('string', "-question_id-" . $HTTP_POST_VARS['question_id'], "100");

This line deletes the cache for a particular poll when updating it.  It 
does a string match of "question_id-nn" on the cache name and deletes it 
if found.

The list of polls is just poll.php without any arguments.  So that's why I 
wanted the above regex.  The jpcache_gc can now search for string, regex 
or timeout.

 
> > Ajay - Luis found a problem with the poll total votes if you manually
> > put values into the form.  Maybe you could give him a hint.  I
> > remember the old days with the bad counts and you fighting with this.
> 
> I'll have to dig into the code since I've been pretty much AWOL for the 
> last year.  :)  I do have a working 7.0 installation at home so I'll try 
> to recreate this bug.
> 

He kind of abused it by putting a very large number in one of the Votes 
fields ( all 9's).

I'm committing a fix for the default poll strangely adding an entry when 
saving.

Joe

> later,
> ajay
> 
> --------------------------------------------------------------------
> Satyajot (Ajay) Sharma 
> ss...@od...
> --------------------------------------------------------------------
> 
> 
> 
> -------------------------------------------------------
> This SF.net email is sponsored by: Etnus, makers of TotalView, The debugger 
> for complex code. Debugging C/C++ programs can leave you feeling lost and 
> disoriented. TotalView can help you find your way. Available on major UNIX 
> and Linux platforms. Try it free. www.etnus.com
> _______________________________________________
> Phpslash-devel mailing list
> Php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpslash-devel
>