phppgadmin-devel — For Developers Only

Re: [ppa-dev] Patches for ppa self-tests

[Karl O. P. <ko...@me...>]

On 05/20/2013 04:53:31 PM, Karl O. Pinc wrote:
> On 05/20/2013 03:16:13 PM, Jehan-Guillaume (ioguix) de Rorthais 
> wrote:
> > On 30/04/2013 21:57, Karl O. Pinc wrote:

> > > https://github.com/kpinc/phppgadmin/commits/gitignore
> > > 
> > > 1 patch.
> > > Frob .gitignore to ignore emacs backup files.
> > 
> > Well, you can use the file ".git/info/exclude" or the one you
> specify
> > through "core.excludesfile".

Let me know what the verdict is on this patch so I can
move forward with my configs.



Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

Re: [ppa-dev] Patches for ppa self-tests

[Karl O. P. <ko...@me...>]

On 05/20/2013 03:16:13 PM, Jehan-Guillaume (ioguix) de Rorthais wrote:
> On 30/04/2013 21:57, Karl O. Pinc wrote:

> > https://github.com/kpinc/phppgadmin/commits/selenium-login
> > 
> > 1 patch.
> > Deletes cookies on selenium login so that previous
> > failed or paused tests do not affect the execution of
> > subsequent manually executed tests.  This allows
> > the user more control over manual test execution.
> 
> I don't like this.
> 
> I prefer this syntax:
> 
>   $this->deleteAllVisibleCookies();

I'm not sure I understand.  Your suggestion would
delete all cookies when the Selenium test suite
is entered, right?

The point of the patch is
to be able to make each test independent of the state
at which the last test leaves the PPA system.  This allows
tests to fail, be run out of order, and so forth.
To do this you need to clear the cookies each
time Selenium starts a test.

Obviously, some tests setup db state that are required
for later tests, but the state of where PPA left the
browser, the screen and so forth, is what this patch
addresses.

> 
> > https://github.com/kpinc/phppgadmin/commits/selenium-enabled
> > 
> > 3 patches.
> > Internationalizes the selenium link on the ppa intro page.
> > Makes the link "hot" only when selenium has been configured.
> 
> These two patch seems useless to me: we remove the selenium links
> before
> each release of PPA. This would require to remove the i18n as well.

Yes...  But this last release selenium was not removed.  It seems
useful to be able to run the test suite on released code
as an end-user.

There could be issues, in which case yes these patches are useless.
See my response to Robert regards this.

It now occurs to me that people run HEAD a lot.  If it's dangerous
to have the self-tests on a production system we should probably
address this.


> 
> > Adds a "reset" link to clean cruft from failed self-test runs.
> 
> This one definitely worth it! Thanks to this, we could open Both
> normal
> and reset scenario in two different tabs and switch between them.
> 
> +1, but could you make some cleanup first about i18n please?

Will do, if we want to remove the self-tests from released code.

> > https://github.com/kpinc/phppgadmin/commits/gitignore
> > 
> > 1 patch.
> > Frob .gitignore to ignore emacs backup files.
> 
> Well, you can use the file ".git/info/exclude" or the one you specify
> through "core.excludesfile".

I'm happy to use .git/info/exclude if this is what you guys
want.  I thought this would be developer-friendly.

> 
> Thank you Karl,

Your welcome.

Regards,

Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

P.S.  Where is the code that creates the release?

Re: [ppa-dev] Fix of race condition in db browser frame

[Jehan-Guillaume (i. de R. <io...@fr...>]

On 15/05/2013 05:57, Karl O. Pinc wrote:
> Hi,
> 
> I've a new branch on github, browserace:
> 
> https://github.com/kpinc/phppgadmin/commits/browserace
> 
> Branches off origin/master, as do all my branches unless
> I mention otherwise.
> 
> This fixes what seems to be a race condition.  Browsers
> may load multiple html <script> tags asynchronously,
> and so may execute them in an indeterminate order.
> Given the way the js code is written the
> xloadtree/xtree2.js file must execute before the
> xloadtree/xloadtree2.js file, and this has
> not been guaranteed.
> 
> jQuery.getScript() serializes js script loading, but
> not execution.  So, I beat the problem
> over the head with a php based solution.

I never have been bitten by this and I think the xtree should be drop
altogether with the frames anyway. As the tree is in Full js anyway, we
should be able to make it hide-able with js instead of using ugly,
heavy, useless, unconfortable and troublesome frames.

I would prefer to see someone working on this instead of fixing again
(potential) bugs with xtree. Let's save some time.

Most of our jQuery code should be in a .ready() method anyway.

Cheers,

> Regards,
> 
> Karl <ko...@me...>
> Free Software:  "You don't pay back, you pay forward."
>                  -- Robert A. Heinlein
> 

Re: [ppa-dev] Patches for ppa self-tests

[Jehan-Guillaume (i. de R. <io...@fr...>]

On 30/04/2013 21:57, Karl O. Pinc wrote:
> Hi,
> 
> I've a number of patches for inclusion into ppa.
> I thought, rather than attach them here, I'd
> link to the branches on github and describe them.
> 
> If this isn't a good process then please let me
> know what works better.
> 
> 
> https://github.com/kpinc/phppgadmin/commits/selenium-login
> 
> 1 patch.
> Deletes cookies on selenium login so that previous
> failed or paused tests do not affect the execution of
> subsequent manually executed tests.  This allows
> the user more control over manual test execution.

I don't like this.

I prefer this syntax:

  $this->deleteAllVisibleCookies();

> https://github.com/kpinc/phppgadmin/commits/selenium-enabled
> 
> 3 patches.
> Internationalizes the selenium link on the ppa intro page.
> Makes the link "hot" only when selenium has been configured.

These two patch seems useless to me: we remove the selenium links before
each release of PPA. This would require to remove the i18n as well.

> Adds a "reset" link to clean cruft from failed self-test runs.

This one definitely worth it! Thanks to this, we could open Both normal
and reset scenario in two different tabs and switch between them.

+1, but could you make some cleanup first about i18n please?

> https://github.com/kpinc/phppgadmin/commits/selenium-doc
> 
> 4 patches.
> Changes to tests/selenium/README to make it more better.
> The last patch documents the "reset" link above.

+1

> https://github.com/kpinc/phppgadmin/commits/gitignore
> 
> 1 patch.
> Frob .gitignore to ignore emacs backup files.

Well, you can use the file ".git/info/exclude" or the one you specify
through "core.excludesfile".

I already use the first one to deal with my own
backup/tests/config/plugins files.

Thank you Karl,

> Regards,
> 
> Karl <ko...@me...>
> Free Software:  "You don't pay back, you pay forward."
>                  -- Robert A. Heinlein

Re: [ppa-dev] Patches to roll to 9.3

[Karl O. P. <ko...@me...>]

On 05/18/2013 06:02:50 PM, Robert Treat wrote:
> The 9.3 bits are in official head now (which means I think you can
> delete this branch now if you want to). 

Not yet, the first patch in the branch creates PostgresDoc93.php.

commit e4a39a2535976ae7e9073faaf52275737f8286b0
Author: Karl O. Pinc <ko...@me...>
Date:   Tue May 7 23:09:55 2013 -0500

    Roll the help system from 9.2 to 9.3.


> I wanted to do this
> independent of the help changes.

You must not have applied the above patch since it
affects the help system, but that's what leaves
HEAD without a 9.3 help system....


Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

Re: [ppa-dev] Patches to roll to 9.3

[Karl O. P. <ko...@me...>]

On 05/18/2013 06:02:50 PM, Robert Treat wrote:
> The 9.3 bits are in official head now (which means I think you can
> delete this branch now if you want to). I wanted to do this
> independent of the help changes. 

There is a problem in HEAD now, since you refer to a
PostgresDoc93.php file and it does not exist.

I'm no longer paying attention to help. I think this
only matters when clicking on a help link, but thought
I'd mention it so we can all keep track of HEAD.


Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

Re: [ppa-dev] Fix of race condition in db browser frame

[Karl O. P. <ko...@me...>]

On 05/18/2013 07:54:50 PM, Karl O. Pinc wrote:
> On 05/18/2013 06:39:28 PM, Robert Treat wrote:
> > This change seems a bit dubious to me. I can't see any case where
> > either script would execute outside of explicate calls to the
> various
> > functions. You do raise a point though that when calling into
> > xloadtree, it's possible xload2 isn't there (given asynch 
> download).
> > However that makes me feel like jQuery.getScript() is actually the
> > right fix.
> 
> jQeury.getScript() ensures load order, but _not_ 
> the order of execution completion.
> I imagine getScript is often the right fix, but the xtree code
> relies on execution to setup the proper state for the prototype/
> inheritance tree.  If this is not done before object instantiation
> bad things happen and the instantiated objects don't have the
> right methods etc.

So, to explicitly state the problem vis jQuery:

jQuery enforces download order xtree2.js is first,
followed by xloadtree.js.  But both xtree2
and xloadtree execute instantly to setup
their objects.  Suppose xtree execution is delayed,
xloadtree executes and in so doing executes, say,
line 87

   _p = WebFXLoadTree.prototype = new WebFXTree;

before the execution of xtree has setup the
proper state of WebFXTree.prototype.  For example,
at over 1,000 lines in, xtree2.js has:

  _p = WebFXTree.prototype = new WebFXTreeAbstractNode;

If this line has not executed before "new WebFXTree"
executes in xloadtree.js you're going to get bunk.



Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

Re: [ppa-dev] Fix of race condition in db browser frame

[Karl O. P. <ko...@me...>]

On 05/18/2013 06:39:28 PM, Robert Treat wrote:
> This change seems a bit dubious to me. I can't see any case where
> either script would execute outside of explicate calls to the various
> functions. You do raise a point though that when calling into
> xloadtree, it's possible xload2 isn't there (given asynch download).
> However that makes me feel like jQuery.getScript() is actually the
> right fix.

jQeury.getScript() ensures load order, but _not_ 
the order of execution completion.
I imagine getScript is often the right fix, but the xtree code
relies on execution to setup the proper state for the prototype/
inheritance tree.  If this is not done before object instantiation
bad things happen and the instantiated objects don't have the
right methods etc.


Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

Re: [ppa-dev] Patches for ppa self-tests

[Karl O. P. <ko...@me...>]

On 05/18/2013 06:38:44 PM, Robert Treat wrote:
> On Tue, Apr 30, 2013 at 3:57 PM, Karl O. Pinc <ko...@me...> wrote:

> 
> > https://github.com/kpinc/phppgadmin/commits/selenium-enabled
> >
> > 3 patches.

<snip>

> > Makes the link "hot" only when selenium has been configured.
> 
> So, this has actually exposed a "bug" in the 5.1 release. The release
> script for each release removes the "tests" directory, and it is also
> supposed to remove the link to Selenium along with it. Turns out the
> sed on OSX doesn't agree with the sed on Linux, so that link didn't
> get removed. So, preserving the old behavior, we need to not only 
> make
> the change included in your checkout, but we would also need to
> enhance the release script to remove all this code. I guess the other
> option would be to add a branch in the logic that also checks if the
> version in config.inc.php contains a -dev or not. Thoughts?

I can see wanting to run self-tests on the released code.

This particular patch assumes that the selenium stuff is there
and changes the text of the link to note the tests are disabled.
It can tell by looking to see if the self-test config file
has been created.

It may be that we should leave this in place in the released
version, as well as the code for the tests.  On top of
this could be added a regular config parameter, defaulting
to "off" which says whether to display the self-test
link.  This would make the self-tests go away for all intents
and purposes, yet leave them there should somebody
want to run self-tests on released code.

However, I've not thought through the security implications
of leaving all the self-test code in document root.
I don't _think_ the tests will do anything at
all unless configured but I could be very wrong.

We could put some hack at the top of each test file
to ensure failure when the self-test config file
is non-existent....

> 
> >
> > https://github.com/kpinc/phppgadmin/commits/gitignore
> >
> > 1 patch.
> > Frob .gitignore to ignore emacs backup files.
> >
> 
> I prefer vim ;-)

I've been thinking about putting comments at the
bottom of all the files to set the emacs tabs
properly, etc.  Thoughts?




Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

Re: [ppa-dev] Patches to roll to 9.3

[Karl O. P. <ko...@me...>]

On 05/18/2013 06:02:50 PM, Robert Treat wrote:
> The 9.3 bits are in official head now (which means I think you can
> delete this branch now if you want to). 

Great.  Thanks.

> I wanted to do this
> independent of the help changes. 

Makes sense, if you want roll to 9.3 first.

> I suspect going forward you'll just
> want to make branches off whatever master is at, and we can worry
> about rebasing as things get pulled in. If that becomes problematic,
> we'll poke back as needed.

Ok.

> Thanks for the work so far, sorry I've 
> been
> a bit slow in getting to this, May is a pretty brutal schedule for 
> me.

I completely understand.



Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

Re: [ppa-dev] Fix of race condition in db browser frame

[Robert T. <ro...@xz...>]

This change seems a bit dubious to me. I can't see any case where
either script would execute outside of explicate calls to the various
functions. You do raise a point though that when calling into
xloadtree, it's possible xload2 isn't there (given asynch download).
However that makes me feel like jQuery.getScript() is actually the
right fix.

Robert Treat

On Tue, May 14, 2013 at 11:57 PM, Karl O. Pinc <ko...@me...> wrote:
> Hi,
>
> I've a new branch on github, browserace:
>
> https://github.com/kpinc/phppgadmin/commits/browserace
>
> Branches off origin/master, as do all my branches unless
> I mention otherwise.
>
> This fixes what seems to be a race condition.  Browsers
> may load multiple html <script> tags asynchronously,
> and so may execute them in an indeterminate order.
> Given the way the js code is written the
> xloadtree/xtree2.js file must execute before the
> xloadtree/xloadtree2.js file, and this has
> not been guaranteed.
>
> jQuery.getScript() serializes js script loading, but
> not execution.  So, I beat the problem
> over the head with a php based solution.
>
> Regards,
>
> Karl <ko...@me...>
> Free Software:  "You don't pay back, you pay forward."
>                  -- Robert A. Heinlein
>
>
> ------------------------------------------------------------------------------
> AlienVault Unified Security Management (USM) platform delivers complete
> security visibility with the essential security capabilities. Easily and
> efficiently configure, manage, and operate all of your security controls
> from a single console and one unified framework. Download a free trial.
> http://p.sf.net/sfu/alienvault_d2d
> _______________________________________________
> phpPgAdmin-devel mailing list
> php...@li...
> https://lists.sourceforge.net/lists/listinfo/phppgadmin-devel

Re: [ppa-dev] Patches for ppa self-tests

[Robert T. <ro...@xz...>]

On Tue, Apr 30, 2013 at 3:57 PM, Karl O. Pinc <ko...@me...> wrote:
<snip>
> If this isn't a good process then please let me
> know what works better.
>

This seems like a good process :-)

> https://github.com/kpinc/phppgadmin/commits/selenium-enabled
>
> 3 patches.
> Internationalizes the selenium link on the ppa intro page.

I think we should commit this.

> Makes the link "hot" only when selenium has been configured.

So, this has actually exposed a "bug" in the 5.1 release. The release
script for each release removes the "tests" directory, and it is also
supposed to remove the link to Selenium along with it. Turns out the
sed on OSX doesn't agree with the sed on Linux, so that link didn't
get removed. So, preserving the old behavior, we need to not only make
the change included in your checkout, but we would also need to
enhance the release script to remove all this code. I guess the other
option would be to add a branch in the logic that also checks if the
version in config.inc.php contains a -dev or not. Thoughts?

>
> https://github.com/kpinc/phppgadmin/commits/gitignore
>
> 1 patch.
> Frob .gitignore to ignore emacs backup files.
>

I prefer vim ;-)


Robert Treat
play: xzilla.net
work: omniti.com

Re: [ppa-dev] Patches to roll to 9.3

[Robert T. <ro...@xz...>]

The 9.3 bits are in official head now (which means I think you can
delete this branch now if you want to). I wanted to do this
independent of the help changes. I suspect going forward you'll just
want to make branches off whatever master is at, and we can worry
about rebasing as things get pulled in. If that becomes problematic,
we'll poke back as needed. Thanks for the work so far, sorry I've been
a bit slow in getting to this, May is a pretty brutal schedule for me.

Robert Treat

On Wed, May 8, 2013 at 12:56 AM, Karl O. Pinc <ko...@me...> wrote:
> Hi,
>
> I've a new branch, rollto93, that rolls ppa to 9.3
> in terms of the structure of the programs in the
> filesystem (/help and class/database/ stuff) without
> actually changing any functionality.
>
> It's based off the revhelp branch, excepting the
> last commit.  The 9.3 help system uses the newly
> introduced static id targets in the 9.3 pg source.
> (Which will probably not be rebuilt and appear
> on-line until some hours have passed.)  So,
> the help system links will work for 9.3 and
> will show less rot in the future.
>
> https://github.com/kpinc/phppgadmin/commits/rollto93
>
> Regards,
>
>
> Karl <ko...@me...>
> Free Software:  "You don't pay back, you pay forward."
>                  -- Robert A. Heinlein
>
>
> ------------------------------------------------------------------------------
> Learn Graph Databases - Download FREE O'Reilly Book
> "Graph Databases" is the definitive new guide to graph databases and
> their applications. This 200-page book is written by three acclaimed
> leaders in the field. The early access version is available now.
> Download your free book today! http://p.sf.net/sfu/neotech_d2d_may
> _______________________________________________
> phpPgAdmin-devel mailing list
> php...@li...
> https://lists.sourceforge.net/lists/listinfo/phppgadmin-devel

Re: [ppa-dev] Allow multiple PPA instances on different ports of a single server

[Karl O. P. <ko...@me...>]

On 05/17/2013 04:33:23 PM, Karl O. Pinc wrote:
> On 05/17/2013 04:24:54 PM, Karl O. Pinc wrote:
> > On 05/16/2013 10:17:35 PM, Karl O. Pinc wrote:
> > > On 05/16/2013 09:52:22 PM, Karl O. Pinc wrote:
> > > > I've a new github branch, multiport:
> > > > 
> > > > https://github.com/kpinc/phppgadmin/commits/multiport
> > > > 
> > > > Allows multiple PPA instances to be run on different 
> > > > ports of a single server.
> 
> It occurs to me to mention that the browserace branch
> should really be merged before this branch.  If not
> there will be merge conflicts, but if so, no problem.

I take it back.  I tried merging the multiport branch
first and then the browserace branch and didn't have
problems.  So either can be merged first.




Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

Re: [ppa-dev] Allow multiple PPA instances on different ports of a single server

[Karl O. P. <ko...@me...>]

On 05/17/2013 04:24:54 PM, Karl O. Pinc wrote:
> On 05/16/2013 10:17:35 PM, Karl O. Pinc wrote:
> > On 05/16/2013 09:52:22 PM, Karl O. Pinc wrote:
> > > I've a new github branch, multiport:
> > > 
> > > https://github.com/kpinc/phppgadmin/commits/multiport
> > > 
> > > Allows multiple PPA instances to be run on different 
> > > ports of a single server.

It occurs to me to mention that the browserace branch
should really be merged before this branch.  If not
there will be merge conflicts, but if so, no problem.

This thought sorta makes me want to rebase the multiport
branch off the browserace branch.....

Recommendations regards this or anything else would be helpful....

Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

Re: [ppa-dev] Allow multiple PPA instances on different ports of a single server

[Karl O. P. <ko...@me...>]

On 05/16/2013 10:17:35 PM, Karl O. Pinc wrote:
> On 05/16/2013 09:52:22 PM, Karl O. Pinc wrote:
> > I've a new github branch, multiport:
> > 
> > https://github.com/kpinc/phppgadmin/commits/multiport
> > 
> > Allows multiple PPA instances to be run on different 
> > ports of a single server.

I've pushed another patch to this branch to make 
it ooooh-oh-so-elegant.  (And better able to
accommodate extension.)


Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

Re: [ppa-dev] Allow multiple PPA instances on different ports of a single server

[Karl O. P. <ko...@me...>]

Oops, just rewrote history to fix code formatting.
Look at the branch again if you've already downloaded.

On 05/16/2013 09:52:22 PM, Karl O. Pinc wrote:
> Hi,
> 
> I've a new github branch, multiport:
> 
> https://github.com/kpinc/phppgadmin/commits/multiport
> 
> Allows multiple PPA instances to be run on different 
> ports of a single server.

Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

[ppa-dev] Allow multiple PPA instances on different ports of a single server

[Karl O. P. <ko...@me...>]

Hi,

I've a new github branch, multiport:

https://github.com/kpinc/phppgadmin/commits/multiport

Allows multiple PPA instances to be run on different 
ports of a single server.


Patches the javascript for the browser
functionality in the lefthand frame.

Patches the PPA_ID cookie name to include server port.

(I think Robert mentioned something about there
being a request out there for this.)

Regards,

Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

[ppa-dev] Fix of race condition in db browser frame

[Karl O. P. <ko...@me...>]

Hi,

I've a new branch on github, browserace:

https://github.com/kpinc/phppgadmin/commits/browserace

Branches off origin/master, as do all my branches unless
I mention otherwise.

This fixes what seems to be a race condition.  Browsers
may load multiple html <script> tags asynchronously,
and so may execute them in an indeterminate order.
Given the way the js code is written the
xloadtree/xtree2.js file must execute before the
xloadtree/xloadtree2.js file, and this has
not been guaranteed.

jQuery.getScript() serializes js script loading, but
not execution.  So, I beat the problem
over the head with a php based solution.

Regards,

Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

[ppa-dev] New branch to fix bug in servers.php

[Karl O. P. <ko...@me...>]

Hi,

New branch to fix minor bug/code cleanup.

https://github.com/kpinc/phppgadmin/commits/fixservers

Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

[ppa-dev] New branch for import into views

[Karl O. P. <ko...@me...>]

Hi,

I've made a branch for my import into view
patches.

https://github.com/kpinc/phppgadmin/commits/import

This is pretty much what I've sent to the list
before, but includes self-tests and backwards
compatibility to 7.4.

Note: Merges my rollto93 branch to get 9.3
support/backwards compatibility.

Features:
* Import into views.
* Checkbox for replacement of table or view content on import.
* Suppress display of import tab and "replace" checkbox=20
  in user interface when the db does not support
  the functionality or when the user does not have permission.
* Self-tests of user interface display. (It seems impossible
  to use selenium to self-test actual import.)

Regards,

Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

[ppa-dev] Convert help system to php classes

[Karl O. P. <ko...@me...>]

Hi,

Per xzilla:

There is a new 'classifyhelp' branch on github:

https://github.com/kpinc/phppgadmin/commits/classifyhelp

This branches off the tip of rollto93 (which in turn
branches off the useful tip of revhelp).

The patches change the help system to work like
the db class system, using classes with a
PostgresDoc class for the most recent PG version.

WARNING: This branch contains 2 fixes.  I didn't
want to rewrite history but if you want me to
I'll rebase and push them back where they belong.

The patch which converts to classes is large.
There seems no other way to do this and retain
a working system.  If you want something different
please let me know.

Regards,

Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

Re: [ppa-dev] git rebasing & help system work

[Karl O. P. <ko...@me...>]

On 05/12/2013 08:23:00 AM, Karl O. Pinc wrote:
> If you didn't get this from my email announcements,
> the rollto93 branch branches off the "useful tip"
> of the revhelp branch.  So it's really all one
> branch.

Other than that all the other branches are entirely
independent and can be considered/committed
separately.


Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

Re: [ppa-dev] git rebasing & help system work

[Karl O. P. <ko...@me...>]

If you didn't get this from my email announcements,
the rollto93 branch branches off the "useful tip"
of the revhelp branch.  So it's really all one
branch.  I wanted to get the 9.3 static doc
links in there but that meant rolling to 9.3
and the old branch name no longer seemed appropriate.
(And I wanted to ignore the last patch
which put the static 9.3 link targets in
as comments in the 9.2 help system.)

On 05/12/2013 08:07:19 AM, Karl O. Pinc wrote:
> Hi,
> 
> I don't care at all about my personal timeline.
> 
> I think there probably should be a Postgres class
> for the help system.


Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

[ppa-dev] git rebasing & help system work

[Karl O. P. <ko...@me...>]

Hi,

I don't care at all about my personal timeline.

I think there probably should be a Postgres class
for the help system.  When I first started work
I thought that not having one would help with the
roll from release to release but I think this may be
mistaken.  I'll think further.

If you don't upgrade classes/database/Connection.php
you get the default Postgres.php class for a new release.
Since Postgres.php has always explicitly pointed to a version
of the help system the help system can be/must be rolled
independently of the rest of the system.  If there was
an unversioned PostgresDoc class this would not be true.

If someone wants to do the thinking for me ....  ;-)


Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein