phppgadmin-devel — For Developers Only

Re: [ppa-dev] Fwd: Patch for ALTER TABLE CLUSTER ON

[Karl O. P. <ko...@me...>]

On 06/10/2013 09:34:14 AM, Karl O. Pinc wrote:
> On 06/09/2013 04:34:00 AM, phb07 wrote:
> > >>> As far as I can understand, it adds a capability to the alter
> > table
> > >>> functionality, namely to specify, change or remove a clustered
> > >> index
> > >>> definition.
> > >>> It does the equivalent of the "ALTER TABLE CLUSTER ON ..." and
> > >> "ALTER
> > >>> TABLE SET WITHOUT CLUSTER" sql statements.
> 
> My initial code review is here:
> 
> https://github.com/kpinc/phppgadmin/commits/altertablecluster
\
> Presenting a clustered index name of '' (the empty string)
> as an item in the select list of indexes
> may not be the most clear way to indicate the absence
> of clustering or, especially, to indicate that clustering
> should be removed.  An alternative, like a "No Clustering"
> checkbox or a index name of '<NONE>' might be better.
> But both of these choices have problems.  Using a checkbox
> raises the question of what to do with the select list.
> We could always hide the select list with javascript/jQuery
> when the No Clustering (or just "Cluster"?) checkbox
> is checked.  Reasonably painless, but extra complication.  
> And using most anything but '' as a choice
> in the select list can, possibly, conflict with an index name.
> 
> I kind of lean towards a checkbox.

I am now tending toward a 2-item radio button, no javascript
necessary:

  (o) Not Clustered
  ( ) Clustered On <indexdropdown>

(I should probably look at the page to see if this makes
sense...)

Regards,

Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

Re: [ppa-dev] Fwd: Patch for ALTER TABLE CLUSTER ON

[Jehan-Guillaume (i. de R. <io...@fr...>]

On 09/06/2013 04:19, Karl O. Pinc wrote:
> Attached is the same patch, only whitespace adjusted
> so as to apply cleanly to HEAD.

Thank you.

FYI, I started some weeks/months ago to review this patch and started
some refactoring. I don't really rmember what exactly.

I'll try to get my code back really soon, wrap my head around, and
report here so you guys can keep going with this patch if you don't mind.

As I reported unofficially, I'll not spend a lot of time in PPA code
next few month, but I'll stay around to review if/when necessary.

cheers,

> 
> I've not yet otherwise looked at it.
> 
> On 04/21/2013 11:06:02 AM, phb07 wrote:
>> Hi all,
>>
>> Has someone had a look on the patch I proposed some months ago ?
>>
>> Thanks by advance.
>> Philippe.
>>
>> -------- Message original --------
>> Sujet: 	Patch for ALTER TABLE CLUSTER ON
>> Date : 	Thu, 27 Dec 2012 12:33:09 +0100
>> De : 	phb07 <ph...@ap...>
>> Pour : 	php...@li...
>>
>>
>>
>> Hi all,
>>
>> Under my Christmas Tree, I have found the attached patch ;-).
>>
>> As far as I can understand, it adds a capability to the alter table
>> functionality, namely to specify, change or remove a clustered index
>> definition.
>> It does the equivalent of the "ALTER TABLE CLUSTER ON ..." and "ALTER
>> TABLE SET WITHOUT CLUSTER" sql statements.
>>
>> The patch should apply on the HEAD.
>> It only works for postgres version >= 8.0 as 7.4 doesn't support the
>> SET
>> WITHOUT CLUSTER clause.
>>
>> Unfortunately, Christmas Father has not tested this patch with pg7.4.
>> He has not included additional Selenium regression test too (he is 
>> not
>> yet familiar with this nice tool ;-)).
>>
>> Let me know what you think about this patch (as a first patch
>> supplied,
>> it may need some refinements). I will forward to its author...
>>
>> With my best wishes,
>> Philippe Beaudoin (beaud76)

Re: [ppa-dev] Fwd: Patch for ALTER TABLE CLUSTER ON

[Karl O. P. <ko...@me...>]

Hi Philippe (and Robert?),

On 06/09/2013 04:34:00 AM, phb07 wrote:
> >>> As far as I can understand, it adds a capability to the alter
> table
> >>> functionality, namely to specify, change or remove a clustered
> >> index
> >>> definition.
> >>> It does the equivalent of the "ALTER TABLE CLUSTER ON ..." and
> >> "ALTER
> >>> TABLE SET WITHOUT CLUSTER" sql statements.

My initial code review is here:

https://github.com/kpinc/phppgadmin/commits/altertablecluster

It contains only minor nits.

Note that I've not yet executed _any_ code.  (!)  So, I've not
seen the user interface either.  I have thoughts regardless:

Just because 7.4 can't remove clustering does not mean that
the clustering option should be non-existent.  Why not
just disappear the choice to remove clustering from the
user interface?  If we do this is should be committed as
a separate patch, ideally along with the hasAlterTableNocluster()
definition in Postgres.php, so that it can be rolled back with 
a single patch revert when 7.4 is dropped.  Or maybe not,
there might be enough manual fussing involved with dropping
7.4 that it's not worth it.

Presenting a clustered index name of '' (the empty string)
as an item in the select list of indexes
may not be the most clear way to indicate the absence
of clustering or, especially, to indicate that clustering
should be removed.  An alternative, like a "No Clustering"
checkbox or a index name of '<NONE>' might be better.
But both of these choices have problems.  Using a checkbox
raises the question of what to do with the select list.
We could always hide the select list with javascript/jQuery
when the No Clustering (or just "Cluster"?) checkbox
is checked.  Reasonably painless, but extra complication.  
And using most anything but '' as a choice
in the select list can, possibly, conflict with an index name.

I kind of lean towards a checkbox.

Thoughts or comments on any of the above?

Regards,

Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

Re: [ppa-dev] Fwd: Patch for ALTER TABLE CLUSTER ON

[Karl O. P. <ko...@me...>]

Hi Philippe,

On 06/09/2013 04:34:00 AM, phb07 wrote:
> Hi Karl,
> 
> Thanks for the code adjustment.
> I haven't yet found time to work on the regression test impact for
> this 
> patch :-(. But I keep this in my memory...

See here for better selenium docs:

https://github.com/kpinc/phppgadmin/commits/selenium-doc

Also, if you continue work on the patch remember that
more small patches are better than one large patch.


Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

Re: [ppa-dev] Fwd: Patch for ALTER TABLE CLUSTER ON

[Karl O. P. <ko...@me...>]

Never mind.  I was thinking of the CLUSTER command.

On 06/08/2013 11:07:16 PM, Karl O. Pinc wrote:
> On 06/08/2013 09:19:50 PM, Karl O. Pinc wrote:
> > On 04/21/2013 11:06:02 AM, phb07 wrote:
> 
> > > As far as I can understand, it adds a capability to the alter
> table
> > > functionality, namely to specify, change or remove a clustered 
> > index
> > > definition.
> > > It does the equivalent of the "ALTER TABLE CLUSTER ON ..." and
> > "ALTER
> > > TABLE SET WITHOUT CLUSTER" sql statements.
> 
> I'm thinking it might be a good idea to use the
> ALTER TABLE CLUSTER USING ... syntax and fall
> back to the ALTER TABLE CLUSTER ON ... syntax for
> pre 8.3.
> 
> Robert, do you have an opinion?  Is this worth the
> extra code?
> 
> 
> Karl <ko...@me...>
> Free Software:  "You don't pay back, you pay forward."
>                  -- Robert A. Heinlein
> 
> 
> ------------------------------------------------------------------------------
> How ServiceNow helps IT people transform IT departments:
> 1. A cloud service to automate IT design, transition and operations
> 2. Dashboards that offer high-level views of enterprise services
> 3. A single system of record for all IT processes
> http://p.sf.net/sfu/servicenow-d2d-j
> _______________________________________________
> phpPgAdmin-devel mailing list
> php...@li...
> https://lists.sourceforge.net/lists/listinfo/phppgadmin-devel
> 
> 




Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

Re: [ppa-dev] Fwd: Patch for ALTER TABLE CLUSTER ON

[phb07 <ph...@ap...>]

Hi Karl,

Thanks for the code adjustment.
I haven't yet found time to work on the regression test impact for this 
patch :-(. But I keep this in my memory...

>>> As far as I can understand, it adds a capability to the alter table
>>> functionality, namely to specify, change or remove a clustered
>> index
>>> definition.
>>> It does the equivalent of the "ALTER TABLE CLUSTER ON ..." and
>> "ALTER
>>> TABLE SET WITHOUT CLUSTER" sql statements.
> I'm thinking it might be a good idea to use the
> ALTER TABLE CLUSTER USING ... syntax and fall
> back to the ALTER TABLE CLUSTER ON ... syntax for
> pre 8.3.
>
> Robert, do you have an opinion?  Is this worth the
> extra code?
I don't see the ALTER TABLE CLUSTER USING in the documentation.
Only the CLUSTER command seems to have a USING clause.

Regards.
Philippe Beaudoin.

Re: [ppa-dev] Fwd: Patch for ALTER TABLE CLUSTER ON

[Karl O. P. <ko...@me...>]

On 06/08/2013 09:19:50 PM, Karl O. Pinc wrote:
> On 04/21/2013 11:06:02 AM, phb07 wrote:

> > As far as I can understand, it adds a capability to the alter table
> > functionality, namely to specify, change or remove a clustered 
> index
> > definition.
> > It does the equivalent of the "ALTER TABLE CLUSTER ON ..." and
> "ALTER
> > TABLE SET WITHOUT CLUSTER" sql statements.

I'm thinking it might be a good idea to use the
ALTER TABLE CLUSTER USING ... syntax and fall
back to the ALTER TABLE CLUSTER ON ... syntax for
pre 8.3.

Robert, do you have an opinion?  Is this worth the
extra code?


Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

Re: [ppa-dev] I left cruft on the wiki

[Karl O. P. <ko...@me...>]

On 06/07/2013 07:24:09 PM, Jehan-Guillaume (ioguix) de Rorthais wrote:

> About dropping file, you just don't have enough rights on the wiki to
> do
> so. Do you want to assume some admin task on the wiki and be in the
> @admin group ?

I'd be happy to have enough permissions to clean up after myself.


Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

Re: [ppa-dev] Fwd: Patch for ALTER TABLE CLUSTER ON

[Karl O. P. <ko...@me...>]

Attached is the same patch, only whitespace adjusted
so as to apply cleanly to HEAD.

I've not yet otherwise looked at it.

On 04/21/2013 11:06:02 AM, phb07 wrote:
> Hi all,
> 
> Has someone had a look on the patch I proposed some months ago ?
> 
> Thanks by advance.
> Philippe.
> 
> -------- Message original --------
> Sujet: 	Patch for ALTER TABLE CLUSTER ON
> Date : 	Thu, 27 Dec 2012 12:33:09 +0100
> De : 	phb07 <ph...@ap...>
> Pour : 	php...@li...
> 
> 
> 
> Hi all,
> 
> Under my Christmas Tree, I have found the attached patch ;-).
> 
> As far as I can understand, it adds a capability to the alter table
> functionality, namely to specify, change or remove a clustered index
> definition.
> It does the equivalent of the "ALTER TABLE CLUSTER ON ..." and "ALTER
> TABLE SET WITHOUT CLUSTER" sql statements.
> 
> The patch should apply on the HEAD.
> It only works for postgres version >= 8.0 as 7.4 doesn't support the
> SET
> WITHOUT CLUSTER clause.
> 
> Unfortunately, Christmas Father has not tested this patch with pg7.4.
> He has not included additional Selenium regression test too (he is 
> not
> yet familiar with this nice tool ;-)).
> 
> Let me know what you think about this patch (as a first patch
> supplied,
> it may need some refinements). I will forward to its author...
> 
> With my best wishes,
> Philippe Beaudoin (beaud76)
> 
> 
> 
> 
> 

------quoted attachment------
> ------------------------------------------------------------------------------
> Precog is a next-generation analytics platform capable of advanced
> analytics on semi-structured data. The platform includes APIs for
> building
> apps and a phenomenal toolset for data science. Developers can use
> our toolset for easy data analysis & visualization. Get a free
> account!
> http://www2.precog.com/precogplatform/slashdotnewsletter

------quoted attachment------
> _______________________________________________
> phpPgAdmin-devel mailing list
> php...@li...
> https://lists.sourceforge.net/lists/listinfo/phppgadmin-devel
> 




Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

Re: [ppa-dev] I left cruft on the wiki

[Karl O. P. <ko...@me...>]

On 06/07/2013 07:24:09 PM, Jehan-Guillaume (ioguix) de Rorthais wrote:
> On 07/06/2013 20:06, Karl O. Pinc wrote:

> I drop them, downloaded "contrib:pingplugin2.tgz", then re-uploaded 
> it
> as "contrib:pingplugin.tgz" and removed the former one.
> 
> Make sure everything is fine for you.

Sorry, the wrong tarball was on the site.  I've uploaded
contrib:pingplugin2.tgz and linked to that.  contrib:pingplugin.tgz
needs to go away.  Ideally the file should be renamed to get
rid of the 2 and the link fixed.

The difference between the 2 tarballs is that the correct
tarball contains a LICENSE file.

> 
> About dropping file, you just don't have enough rights on the wiki to
> do
> so. Do you want to assume some admin task on the wiki and be in the
> @admin group ?

Not especially.  I've enough other ppa stuff on my plate.



Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

Re: [ppa-dev] I left cruft on the wiki

[Jehan-Guillaume (i. de R. <io...@fr...>]

On 07/06/2013 20:06, Karl O. Pinc wrote:
> Hi,
> 
> In creating the new wiki page for user contributed plugins
> and adding my uselessplugin to the page I managed to upload
> 2 files that are junk.
> 
> I can't figure out how to get rid of them, or the useless
> sub-category I created by accident.
> 
> contrib:pingplugin.tgz
> contrib:contrib:pingplugin.tgz

I drop them, downloaded "contrib:pingplugin2.tgz", then re-uploaded it
as "contrib:pingplugin.tgz" and removed the former one.

Make sure everything is fine for you.

About dropping file, you just don't have enough rights on the wiki to do
so. Do you want to assume some admin task on the wiki and be in the
@admin group ?

Re: [ppa-dev] CRUD generator plugin for PPA stable

[Jehan-Guillaume (i. de R. <io...@fr...>]

On 07/06/2013 20:41, Miguel Useche wrote:
> @ioguix About file generation, i use webserver's temporary folder
> (usually /tmp). This folder have write permission on a normal
> installation because it's a common and secure way to create files. So
> there "shouldn't be" any problems. After a user downloads the zip file,
> files are deleted.

Oh, ok. It's not to create and access pages from of the plugin through
PPA then. Fine, sorry for the noise :)

> @Karl thanks for feedback, yes. I see the problems of including this
> inside ppa, but we'll see what would happen in the future. But receiving
> support from the official project (in the wiki/download page) it's great
> for me. Also, i would need to include some js (jquery) files that would
> increase ppa's file size if it doesn't' use it, so i see difficult to
> include it in the official release.

Note that jQuery is already embedded in PPA.

Re: [ppa-dev] I left cruft on the wiki

[Karl O. P. <ko...@me...>]

On 06/07/2013 05:04:55 PM, Miguel Useche wrote:
> Hello Karl, I've updated the 
> http://phppgadmin.sourceforge.net/doku.php?id=contrib page to include 
> plugin information, i sorted it alphabetically.  But i see that the
> page 
> it's not linked from the main site like the plugin's information (i 
> didn't know that it existed), we should fix this.

It didn't exist until today.

It's linked from the FAQ/Docs page and from the download page.
If you want it otherwise then wiki away!

Regards,

Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

Re: [ppa-dev] I left cruft on the wiki

[Miguel U. <mig...@sk...>]

Hello Karl, I've updated the 
http://phppgadmin.sourceforge.net/doku.php?id=contrib page to include 
plugin information, i sorted it alphabetically.  But i see that the page 
it's not linked from the main site like the plugin's information (i 
didn't know that it existed), we should fix this.

On 07/06/13 13:36, Karl O. Pinc wrote:
> Hi,
>
> In creating the new wiki page for user contributed plugins
> and adding my uselessplugin to the page I managed to upload
> 2 files that are junk.
>
> I can't figure out how to get rid of them, or the useless
> sub-category I created by accident.
>
> contrib:pingplugin.tgz
> contrib:contrib:pingplugin.tgz
>
> Really I'd like contrib:pingplugin2.tgz
> to be renamed contrib:pingplugin.tgz,
> and the link updated on the contrib page.
> But either I'm not clever enough to figure
> out how to operate the wiki or I don't have
> the required permissions.
>
> Sorry for leaving cruft around for others to clean
> up.
>
> Regards,
>
> Karl <ko...@me...>
> Free Software:  "You don't pay back, you pay forward."
>                   -- Robert A. Heinlein
>
>
> ------------------------------------------------------------------------------
> How ServiceNow helps IT people transform IT departments:
> 1. A cloud service to automate IT design, transition and operations
> 2. Dashboards that offer high-level views of enterprise services
> 3. A single system of record for all IT processes
> http://p.sf.net/sfu/servicenow-d2d-j
> _______________________________________________
> phpPgAdmin-devel mailing list
> php...@li...
> https://lists.sourceforge.net/lists/listinfo/phppgadmin-devel

-- 
Miguel Ángel Useche Castro
mig...@sk...
@skatox
Visita http://www.skatox.com/  Blog de Informática, Linux, Desarrollo Web, Software Libre, Videojuegos y mas....

Re: [ppa-dev] I left cruft on the wiki

[Miguel U. <mig...@sk...>]

Nice! I'll check it and add information about my plugin.

El 07/06/13 13:36, Karl O. Pinc escribió:
> Hi,
>
> In creating the new wiki page for user contributed plugins
> and adding my uselessplugin to the page I managed to upload
> 2 files that are junk.
>
> I can't figure out how to get rid of them, or the useless
> sub-category I created by accident.
>
> contrib:pingplugin.tgz
> contrib:contrib:pingplugin.tgz
>
> Really I'd like contrib:pingplugin2.tgz
> to be renamed contrib:pingplugin.tgz,
> and the link updated on the contrib page.
> But either I'm not clever enough to figure
> out how to operate the wiki or I don't have
> the required permissions.
>
> Sorry for leaving cruft around for others to clean
> up.
>
> Regards,
>
> Karl <ko...@me...>
> Free Software:  "You don't pay back, you pay forward."
>                   -- Robert A. Heinlein
>
>
> ------------------------------------------------------------------------------
> How ServiceNow helps IT people transform IT departments:
> 1. A cloud service to automate IT design, transition and operations
> 2. Dashboards that offer high-level views of enterprise services
> 3. A single system of record for all IT processes
> http://p.sf.net/sfu/servicenow-d2d-j
> _______________________________________________
> phpPgAdmin-devel mailing list
> php...@li...
> https://lists.sourceforge.net/lists/listinfo/phppgadmin-devel

-- 
Visita http://www.skatox.com/ : Blog de Informática, Linux, Playstation 3, Windows, Software Libre, Videojuegos, Java y mucho mas....

Re: [ppa-dev] CRUD generator plugin for PPA stable

[Miguel U. <mig...@sk...>]

@ioguix About file generation, i use webserver's temporary folder (usually /tmp). This folder have write permission on a normal installation because it's a common and secure way to create files. So there "shouldn't be" any problems. After a user downloads the zip file, files are deleted.

@Karl thanks for feedback, yes. I see the problems of including this 
inside ppa, but we'll see what would happen in the future. But receiving 
support from the official project (in the wiki/download page) it's great 
for me. Also, i would need to include some js (jquery) files that would 
increase ppa's file size if it doesn't' use it, so i see difficult to 
include it in the official release.

Also, this crud generator is usually for beginners, academic study or 
small stuff, real coders uses framework's tools like you said.

Thanks for the support, i'll the information at the wiki.

El 07/06/13 13:32, Karl O. Pinc escribió:
> On 06/07/2013 09:29:38 AM, Jehan-Guillaume (ioguix) de Rorthais wrote:
>> On 03/06/2013 18:13, Miguel Useche wrote:
>>> Hello guys,
>> Heh Miguel !
>>
>>> Some years ago I did a CRUD generator for PPA, after long time and
>> 3
>>
>>> re-wrotes (due to PHP 5.3, Leonardo's plugin's architecture and
>> official
>>> changes) I've released the plugin for the stable version of PPA.
>> However, AFAIUI, it seems the plugin is generating some PHP files.
>> Couldn't it be possible to keep them in database instead of requiring
>> a
>> local access with write permissions ?
>> It would keep things much more easy to manage and secure...but a bit
>> more complex to extract/print from the code POV. I should admit.
> My thought is that you should do
> whatever you want with it because,
> while I can't speak for the PPA project,
> it's not likely to be part of PPA proper.
> Although we welcome having
> the plugin available turning PPA into
> an application generator is beyond the scope of
> what anybody wants to maintain.
>
> I did look at the video.  It looks spiffy.  Although I have to say that
> I find code generators to be more trouble than their worth -- there's
> a reason why application frameworks (Django, werkzug, Pyramid, etc.)
> are dominant in that space.
>
>>> Hope you check it and i wonder if it's possible to have it in the
>>> official software of ppa.
>> What about creating a plugin page on the phppgadmin wiki to list
>> plugins
>> and offer them a dedicated page there if needed ?
>>
>> You could link to a github as well from such a page as instance...
> I made the page, linked from the docs/faq page.  It would be good
> to add your plugin to this new page.
>
> http://phppgadmin.sourceforge.net/doku.php?id=contrib
>
> Regards,
>
> Karl <ko...@me...>
> Free Software:  "You don't pay back, you pay forward."
>                   -- Robert A. Heinlein
>

-- 
Visita http://www.skatox.com/ : Blog de Informática, Linux, Playstation 3, Windows, Software Libre, Videojuegos, Java y mucho mas....

[ppa-dev] I left cruft on the wiki

[Karl O. P. <ko...@me...>]

Hi,

In creating the new wiki page for user contributed plugins
and adding my uselessplugin to the page I managed to upload
2 files that are junk.

I can't figure out how to get rid of them, or the useless
sub-category I created by accident.

contrib:pingplugin.tgz
contrib:contrib:pingplugin.tgz

Really I'd like contrib:pingplugin2.tgz
to be renamed contrib:pingplugin.tgz,
and the link updated on the contrib page.
But either I'm not clever enough to figure
out how to operate the wiki or I don't have
the required permissions.

Sorry for leaving cruft around for others to clean
up.

Regards,

Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

Re: [ppa-dev] CRUD generator plugin for PPA stable

[Karl O. P. <ko...@me...>]

On 06/07/2013 09:29:38 AM, Jehan-Guillaume (ioguix) de Rorthais wrote:
> On 03/06/2013 18:13, Miguel Useche wrote:
> > Hello guys,
> 
> Heh Miguel !
> 
> > Some years ago I did a CRUD generator for PPA, after long time and 
> 3
> 
> > re-wrotes (due to PHP 5.3, Leonardo's plugin's architecture and
> official 
> > changes) I've released the plugin for the stable version of PPA.

> However, AFAIUI, it seems the plugin is generating some PHP files.
> Couldn't it be possible to keep them in database instead of requiring
> a
> local access with write permissions ?
> It would keep things much more easy to manage and secure...but a bit
> more complex to extract/print from the code POV. I should admit.

My thought is that you should do 
whatever you want with it because,
while I can't speak for the PPA project,
it's not likely to be part of PPA proper.  
Although we welcome having
the plugin available turning PPA into
an application generator is beyond the scope of
what anybody wants to maintain.

I did look at the video.  It looks spiffy.  Although I have to say that
I find code generators to be more trouble than their worth -- there's
a reason why application frameworks (Django, werkzug, Pyramid, etc.) 
are dominant in that space.

> 
> > Hope you check it and i wonder if it's possible to have it in the 
> > official software of ppa.
> 
> What about creating a plugin page on the phppgadmin wiki to list
> plugins
> and offer them a dedicated page there if needed ?
> 
> You could link to a github as well from such a page as instance...

I made the page, linked from the docs/faq page.  It would be good
to add your plugin to this new page.

http://phppgadmin.sourceforge.net/doku.php?id=contrib

Regards,

Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

Re: [ppa-dev] CRUD generator plugin for PPA stable

[Jehan-Guillaume (i. de R. <io...@fr...>]

On 03/06/2013 18:13, Miguel Useche wrote:
> Hello guys,

Heh Miguel !

> Some years ago I did a CRUD generator for PPA, after long time and 3 
> re-wrotes (due to PHP 5.3, Leonardo's plugin's architecture and official 
> changes) I've released the plugin for the stable version of PPA.

Great ! Congrats :)

> You can check it at: https://github.com/Skatox/crudgen and you watch a 
> video of how it works at: https://www.youtube.com/watch?v=ZjMyptlcYg4

I hadn't time to check the whole video, it's way too long :)

However, AFAIUI, it seems the plugin is generating some PHP files.
Couldn't it be possible to keep them in database instead of requiring a
local access with write permissions ?
It would keep things much more easy to manage and secure...but a bit
more complex to extract/print from the code POV. I should admit.

> Hope you check it and i wonder if it's possible to have it in the 
> official software of ppa.

What about creating a plugin page on the phppgadmin wiki to list plugins
and offer them a dedicated page there if needed ?

You could link to a github as well from such a page as instance...

> 
> Have a nice day.
> 

Re: [ppa-dev] CRUD generator plugin for PPA stable

[Leonardo S. <l.s...@gm...>]

Miguel,

Great news! I am happy for use the new Plugin Architecture and improve the
phpPgAdmin :-)

Thank you

--
Atenciosamente
Leonardo Augusto Sápiras


2013/6/3 Miguel Useche <mig...@sk...>

> Hello guys,
>
> Some years ago I did a CRUD generator for PPA, after long time and 3
> re-wrotes (due to PHP 5.3, Leonardo's plugin's architecture and official
> changes) I've released the plugin for the stable version of PPA.
>
> You can check it at: https://github.com/Skatox/crudgen and you watch a
> video of how it works at: https://www.youtube.com/watch?v=ZjMyptlcYg4
>
> Hope you check it and i wonder if it's possible to have it in the
> official software of ppa.
>
> Have a nice day.
>
> --
> Miguel Ángel Useche Castro
> mig...@sk...
> @skatox
> Visita http://www.skatox.com/  Blog de Informática, Linux, Desarrollo
> Web, Software Libre, Videojuegos y mas....
>
>
>
> ------------------------------------------------------------------------------
> Get 100% visibility into Java/.NET code with AppDynamics Lite
> It's a free troubleshooting tool designed for production
> Get down to code-level detail for bottlenecks, with <2% overhead.
> Download for free and get started troubleshooting in minutes.
> http://p.sf.net/sfu/appdyn_d2d_ap2
> _______________________________________________
> phpPgAdmin-devel mailing list
> php...@li...
> https://lists.sourceforge.net/lists/listinfo/phppgadmin-devel
>

Re: [ppa-dev] Patches for ppa self-tests

[Karl O. P. <ko...@me...>]

On 06/06/2013 07:30:41 PM, Karl O. Pinc wrote:
> On 06/06/2013 05:23:30 PM, Jehan-Guillaume (ioguix) de Rorthais 
> wrote:
> > On 20/05/2013 23:53, Karl O. Pinc wrote:
> > > On 05/20/2013 03:16:13 PM, Jehan-Guillaume (ioguix) de Rorthais
> > wrote:
> > >> On 30/04/2013 21:57, Karl O. Pinc wrote:
> > > 
> > >>> https://github.com/kpinc/phppgadmin/commits/selenium-login
> > >>>
> > >>> 1 patch.
> > >>> Deletes cookies on selenium login so that previous
> > >>> failed or paused tests do not affect the execution of
> > >>> subsequent manually executed tests.  This allows
> > >>> the user more control over manual test execution.

> > I was just opposing syntaxes. I prefer the following form because 
> > it's
> > more consistent with other methods:
> > 
> >   $this->deleteAllVisibleCookies();
> > 
> > "$this->test(...)"  method should be used for ... tests :)

It's not consistent with other methods.  E.g. login contains:

            $this->test('open', "{$this->webUrl}/intro.php");

not:
	$this->open("{$this->webUrl}/intro.php");

I want to clear cookies during tests (repeatedly).

If cookies were to be cleared only once when the selenium
page is entered then login is the wrong place to put
$this->deleteAllVisibleCookies();
because login gets called multiple times, all
at the time the selenium page is entered.

Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

Re: [ppa-dev] Patches for ppa self-tests

[Karl O. P. <ko...@me...>]

On 06/06/2013 05:23:30 PM, Jehan-Guillaume (ioguix) de Rorthais wrote:
> On 20/05/2013 23:53, Karl O. Pinc wrote:
> > On 05/20/2013 03:16:13 PM, Jehan-Guillaume (ioguix) de Rorthais
> wrote:
> >> On 30/04/2013 21:57, Karl O. Pinc wrote:
> > 
> >>> https://github.com/kpinc/phppgadmin/commits/selenium-login
> >>>
> >>> 1 patch.
> >>> Deletes cookies on selenium login so that previous
> >>> failed or paused tests do not affect the execution of
> >>> subsequent manually executed tests.  This allows
> >>> the user more control over manual test execution.
> >>
> >> I don't like this.
> >>
> >> I prefer this syntax:
> >>
> >>   $this->deleteAllVisibleCookies();
> > 
> > I'm not sure I understand.  Your suggestion would
> > delete all cookies when the Selenium test suite
> > is entered, right?
> 
> I was just opposing syntaxes. I prefer the following form because 
> it's
> more consistent with other methods:
> 
>   $this->deleteAllVisibleCookies();
> 
> "$this->test(...)"  method should be used for ... tests :)
> 
> So, in the diff of function login, I would prefer to see:
> 
>   $this->deleteAllVisibleCookies()
> 
> instead of:
> 
>   $this->test('deleteAllVisibleCookies');

But it's not a difference in syntax it's a difference
in semantics.

$this->deleteAllVisibleCookies() deletes the cookies
whenever the selenium self-test link is clicked from
intro.php.

Whereas $this->test('deleteAllVisibleCookies') deletes
all cookies during the self-test runs every time
the self-test suite logs a user in.

The latter resets the self-test browser side environment
many times during the self-test suite execution to ensure
a consistent environment for each test.  This is what
I think is needed.

Regards,

Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

Re: [ppa-dev] Patches for ppa self-tests

[Karl O. P. <ko...@me...>]

On 06/06/2013 05:14:53 PM, Jehan-Guillaume (ioguix) de Rorthais wrote:
> On 21/05/2013 02:13, Karl O. Pinc wrote:
> > On 05/20/2013 04:53:31 PM, Karl O. Pinc wrote:
> >> On 05/20/2013 03:16:13 PM, Jehan-Guillaume (ioguix) de Rorthais 
> >> wrote:
> >>> On 30/04/2013 21:57, Karl O. Pinc wrote:
> > 
> >>>> https://github.com/kpinc/phppgadmin/commits/gitignore
> >>>>
> >>>> 1 patch.
> >>>> Frob .gitignore to ignore emacs backup files.
> >>>
> >>> Well, you can use the file ".git/info/exclude" or the one you
> >> specify
> >>> through "core.excludesfile".
> > 
> > Let me know what the verdict is on this patch so I can
> > move forward with my configs.
> 
> -1 for this patch.
> 
> FWIW, a similar patch has been discussed and (IIRC) rejected on
> pgsql-hackers as well :)

Ok.  Unless I hear otherwise from Robert I'll assume
this patch is rejected.



Karl <ko...@me...>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein

Re: [ppa-dev] Patches for ppa self-tests

[Jehan-Guillaume (i. de R. <io...@fr...>]

On 20/05/2013 23:53, Karl O. Pinc wrote:
> On 05/20/2013 03:16:13 PM, Jehan-Guillaume (ioguix) de Rorthais wrote:
>> On 30/04/2013 21:57, Karl O. Pinc wrote:
> 
>>> https://github.com/kpinc/phppgadmin/commits/selenium-login
>>>
>>> 1 patch.
>>> Deletes cookies on selenium login so that previous
>>> failed or paused tests do not affect the execution of
>>> subsequent manually executed tests.  This allows
>>> the user more control over manual test execution.
>>
>> I don't like this.
>>
>> I prefer this syntax:
>>
>>   $this->deleteAllVisibleCookies();
> 
> I'm not sure I understand.  Your suggestion would
> delete all cookies when the Selenium test suite
> is entered, right?

I was just opposing syntaxes. I prefer the following form because it's
more consistent with other methods:

  $this->deleteAllVisibleCookies();

"$this->test(...)"  method should be used for ... tests :)

So, in the diff of function login, I would prefer to see:

  $this->deleteAllVisibleCookies()

instead of:

  $this->test('deleteAllVisibleCookies');

Re: [ppa-dev] Patches for ppa self-tests

[Jehan-Guillaume (i. de R. <io...@fr...>]

On 21/05/2013 02:13, Karl O. Pinc wrote:
> On 05/20/2013 04:53:31 PM, Karl O. Pinc wrote:
>> On 05/20/2013 03:16:13 PM, Jehan-Guillaume (ioguix) de Rorthais 
>> wrote:
>>> On 30/04/2013 21:57, Karl O. Pinc wrote:
> 
>>>> https://github.com/kpinc/phppgadmin/commits/gitignore
>>>>
>>>> 1 patch.
>>>> Frob .gitignore to ignore emacs backup files.
>>>
>>> Well, you can use the file ".git/info/exclude" or the one you
>> specify
>>> through "core.excludesfile".
> 
> Let me know what the verdict is on this patch so I can
> move forward with my configs.

-1 for this patch.

FWIW, a similar patch has been discussed and (IIRC) rejected on
pgsql-hackers as well :)

> Karl <ko...@me...>
> Free Software:  "You don't pay back, you pay forward."
>                  -- Robert A. Heinlein