Re: [ppa-dev] custom aggregates

[Robert T. <xz...@us...>]

Patch applied.  I refactored it a bit with the following:

* remove the case 1/2 stage  doCreate & doAlter bits and replace that with 
full doSaveCreate/doSaveAlter functions.  

* split up the aggregate functions in Postgres73.php; move create and drop 
functions to Postgres.php, move alter function to Postgres74.php, leave the 
namespace sql version of list aggregates in Postgres73.php.  I also create a 
hasalteraggregate() Postgres.php and Postgres74.php as appropriate. 

Please feel free to check over the code I committed, couldn't hurt to have 
some extra eyes, especially if you're running a pre8.1 pg, which is all I 
had.  One good place to look for trouble is on the demo server, which goes 
back to 7.2 iirc. 

Thanks again for the patch, nice work!

Robert Treat

On Tuesday 08 August 2006 19:03, Javier Carlos wrote:
>    Hi Robert,
>
>    I'm sending you the complete patch for custom aggregates with the
> issues you mentioned in the last mail corrected/implemented.
>
>    Regards,
>
>    Javier
>
> > Wow cool.  Looks pretty good, here are some issues:
> >
> > * cancel on the alter page doesnt cancel, it alters.
> >
> > * on the create page, it emits the sql statement used to create the agg
> > (you
> > have an uncommented echo statement)
> >
> > * what do you think about having a page that you click on the name of the
> > aggregate and it gives you all of the properties of that aggregate?  We
> > could
> > then link to that from the tree.
> >
> > * according to the patch, you added the beck end parts to support
> > altering comments on an aggregate, but I couldn't figure out how to do it
> > from the interface.
> >
> > lmk what you think.  nice work so far.
> >
> > Robert Treat
> >
> > On Tuesday 11 July 2006 16:31, Javier Carlos wrote:
> >>    Robert,
> >>
> >>    I'm sending you the diff for custom aggregates (create, modify, drop
> >> them); I'll wait for your comments about the code.
> >>
> >>    Regards,
> >>
> >>    Javier

-- 
Robert Treat
Build A Brighter LAMP :: Linux Apache {middleware} PostgreSQL