[ppa-help] [ phppgadmin-Bugs-1350874 ] two errors (+ fixes)

[SourceForge.net <no...@so...>]

Bugs item #1350874, was opened at 2005-11-07 21:29
Message generated for change (Comment added) made by xzilla
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418980&aid=1350874&group_id=37132

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General
Group: 3.5.6
>Status: Closed
>Resolution: Wont Fix
Priority: 5
Submitted By: Gordon (gbateson)
Assigned to: Nobody/Anonymous (nobody)
Summary: two errors (+ fixes)

Initial Comment:
Hi,
thanks very much for creating and maintaining
phpPgAdmin. It's a magnificent peice of software. 

My setup:
    Windows XP
    Apache 2.0 (Win32)
    PHP 5.0.5
    PostgreSQL 8.0.4
    phpPgAdmin 3.5.6

I came across a couple of error messages, so I would
like to report them along with the fixes I used, in the
hope that this will allow you to quickly modify your
scripts, should you choose to do so.

Error Message 1
==============
Notice: Undefined index: pg_dump_path in
C:\ApacheFriends\xampp\phpPgAdmin\classes\Misc.php on
line 34

To reproduce error 1
================
Login to phpPgAdmin and click on a table name in the
left hand menu

Fix for error 1
===========
modify "isDumpEnabled" function in
"phpPgAdmin\classes\Misc.php" to test whether
"'pg_dumpall_path'" and "'pg_dumpall_path'" are set.

function isDumpEnabled($all = false) {
	global $conf;
	
	if ($all)
		return (
		
isset($conf['servers'][$_SESSION['webdbServerID']]['pg_dumpall_path'])
			&&
$conf['servers'][$_SESSION['webdbServerID']]['pg_dumpall_path']
!== null 
			&&
$conf['servers'][$_SESSION['webdbServerID']]['pg_dumpall_path']
!= ''
		);
	else
		return (
		
isset($conf['servers'][$_SESSION['webdbServerID']]['pg_dump_path'])
			&&
$conf['servers'][$_SESSION['webdbServerID']]['pg_dump_path']
!== null 
			&&
$conf['servers'][$_SESSION['webdbServerID']]['pg_dump_path']
!= ''
		);
}

Error Message 2
==============
Notice: Undefined index: desc in
C:\ApacheFriends\xampp\phpPgAdmin\login.php on line 128

To reproduce error 2
================
display login screen. The message is hidden in the
"Server" drop-down menu

Fix for error 2
============
add a test to check that 'desc' is set in the loop
which generates the "Server" drop down menu on the
login screen in "phpPgAdmin/login.php"

for ($i = 0; $i < sizeof($conf['servers']); $i++) {
	if (isset($conf['servers'][$i]['desc'])) {
		echo "<option value=\"{$i}\"",
			($i == $_POST['formServer']) ? '
selected="selected"' : '',
			">", htmlspecialchars($conf['servers'][$i]['desc']),
"</option>\n";
	}
}


----------------------------------------------------------------------

Comment By: Robert Treat (xzilla)
Date: 2006-06-30 15:40

Message:
Logged In: YES 
user_id=204589

Your version of PostgreSQL is no longer supported by 
phpPgAdmin.  It is highly recommended to upgrade your 
PostgreSQL installation.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418980&aid=1350874&group_id=37132