Menu
▾
▴
[ppa-help] [ phppgadmin-Feature Requests-1072396 ] Adaptive TextArea
|
From: SourceForge.net <no...@so...> - 2005-02-20 04:37:07
|
Feature Requests item #1072396, was opened at 2004-11-24 22:37 Message generated for change (Comment added) made by mr-russ You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=418983&aid=1072396&group_id=37132 Category: Interface >Group: Next Release >Status: Closed Priority: 5 Submitted By: Juergen Weigert (jnweiger) Assigned to: Russell Smith (mr-russ) Summary: Adaptive TextArea Initial Comment: I use text fields in Postgres to store descriptive prose that varies from 1 to 100 lines. phpPgAdmin limits its TextArea input fields to 5 lines of text. the attached patch makes the TextArea adapt its size (roughly) to the contents. This patch is in the public domain. jw...@su... ---------------------------------------------------------------------- >Comment By: Russell Smith (mr-russ) Date: 2005-02-20 15:37 Message: Logged In: YES user_id=361841 I have applied a patch that achieves the suggested adaption. However do to recent CVS changes, the patch here would not apply cleanly, and it does not have an upper bound. The applied patch has an upper bound of 20, as proposed by ska-fan. Thanks for the idea, and intial implementation, Credit has still been given. Regards Russell Smith. ---------------------------------------------------------------------- Comment By: Markus Bertheau (ska-fan) Date: 2005-02-16 01:52 Message: Logged In: YES user_id=1080922 I'd say 20. ---------------------------------------------------------------------- Comment By: Russell Smith (mr-russ) Date: 2005-02-15 16:42 Message: Logged In: YES user_id=361841 I'll make a against CVS, and apply with the relevant maximum. Any specific suggestions on a max value? 10, 15? ---------------------------------------------------------------------- Comment By: Markus Bertheau (ska-fan) Date: 2005-02-15 06:27 Message: Logged In: YES user_id=1080922 Robert, good to know that now. Thanks :) I think the patch needs a maximum number of rows for the textarea, else it looks fine. ---------------------------------------------------------------------- Comment By: Robert Treat (xzilla) Date: 2005-02-15 05:55 Message: Logged In: YES user_id=204589 Markus, the whole point of my original complaint was that you can not just "do whatever you want" with public domain code... for example you can not claim copyright on public domain works, which we currently claim on all the code we release. I'm not trying to be difficult on this, just that at the time the patch first came in I happened to be researching this very topic and so the red flags came up. Now that Jürgen has stated that he is willing to allow us to claim copyright on it, we're in the clear, at least enough that we ought to go about commiting the patch. Has anyone implemented it and feels comfortable committing it? Russ? (I hadn't looked due to genie in a bottle type legal fears) ---------------------------------------------------------------------- Comment By: Juergen Weigert (jnweiger) Date: 2005-02-15 04:03 Message: Logged In: YES user_id=395282 sorry for creating confusion. The patch is mutch too simple to claim copyright for it. Just go ahead and relicense and/or add your own copyright, what ever you want... If somebody speaks up, I'll officially pass along any rights that I may have on the code. No problem. ---------------------------------------------------------------------- Comment By: Markus Bertheau (ska-fan) Date: 2005-02-15 03:36 Message: Logged In: YES user_id=1080922 Jürgen explicitly said that the patch is in the public domain, so we can do with it what we want. ---------------------------------------------------------------------- Comment By: Robert Treat (xzilla) Date: 2005-02-04 07:50 Message: Logged In: YES user_id=204589 Been a bit since I read the law on this, but if we were to do that we would need to modify any of the files mentioning copyright (like the LICENSE file) to point out that we don't have copyright on those code changes (since claiming copyright on public domain works is illegal) ---------------------------------------------------------------------- Comment By: Russell Smith (mr-russ) Date: 2005-02-03 22:38 Message: Logged In: YES user_id=361841 If the patch is public domain, we can do whatever we like with it, including relicense it. If that is the only issue with this patch, could it be applied? Given there is no copyright notice, does that mean that it is public domain? ---------------------------------------------------------------------- Comment By: Robert Treat (xzilla) Date: 2004-11-26 04:45 Message: Logged In: YES user_id=204589 I haven't looked at the patch, but I don't think we can accept it. We generally require all patches to assign copyright to the phppgadmin development group in case we have to update the license in the future, and your patch can not fall within that requirement. If you can submit a patch that is not public domain, and assign the copyright over to the group we can accept that. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=418983&aid=1072396&group_id=37132 |
