[ppa-help] [ phppgadmin-Bugs-2876418 ] SQL error message displayed with variable pitch

[SourceForge.net <no...@so...>]

Bugs item #2876418, was opened at 2009-10-11 17:35
Message generated for change (Comment added) made by nirajb
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418980&aid=2876418&group_id=37132

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General
Group: 4.2.2
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Philippe Cloutier (chealer)
Assigned to: Robert Treat (xzilla)
Summary: SQL error message  displayed with variable pitch

Initial Comment:
The SQL error messages you get when using the SQL window are not displayed correctly. The font is not correct, even if <pre> is used, due to the pre.data CSS selector's font-family definition to a variable-width font (this is trivial to debug with Firebug).

This causes the arrow pointing the error to display not quite in line with the place it's intended to be.

----------------------------------------------------------------------

Comment By: Niraj Bhawnani (nirajb)
Date: 2010-01-03 15:37

Message:
Note sure if I committed correctly.. I don't use GIT normally, but the
commit did appear to go through. I guess it didn't..

Lucida Console is Windows' default fixed width font that's used in Notepad
since Windows 2000 or XP. It's more readable than Courier New when the font
size is small.

Courier New has been available in Windows for a very long time and so is
probably more compatible.. It is also a part of the "msttcorefonts" package
that contains Microsoft fonts for Linux platforms.

DejaVu Sans Mono is a nice Linux monospaced font.. it's got a Wikipedia
article if you want to see what it looks like. It's also included in most
Linux distros, I think. Definitely is in Ubuntu.

Finally if a system doesn't have any of those fonts, it falls back to the
system's default monospaced font. So while it may look different on
different systems, it's always monospaced.

Other font definitions in the CSS file are also similar in style, though
none of them are monospaced. For example:
arial, tahoma, verdana, helvetica, sans-serif, serif;
The first 3 fonts are Windows specific. The next one comes with Macs but
is not on Windows by default, then it falls back to system default fonts.

----------------------------------------------------------------------

Comment By: Robert Treat (xzilla)
Date: 2010-01-03 05:07

Message:
 It isn't really clear what you committed or where you committed it, but if
it was just changing the font names, can you explain how your fix isn't
simply a fix that only works on your computer, likely breaking things for
others (I've never heard of Lucidia Console per say, though I would guess
there are recommended fixed-width fonts that should be used)? 

----------------------------------------------------------------------

Comment By: Robert Treat (xzilla)
Date: 2010-01-03 05:07

Message:
 It isn't really clear what you committed or where you committed it, but if
it was just changing the font names, can you explain how your fix isn't
simply a fix that only works on your computer, likely breaking things for
others (I've never heard of Lucidia Console per say, though I would guess
there are recommended fixed-width fonts that should be used)? 

----------------------------------------------------------------------

Comment By: Niraj Bhawnani (nirajb)
Date: 2009-11-07 21:46

Message:
Committed fix to GIT repository

----------------------------------------------------------------------

Comment By: Niraj Bhawnani (nirajb)
Date: 2009-11-07 21:21

Message:
I attempted to use the GIT repository but it seems it's broken so I don't
have access to the latest files but to correct this in the official 4.2.2
release:

Change line 360 in themes/default/global.css from:
	font-family: arial, tahoma, verdana, helvetica, sans-serif, serif;
to:
	font-family: "Lucida Console", "Courier New", "DejaVu Sans Mono",
monospace;

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=418980&aid=2876418&group_id=37132