#148 loginUsername & loginPassword not different for every server

4.2
open
None
5
2007-04-18
2007-01-16
No

You should prefix or suffix a unique identifier to the loginUsername and loginPassword form fields for each server. The problem I am having is when I tell it to remember the login information on Firefox, it remembers it but is prefills with the same information every time because the form field names don't change for each server.

Discussion

  • Robert Treat

    Robert Treat - 2007-01-21
    • labels: 441077 -->
    • assigned_to: chriskl --> nobody
    • milestone: 673984 -->
     
  • Russell Smith

    Russell Smith - 2007-04-14

    Logged In: YES
    user_id=361841
    Originator: NO

    Do you have any examples of other sites or applications that do this?

    I'm hesitant to implement it, as if you are saving passwords, you should be able to type your username in before you get the password filled in.

    Do you have the same username on multiple servers with a different password?

     
  • Russell Smith

    Russell Smith - 2007-04-14
    • assigned_to: nobody --> mr-russ
     
  • Matthew Schultz

    Matthew Schultz - 2007-04-14

    Logged In: YES
    user_id=862868
    Originator: YES

    In fact you are correct, I am using the same username for multiple servers which is causing password collisions and making the browsers ability to remember passwords useless.

     
  • Russell Smith

    Russell Smith - 2007-04-15
    • milestone: --> 4.2
     
  • Russell Smith

    Russell Smith - 2007-04-18
    • status: open --> closed
     
  • Russell Smith

    Russell Smith - 2007-04-18

    Logged In: YES
    user_id=361841
    Originator: NO

    I have implemented this in CVS, but only the password is different for each server. If this continues to give problems, please post a bug and I will add loginUsername as well.

     
  • Matthew Schultz

    Matthew Schultz - 2007-04-18
    • status: closed --> open
     
  • Matthew Schultz

    Matthew Schultz - 2007-04-18

    Logged In: YES
    user_id=862868
    Originator: YES

    I'm not sure how this fixes the problem? The password manager for firefox, seamonkey, etc stores login/password combinations based on domain. I just did a checkout of CVS to test the change it does not work as expected. When I am on any server, it prompts me with all the usernames of the domain instead of just the ones on the domain and that server. The result is I have to choose from multiple usernames of the same name and only the username is autocompleted where the password is left blank unless I select exactly the one that has a password attached to it. So as I mentioned before, both the username and password fields need to be unique for every server. If both of these fields are unique, it will only prompt me with a selection of usernames and passwords for that server and I won't have to pick between multiples of the same username because postgresql usernames must be unique.

     
  • Matthew Schultz

    Matthew Schultz - 2007-06-11

    Logged In: YES
    user_id=862868
    Originator: YES

    File Added: login.php.patch

     
  • Matthew Schultz

    Matthew Schultz - 2007-06-11

    Logged In: YES
    user_id=862868
    Originator: YES

    File Added: lib.inc.php.patch

     
  • Matthew Schultz

    Matthew Schultz - 2007-06-11

    Logged In: YES
    user_id=862868
    Originator: YES

    Those patches ought to take care of the problem. I have tested it out and it prefills the login form properly based on the server.

     
  • Matthew Schultz

    Matthew Schultz - 2007-09-18

    login.php.patch

     
  • Matthew Schultz

    Matthew Schultz - 2007-09-18

    Logged In: YES
    user_id=862868
    Originator: YES

    File Added: login.php.patch

     
  • Matthew Schultz

    Matthew Schultz - 2007-09-18

    Logged In: YES
    user_id=862868
    Originator: YES

    Any chance the username aspect will be implemented soon? It should be a fairly simple task to implement these patches on HEAD.

     

Log in to post a comment.