#48 UI - small html change in frame options
The following entry allows users to adjust the
horizontal default width between the two frames making
a big difference in usability, IMHO.
I tested the changes with IE6.0 and NS6.1 on Win2K
Server machines. They need further testing, but should
work at least as well as the original settings. For
most users, they will be able to customize and not
have to futz with the tree-view not fitting right on
the left-hand side.
I appologize if this is not the right patch file
format, I need some assistance in generating proper
format files as I am using wincvs and this is what the
diff command gave me, all the details are there, but
need to be applied exactly. (about 45 min worth of
testing went into it)
Enjoy, I did not lint the html but was pretty careful
about it.
Discussion
diff of revision 1.14 of index.php3
Logged In: YES
user_id=144058
Hi!
Well I've had a look at your patch but find some problems
with it:
1) most of the selectors you added in the
opening "<frameset...>" tag are not valid selectors
according to xhtml1.0 and html4.01 specifications (see at
www.w3c.org).
Indeed the only valid selector is "frameborder" but should
be applied to the "<frame..>" tag with an 1/0 boolean value!
2) in the "<frame>" tag, scrolling default valu is "auto"
by default, so I don't think we need to add it, isn't it?
In a word, it means that your patch must be tested with
other browsers (IE5 for Mac, Konqueror....) before we may
apply it.
Regards,
Loc
Logged In: YES
user_id=218146
yes, auto is the default, I was just being explicit in that
case. I will play with it some more, but my intent was to
get it to work for most browsers. I can test with IE 5 and
5.5 I belive later tonight if DC is not wiped off the face
of the earth. But the patch makes the application
significantly easier to use. I will look up the html spec
and see if I can squeeze it in. I think if you are going to
use frames, they need to be usable. I tried many
variations, and this one was what worked. I ran into the
statement about the submissions too late, but ran into the
thing about being html4.1 safe and all and thought this
would be your response.
Logged In: YES
user_id=144058
Commited into the cvs tree.
Thanks again,
Loc