Menu

#374 (ok 2.11.1) Avoid css reloading on every click

closed-accepted
None
1
2014-09-18
2007-09-04
No

Since $_SESSION now changes (almost?) on any click in pma 2.11 after introducing saving sql history and some such, the "nocache" value must not depend any longer on set_mtime. Also using max() is preventing css reload on theme change if source_mtime has the highest(latest) value. Patch for libraries/Config.class.php attached.

Discussion

  • Jürgen Wind

    Jürgen Wind - 2007-09-04

    using mtime_info instead of set_mtime for "nocache"

     
  • Jürgen Wind

    Jürgen Wind - 2007-09-16
    • summary: Avoid css reloading on every click --> (pma2.11/ 3 ) Avoid css reloading on every click
     
  • Marc Delisle

    Marc Delisle - 2007-09-17
    • assigned_to: nobody --> lem9
     
  • Marc Delisle

    Marc Delisle - 2007-09-17
    • summary: (pma2.11/ 3 ) Avoid css reloading on every click --> (ok 2.11.2) Avoid css reloading on every click
    • priority: 5 --> 1
    • status: open --> open-accepted
     
  • Marc Delisle

    Marc Delisle - 2007-09-17

    Logged In: YES
    user_id=210714
    Originator: NO

    Merged in subversion, thanks.

     
  • Jürgen Wind

    Jürgen Wind - 2007-09-17

    Logged In: YES
    user_id=1383652
    Originator: YES

    a) why not for pma 2.11.1(-rc2)
    b) sorry, the explanation doesn't refrect the new return value:
    - * returns time of last config change.
    - * @return int Unix timestamp
    should read like:
    + * returns a unique value to force a css reload if either the config or the theme changes
    + * @return int
    (or similar)

     
  • Marc Delisle

    Marc Delisle - 2007-09-18

    Logged In: YES
    user_id=210714
    Originator: NO

    OK

     
  • Marc Delisle

    Marc Delisle - 2007-09-18
    • summary: (ok 2.11.2) Avoid css reloading on every click --> (ok 2.11.1) Avoid css reloading on every click
     
  • Marc Delisle

    Marc Delisle - 2007-09-20
    • status: open-accepted --> closed-accepted