Hi!
The shipped phpMyAdmin favicon is 18kB large:
-rw-r--r-- 1 thijs root 18902 2007-06-15 19:27 favicon.ico
That seems quite overkill for a 16x16 image, it seems to contain some extraneous data. I've recreated the same icon, and now it's just 1400 bytes:
-rw-r--r-- 1 thijs root 1406 2007-07-09 15:39 favicon.ico
Please find attached the updated file.
thanks,
Thijs
Sensible favicon
Logged In: YES
user_id=210714
Originator: NO
Moved to patches.
Logged In: YES
user_id=210714
Originator: NO
Merged in subversion, thanks.
Logged In: YES
user_id=285765
Originator: YES
And thank you for the quick resolution! :-)
Logged In: YES
user_id=326580
Originator: NO
yes, this would be an overkill for a 16x16 icon,
these "some extraneous data" are icons in size 32x32 - i do not know what type of icon edit/viewer you where using, but it should had been displayed to you
i would vote against removing this larger icons from the favicon file.
Logged In: YES
user_id=210714
Originator: NO
Sebastian,
is there a case where a browser can display the favicon larger than 16x16?
Logged In: YES
user_id=326580
Originator: NO
depends on the browser how they display their favorites/bookmarks
depends on OS how they display favorites/bookmarks or URL shortcuts (for example placed on desktop)
depends on resolution (DPI or PPI) setup for output medium on the OS
Logged In: YES
user_id=210714
Originator: NO
Thanks for the explanations. On Windows XP (1280 x 1024), I made some tests.
Firefox 2, browser tab: I can't see an image larger than 16x16
, URL shortcut: I only see Firefox image, not PMA
MSIE 7, browser tab: I can't see an image larger than 16x16
, URL shortcut: image is PMA but the same from trunk, compared to 2.10.2.
Logged In: YES
user_id=326580
Originator: NO
with resolution i did not mean 'monitor resolution'
for example on Windows 2000 and XP it is called DPI, on Vista it is called DPI/PPI
there you can configure how much pixels are 1 inch
f.e.: the higher the monitor resolution the smaller the elements on the desktop including font, setting this to 1600x1240 gives you a clear sharp desktop (very good when working with large images or something else) but it also decreases font sizes, making it hard readable, so you can rise the DPI, by default the font has the height of 10 px (about 1-2mm on 1600x1240) now you can correctly setup setup your DPI making fonts larger and symbols, fonts now f.e. user 16px in height, the same applies to icons, the same icon is now displayed with 150% in size (or more depending on selected DPI) now Windows uses automatically the next larger icon stored in the icon source (.ico, .dll, .exe, ...) ... i think there is a similar way how Linux or Mac handles this
the above describes only the case for the default small icons, but you can also view favorites with large icons on windows (C:\Doocuments\User\Favoriten), i know they lacking the Favicon on XP, but i think this will change)
short: even if currently you can not see a place where larger icons than 16x16 are used you know not for sure that they are not used, and probably more likely will not be used in future (i did not check Vista or any Linux Desktop or Mac).
so does it really hurt to have a 19KiB large favicon, as they are stored in browser cache?
Logged In: YES
user_id=210714
Originator: NO
Ok I'll revert this patch.
Logged In: YES
user_id=285765
Originator: YES
If there will be ways to view a different sized icon in the future, I suggest to revert the patch only when such functionality is actually available. We don't know if and when larger icons will be supported. It seems premature to increase the filesize more than tenfold for an unknown feature that may be available in the future.
Logged In: YES
user_id=326580
Originator: NO
i really do not know all places where favicons are used, and if they take advantage of larger icons, but not knowing this does not mean that it isn't used!
some examples, possible not important for phpMyAdmin sites, but who knows:
- there are plugins for blogs which display favicon for trackbacks
- there are linklists which support favicon to be displayed right to the link
- bookmark services
- plugins of what type ever handling links to be presented to users in what app ever
not implementing a feature because it is not supported leads to not support cause it is not implemented leads to not implemented cause it is not supported ...
you can replace support and implement also with use ...
Logged In: YES
user_id=210714
Originator: NO
kink,
do you see a situation when this file is not cached by the browser (apart from when a user blocks all caching) ?
Logged In: YES
user_id=1312539
Originator: NO
This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).