#763 (ok 4.5) Warning before silent data conversion/truncation

[lakshmiprasanna]

1.In phpMyAdmin open the database
2.Try to insert a character set for integer type of values
for a primary key having auto increment property
3.See that it is accepting it
4.Try to retreive the record set
5.See that in place of characters it has just
autoincremented the values

[Aayush]

(y) I liked the idea of jQuery validation.. and I would like to implement that.. But even to implement that, it is important to to pass the value of "size" and "data max length" correctly even if it is char(1). your views..?

[Marc Delisle]

Indeed, a CHAR(1) receiving a value too large must generate a pre-warning.

[Aayush]

So, I take it a yes from you to my last qstn, " if I should dig more to find why it is done so and change the possible minimum value of "size" and "data max length" to 1 (if possible)". Then I will start working on the jQuery validation.
Thank you..

[Marc Delisle]

Well, I don't remember why we put a minimum length of 4 there, so I'm not sure about your last question.

[Aayush]

ok.. If I find something. I will report to you. :)

[Aayush]

hi Marc.
Today I made this request https://github.com/phpmyadmin/phpmyadmin/pull/1622
Please review this. I played around javascript and used jQuery form validation api.
Since, I was not able to find the reason of min length 4 in char/varchar, so I didn't touched the php file, rather used some innovative way to fix this exception.
I wanted to ask you one thing. When I was commiting my changes, I got this warning "LF replaced by CRLF" for the jQuery files "jquery.validate.js" and "additional-method.js" which I added in jquery folder. I searched on Google and used "git config --global core.autocrlf false" to remove warning. Please can you enlighten me on this.
Thank you

[Marc Delisle]

Hi Aayush,
just to confirm, you are probably working on a Windows environment, right?

[Aayush]

Yes Marc..
I was working on windows.

[Marc Delisle]

I am not familiar with working on git under Windows, please ask on the phpmyadmin-devel list. Meanwhile, your commit contains tab characters, please fix this.

[Aayush]

Ok..
I believe, I have already fixed the tab character issue with my 2nd commit. phpmyadmin-bot didn't report any such warning on my 2nd issue. Please see.. Basically that tab issue was in the jquery files I added. I forgot to check them for tab and added directly, which I corrected later.

[Marc Delisle]

I confirm that the tab character was fixed; I was reading the early bot report.