#1451 HTML5 input tag enhancements

Needs_planning
wont-fix
nobody
interface (8)
Normal
2015-05-06
2013-08-18
Ann + J.M.
No

HTML5 adds support for new input field types and attributes. phpMyAdmin should make use of them (such as input[type=number|date|time], min|max|required|placeholder) to enhance UX.

Discussion

  • Ann + J.M.
    Ann + J.M.
    2013-09-08

    • summary: HTML5 input tag enhancements --> (ok 4.1) HTML5 input tag enhancements
    • status: open --> fixed
    • Priority: 5 --> 1
     
  • Marc Delisle
    Marc Delisle
    2014-01-22

    • summary: (ok 4.1) HTML5 input tag enhancements --> HTML5 input tag enhancements
    • status: fixed --> open
    • Group: Next_release --> Needs_planning
    • Priority: 1 --> 5
     
  • Aayush
    Aayush
    2014-03-12

    i was thinking of working over this feature request along with integration of another feature.
    In the insert page, input text fields have no check to prevent the user from giving irrelevant data, like giving characters input in int type field or out of range value.
    Once, form is submitted, error report is generated but i feel, a better feature would be to prevent the user from giving such value beforehand.
    this can be done by giving no response to key hit for irrelevant values. like in int type fields, no response should be given on character key hit. or on passing irrelevant data, some red mark or pop up message can be given.
    please, give your thoughts over this.

     
  • Marc Delisle
    Marc Delisle
    2015-01-08

    Ann + J.M.,
    what's the status on this feature?

     
  • I think this ticket can be marked as implemented since most of the UI use new HTML5 attributes for input fields. Further, input validation has also been implemented.

     
    • Marc Delisle
      Marc Delisle
      2015-05-06

      Madhura,
      On the Insert panel I don't see new input types (still input type="text").

       
      • I see.
        However, we cannot use date and time due to https://sourceforge.net/p/phpmyadmin/bugs/4218/ affecting chrome. I suppose this will also apply to datetime when chrome started supporting it.
        The only other type that can be used in inset page is number and I will see whether we can incorporate that.

         
        • Input type number has been used and later got removed (probably accidentally). See https://github.com/phpmyadmin/phpmyadmin/commit/11ae13f1772ad74aca63e069ca629089534ad58e#commitcomment-11064960

          However, IMO we should not restrict the input type since the functions that can be applied on these values. For example, an int column should facilitate inserting real values with ROUND() function.

           
          • Marc Delisle
            Marc Delisle
            2015-05-06

            Do we really need to change the input type, now that we have js-based validation?

             
            • Exactly. I'm in favor of not changing input type and keeping it as 'text' in insert page.

               
  • Marc Delisle
    Marc Delisle
    2015-05-06

    • status: open --> wont-fix