I can't reproduce either, the screencast attached appears pretty fast. Can you tell exact steps and whether the database you are searching is necessarily on the same/different page as the pagination ?
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I can reproduce it:
It's important to have many databases because then a pagination filter shows up (or lower the databases per page setting).
In short:
Navigate to page 2. Enter a filter value of a database which is on page 2.
Then the error message will appear.
In case you have a filtered result and pagination at page 2, you can repeat the reproduction by F5 and try to figure out what's going on. Because it also shows up after F5 - no ajax request made - it should be in php code.
You can extend reproduction and compare requests by doing:
- Reset filter (X)/navigate back to first page
- F5
- Navigate to second page
- (Open console - network tab)
- Click on database item (opens)
- Fill in database name
- Click on database item (fails - you see error message in response data)
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I am able to reproduce it in current master as well as QA_4_3 . Simply go on next page for database navigation and search a database which is already there then click on that database.
I am looking into it.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
During usage in a ongoing session I mentioned in 'sessionStorage' the values for navTree and page are 'undefined'. After deleting (or close/open tab) both variables I can see HTML data is set and no more problems appeared.
You can question yourself the way parts of the navigation pane are saved temporary.
Generated HTML can be a risk when you don't verify it the next time you use it. (tested by adjusting variables -> it injects code into page). Maybe rebuilding from JSON data or add hash+check is an option.
I like the new behavior to search all databases on the server. The given label is technically correct, but from user point of view incorrect. It should be something like
'To search all databases on server, press Enter after a search term'.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Cannot reproduce in 4.3.7. I click on "1 other result found".
I messed up the title. It happens when you use the database filter not the table filter.
Here is a short video:
http://screencast.com/t/bwHoLma14kBr
I can't reproduce either, the screencast attached appears pretty fast. Can you tell exact steps and whether the database you are searching is necessarily on the same/different page as the pagination ?
I can reproduce it:
It's important to have many databases because then a pagination filter shows up (or lower the databases per page setting).
In short:
Navigate to page 2. Enter a filter value of a database which is on page 2.
Then the error message will appear.
In case you have a filtered result and pagination at page 2, you can repeat the reproduction by F5 and try to figure out what's going on. Because it also shows up after F5 - no ajax request made - it should be in php code.
You can extend reproduction and compare requests by doing:
- Reset filter (X)/navigate back to first page
- F5
- Navigate to second page
- (Open console - network tab)
- Click on database item (opens)
- Fill in database name
- Click on database item (fails - you see error message in response data)
Here is a longer screencast
http://screencast.com/t/3G20WKjo
I am able to reproduce it in current master as well as QA_4_3 . Simply go on next page for database navigation and search a database which is already there then click on that database.
I am looking into it.
Please try https://github.com/phpmyadmin/phpmyadmin/pull/1466 which also includes other usability improvement in fast filter.
Last edit: Atul Pratap Singh 2015-01-20
I've applied the PR.
During usage in a ongoing session I mentioned in 'sessionStorage' the values for navTree and page are 'undefined'. After deleting (or close/open tab) both variables I can see HTML data is set and no more problems appeared.
You can question yourself the way parts of the navigation pane are saved temporary.
Generated HTML can be a risk when you don't verify it the next time you use it. (tested by adjusting variables -> it injects code into page). Maybe rebuilding from JSON data or add hash+check is an option.
I like the new behavior to search all databases on the server. The given label is technically correct, but from user point of view incorrect. It should be something like
'To search all databases on server, press Enter after a search term'.
Thanks, opened a bug ticket for the missing checks on sessionStorage: https://sourceforge.net/p/phpmyadmin/bugs/4725/
And surely the message you suggest makes more sense for the new fast filter behavior, I will modify the message.
Merged 1466!