Menu

#4496 bug in drag&drop import

Latest_Git
fixed
nobody
None
5
2014-07-25
2014-07-24
Minhaz
No

There is a bug in drag & drop import, feature I added:

  1. the drop handler is raised, even if we drag some HTML element in PMA
  2. if we drop the HTML element, the empty upload status box is raised (as no file is actually uploaded)

-- css fix which I think should be there: drag & drop a sql file which should cause the import to fail. -> click on failed, anchor to view the failure dialog.
Now this dialog can be dragged & moved anywhere in UI, however the cursor for the scrollbar in that dialog is also of move type, however it should be a pointer,

PS: dont mind the language :D

Discussion

  • Minhaz

    Minhaz - 2014-07-24

    https://github.com/phpmyadmin/phpmyadmin/pull/1300 fixes the 2nd part, however I can't find a way for part - 1
    NEED HELP

     
  • Marc Delisle

    Marc Delisle - 2014-07-25
    • Group: 3.3.7 --> Latest_Git
     
  • Marc Delisle

    Marc Delisle - 2014-07-25

    Hi Minhaz,
    not sure if you can detect the file extension before the drop handler, but in the drop handler, the file name is available under event.originalEvent.dataTransfer.files.

     
  • Minhaz

    Minhaz - 2014-07-25

    Chirayu fixed part 1, it has been merged into the same pull request!

     
  • Marc Delisle

    Marc Delisle - 2014-07-25

    So the pull request is ready to be merged?

     
  • Minhaz

    Minhaz - 2014-07-25

    wait, I'll do one more thing D-Storm suggested, 5minutes would do :)

     
  • Marc Delisle

    Marc Delisle - 2014-07-25
    • summary: bug in drag&drop import feature request 1522 --> bug in drag&drop import
    • status: open --> fixed
     
MongoDB Logo MongoDB