#4416 (ok 4.3.5) New lines are removed when grid editing

4.3.4
fixed
None
1
2015-01-05
2014-05-15
No

Go to any table where a field has new lines in it. In my case it's varchar(8000).
Double click the table cell on that field.

The new lines are removed from the field, and clicking away from the field updates it with the new value. For example if you have this:

Hello
World

Double clicking gives you a textarea with:

HelloWorld

Discussion

  • Hugues Peccatte

    Hugues Peccatte - 2014-05-24

    This is because of PMA_getCellValue:
    return $td.text();
    All HTML is removed.

    We have to find a way to replace <br / > by carriage return.

     
    Last edit: Hugues Peccatte 2014-05-24
  • Hugues Peccatte

    Hugues Peccatte - 2014-05-24

    And then, in method showEditCell:
    $(g.cEdit).find('.edit_box').val(value);

    It seems that this line is also removing carriage returns… It will be easy…

     
  • Marc Delisle

    Marc Delisle - 2014-05-25
    • summary: New lines are removed when editing --> New lines are removed when grid editing
     
  • Marc Delisle

    Marc Delisle - 2014-05-25
    • summary: New lines are removed when grid editing --> (ok 4.3) New lines are removed when grid editing
    • status: open --> resolved
    • assigned_to: Hugues Peccatte
    • Priority: 9 --> 1
     
  • DisgruntledGoat

    DisgruntledGoat - 2015-01-02

    This is still not fixed for me. If I double click a TEXT field, the line breaks are not there in the editable textarea. Currently using PMA 4.3.4.

     
    Last edit: DisgruntledGoat 2015-01-02
  • Marc Delisle

    Marc Delisle - 2015-01-02
    • summary: (ok 4.3) New lines are removed when grid editing --> New lines are removed when grid editing
    • status: fixed --> open
    • Group: 4.2.1 --> 4.3.4
    • Priority: 1 --> 5
     
  • Hugues Peccatte

    Hugues Peccatte - 2015-01-03
     
    • Marc Delisle

      Marc Delisle - 2015-01-04

      Hugues,
      with your pull request, it's true that new lines are no longer removed; note that to enter a new line while grid editing, one has to use shift/enter and I wonder how we could publicize it.

       
  • Marc Delisle

    Marc Delisle - 2015-01-04
    • summary: New lines are removed when grid editing --> (ok 4.3.5) New lines are removed when grid editing
    • status: open --> resolved
    • Priority: 5 --> 1
     
  • Marc Delisle

    Marc Delisle - 2015-01-05
    • Status: resolved --> fixed
     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks