#4287 (ok 4.1.8) Printview - Always one column too much

[dennis1993]

Hey guys,

I have found a bug. If I click in a table on "print" the printview has always one column too much. In Internet Explorer 11 the column is only in the headline and in Firefox complete.
I've attached two screenshots about it!

Thank you!

[Viduranga Wijesooriya]

Hi,
Can you please check this fix
https://github.com/phpmyadmin/phpmyadmin/pull/941

[dennis1993]

Hey,
thanks for your pull request!
Yes, it works but is the IF-clause right? I think is not correct. Your IF-clause is:

if(($colspan || $rowspan) != '')

Now you check if $colspan or $rowspan true. The last part != '' ha no effect, or not?
Mybe it is correct, but I know this code style.

I would make it so:

if($colspan || $rowspan)

OR SO

if(!empty($colspan) || !empty($rowspan))

I don't know whats better.

[Marc Delisle]

Fixed with https://github.com/phpmyadmin/phpmyadmin/commit/06bd132d46d0c6666a9ac93bc0d7cb8c8edf4438