Menu ▾ ▴

#4113 (ok 4.1) Error reporting uses PHP 5.4 features

Latest_Git
fixed
nobody
None
5
2013-12-12
2013-10-03
Michal Čihař
No

The error reporting uses json_encode flags which were introduced in 5.4.0. There needs to be some compatibility with older PHP versions as well.

Discussion

  • Michal Čihař

    Michal Čihař - 2013-10-17

    Workarounded in https://github.com/phpmyadmin/phpmyadmin/commit/21812d6 . Though I have no clue whether removing JSON_UNESCAPED_SLASHES won't cause any troubles...

     

    Last edit: Michal Čihař 2013-10-17

  • Mohamed Ashraf

    Mohamed Ashraf - 2013-10-18

    The json encode is a way to show the report to the user in a human readable format since print_r/var_dump is ugly. I am trying another method of displaying the report which we may use when we cant use the prettify json encode option.

     

  • Marc Delisle

    Marc Delisle - 2013-11-17

    Mohamed,
    any progress on your other method? I guess this is https://github.com/phpmyadmin/phpmyadmin/pull/735 and there are comments there to address.

     

  • Mohamed Ashraf

    Mohamed Ashraf - 2013-11-17

    I pushed some updates to the pull request, once they are merged they should be fixed I believe

     

  • Marc Delisle

    Marc Delisle - 2013-11-18

    Michal, please confirm.

     

  • Michal Čihař

    Michal Čihař - 2013-11-18
    • summary: Error reporting uses PHP 5.4 features --> (ok 4.1) Error reporting uses PHP 5.4 features
    • status: open --> resolved
     

  • Marc Delisle

    Marc Delisle - 2013-12-12
    • Status: resolved --> fixed