Menu

#3802 Datepicker displayed just the first time

Latest_Git
fixed
None
5
2013-06-11
2013-02-05
No

To reproduce:

  1. start phpMyAdmin
  2. visit sakila.payment
  3. click on Insert
  4. click on the calendar icon for payment_date: the picker opens
  5. click on Insert
  6. click on the calendar icon for payment_date: no picker
  7. browse the table
  8. click on Edit from one of the rows
  9. click on the calendar icon for payment_date: no picker

Discussion

  • Ayush Chaudhary

    Ayush Chaudhary - 2013-02-05

    On further inspection, if you Reload the page (refresh) instead of coming back to the page via AJAX navi, it works.

    While I am trying to locate the issue, any other suggestions are welcome.

    Looks like some component of javascript that is being triggered at page load, has to load at every AJAX call that places the date picker on the DOM.

     
  • Marc Delisle

    Marc Delisle - 2013-02-08

    Ayush,
    any progress?

     
  • Ayush Chaudhary

    Ayush Chaudhary - 2013-02-08

    Hi Marc,

    Yes, I have managed to fix it. Please let me know if there's any issue.

    Summary:

    datepicker remained initialized while its content was
    replaced by the ajax response. So after an ajax call, its div was no longer a part of the dom. tbl_change.js now reinitializes datepicker everytime its loaded.

    https://github.com/phpmyadmin/phpmyadmin/pull/155

    This is my first patch, so I may have made some mistakes, please let me know.

     
  • Marc Delisle

    Marc Delisle - 2013-02-08
    • assigned_to: Marc Delisle
     
  • Marc Delisle

    Marc Delisle - 2013-02-08

    Merged, thanks and congratulations for your first patch.

     
  • Marc Delisle

    Marc Delisle - 2013-02-08
    • status: open --> closed-fixed
     
  • Ayush Chaudhary

    Ayush Chaudhary - 2013-02-08

    Thanks, really glad on having submitted my first patch. Looking forward to contributing much more.

     
  • Michal Čihař

    Michal Čihař - 2013-06-11
    • Status: closed-fixed --> fixed
     
MongoDB Logo MongoDB