Menu

#2773 Sort Buttons don't work for large queries

3.0.0
fixed
5
2013-06-11
2008-10-01
No

PMA Version 3.0.0 also tried 2.11.92
PHP Version 5.2.4
MySQL 5.1.28

Problem:
In the query box use a large query (mine was greater than 1000 characters). The links for sorting columns are now buttons. When you click these buttons they do nothing.

Why it happens:
There's no form around the buttons.

My Solution:
In display.tbl.lib.php line 823 I changed a false parameter to true:
$order_link = PMA_linkOrButton($order_url, $order_link_content . $order_img, $order_link_params, false, true);

to

$order_link = PMA_linkOrButton($order_url, $order_link_content . $order_img, $order_link_params, true, true);

This causes the PMA_linkOrButton to generate a new form around the button.

Discussion

  • Marc Delisle

    Marc Delisle - 2008-10-01

    Cannot reproduce your problem. Tried in 3.0.0. It's true I did not try a large query but to simulate this, in libraries/common.lib.php in the PMA_linkOrButton() I replaced
    if (strlen($url) <= 1000) {
    by
    if (strlen($url) <= 10) {

    so I get buttons that work because they are inside a bigger form. Could you attach here a zipped file containing the HTML source of the generated page (from phpMyAdmin 3.0.0) where the buttons do not work? or mail the zip file to me?

     
  • Marc Delisle

    Marc Delisle - 2008-10-01
    • assigned_to: nobody --> lem9
    • status: open --> pending
     
  • SourceForge Robot

    This Tracker item was closed automatically by the system. It was
    previously set to a Pending status, and the original submitter
    did not respond within 14 days (the time period specified by
    the administrator of this Tracker).

     
  • SourceForge Robot

    • status: pending --> closed
     
  • Michal Čihař

    Michal Čihař - 2013-06-11
    • Status: closed --> fixed
     
MongoDB Logo MongoDB