[4.1.4] Place Hierarchy - googlemap view
Brought to you by:
canajun2eh,
yalnifj
Menu
▾
▴
Logged In: YES
user_id=1910459
Originator: NO
wooc
Looks great to me. All my 'bugs' are fixed. Thanks.
I would still like to see flags displayed where they are available instead of the default icon. The code for that is in googlemap.php I think. But that is a 'wish list' item, not a bug.
One other thing. I think for now the GM version of place list appears if the GM module exists. It might be good to also have a config option for those who want the GM module, but still prefer the old-style place list.
Great job. Well done.
Logged In: YES
user_id=634811
Originator: NO
Looking very good and I am almost ready to check the files into SVN. I found 2 sets of php errors. When going to placelist.php?display=list (go to placelist.php and click on "Show All Places in a List" to get to that URL) shows the following errors:
ERROR 8: Undefined variable: numfound
0 Error occurred on line 477 of file placelist.php
ERROR 8: Undefined variable: levelo
0 Error occurred on line 477 of file placelist.php
ERROR 8: Undefined variable: placelevels
0 Error occurred on line 477 of file placelist.php
Also, going to:
placelist.php?action=find&level=2&parent[0]=Poland&parent[1]=Dolnoslaskie and switching to Polish and then back to English (with the final URL being placelist.php?action=find&level=2&parent%255B0%255D=Poland&parent%255B1%255D=Dolnoslaskie&changelanguage=yes&NEWLANGUAGE=english ) generates many instances of:
ERROR 8: Undefined offset: 0
0 Error occurred on line 66 of file placehierarchy.php in function set_levelm
1 called from line 76 of file placelist.php
Logged In: YES
user_id=634811
Originator: NO
Another point, my data is 4 levels, and for some Unknowns I did not define the lat/long so for Harbin, , , China, I have china and Harbin set up, but not the 2 middle unknown places. China shows a marker when at placelist.php with all the rest of the countries, but clicking on in the China link placelist.php?action=find&level=1&parent[0]=China and onto unknown leading to placelist.php?action=find&level=2&parent[0]=China&parent[1]= both show the ocean around Howard Island (nere 0,0 I guess) , clicking on the next unknown placelist.php?action=find&level=3&parent[0]=China&parent[1]=&parent[2]= leads to a map identical to placelist.php (all markers in the world show), and clicking on the final placelist.php?action=find&level=4&parent[0]=China&parent[1]=&parent[2]=&parent[3]=Harbin link again shows a map in middle of the ocean near Howard island. While I understand null (0,0) should show the middle of nowhere, Harbin that is defined should show properly, and indeed does show properly in the indi page. In addition, if the parent place is known, I would show show the parent location, for all unknown places under China I would show the China location unless the sub-location had a defined lat/long.
Logged In: YES
user_id=634811
Originator: NO
Sorry for all the individual posts, but I am enjoying the feature, and post as I run into issues. When I click down to the last level such as "Grajewo, Grajewski, Podlaskie, Poland", the InfoWindow shows ", Grajewo, Grajewski, Podlaskie, Poland" note the leading ", " as if there was to be an additional lower level palce, even though the GEDCOM is set up for only 4 places. Clicking on Grajewo when I am at the powiat level (Grajewski), show the proper "Grajewo, Grajewski, Podlaskie, Poland"
Logged In: YES
user_id=1946672
Originator: YES
<<Also, going to:
placelist.php?action=find&level=2&parent[0]=Poland&parent[1]=Dolnoslaskie
and switching to Polish and then back to English (with the final URL being
placelist.php?action=find&level=2&parent%255B0%255D=Poland&parent%255B1%255D=Dolnoslaskie&changelanguage=yes&NEWLANGUAGE=english
) generates many instances of:
ERROR 8: Undefined offset: 0
0 Error occurred on line 66 of file placehierarchy.php in function
set_levelm
1 called from line 76 of file placelist.php>>
I think it's a bug in other file. In URL is changed "[" to "%255B" and "]" to "%255D". I checked this in original placelist file and this URL shows level 0 of hierarchy.
Logged In: YES
user_id=634811
Originator: NO
Thanks. I filed a bug [ 1944250 ] placelist.php Level Issue On Language Change https://sourceforge.net/tracker/index.php?func=detail&aid=1944250&group_id=55456&atid=634867
Logged In: YES
user_id=634811
Originator: NO
A suggestion would be to better use the info window that currently only shows the lat/long. SQL to show the # of people per country can be shown (in addition to any other place related stats) be grabbed (probably with modification) from the patch [ 1930232 ] Welcome block: google_charts.php https://sourceforge.net/tracker/index.php?func=detail&aid=1930232&group_id=55456&atid=477081 . A minor issue is that the format of the lat/long do not match the format used in the indi page.
placelist.php ver0.7
Logged In: YES
user_id=1946672
Originator: YES
I fixed the bug with unknown places and made some improvement and config options.
I discovered other bug while changing language.
If I have URL e.g 1.placelist.php?action=find&level=3&parent[0]=China&parent[1]=&parent[2]=
or 2.placelist.php?action=find&level=4&parent[0]=China&parent[1]=&parent[2]=&parent[3]=Harbin
and change language the final URL looks:
1.placelist.php?action=find&level=3&parent[0]=China&changelanguage=yes&NEWLANGUAGE=english
2.placelist.php?action=find&level=3&parent[0]=China&parent[3]=Harbin&changelanguage=yes&NEWLANGUAGE=english
The unknown levels are missed in final URL.
File Added: placelist0.7c.zip
placelist.php ver0.8
Logged In: YES
user_id=1946672
Originator: YES
The previous version generates too many database queries. This provides to locking the system if googlemap table contains many placelocations.
The last version solve this problem.
File Added: placelist0.8.zip
Logged In: YES
user_id=634811
Originator: NO
wooc,
This looks very good. Almost all suggestions below were incorporated, and I believe that all known bugs are fixed. What is your development schedule like? Would you like this added to SVN at this point? Or would you plan on some more patches in the next few days?
Logged In: YES
user_id=634811
Originator: NO
I have a place defined as Iasi, , Iasi, România. Going to placelist.php?level=1&parent[0]=Rom%C3%A2nia shows 3 provinces, * Hunedoara, * Iasi and * Maramures. Iasi does not appear on the map. Drilling down to placelist.php?action=find&level=2&parent[0]=Rom%C3%A2nia&parent[1]=Iasi shows Hunedoara, Iasi, Romania (incorrect) and Maramures, Iasi, Romania (also incorrect). Both of these places belong to the other provinces. This again seems to be a variant of the Unknown bug. The individual.php map does not shwo this error. Drilling down to the final Iasi, unknown, Iasi, România shows a map in middle of the ocean.
Logged In: YES
user_id=634811
Originator: NO
Wooc,
Please note that there was a recent change to placelist.php in SVN. See http://phpgedview.svn.sourceforge.net/viewvc/phpgedview/trunk/phpGedView/placelist.php?r1=2091&r2=2880&sortby=date .
It would be a good idea to merge this (and future changes) to your patch untill we add this to SVN.
Thanks
Logged In: YES
user_id=1946672
Originator: YES
Thanks KJ, I merged it.
But still, I have no idea haw to solve your problem with Romania. I used function from googlemap.php file.
And your bug is strange for me. Maybe the patch has problem with paramters of this function.
I try to display # per place, but it very difficult to me to grab code from google_charts.php.
Logged In: YES
user_id=634811
Originator: NO
There was an additional change to placelist.php in SVN. My merged version seems to work just fine. I would like to check your changes into SVN today or tomorrow so that they might make it to the upcoming 4.1.5 release. We can always work on the bugs after it is in SVN.
Logged In: YES
user_id=634811
Originator: NO
The patch has been checked in to SVN trunk. We will apply any future changes to SVN.
Thanks again for the patch.
Logged In: YES
user_id=634811
Originator: NO
Now that this is in SVN and in the latest 4.1.5 release this can probably be closed. I will keep it open for a few days though. One nice config that could be added would be to allow setting if the map zoom control should be large or small. In the indi page it currently uses the large one, and in the placelist it uses the small one (without the slider).
Thanks again for a very nice implementation.
Logged In: YES
user_id=634811
Originator: NO
The Romania issue was cause by improper data in my tables. Sorry for the confusion.