#2829 Research Assistant Sub-Menu Error

v4.2.3
closed-fixed
None
5
2010-11-11
2010-09-14
radioace
No

21 * @package PhpGedView
22 * @subpackage Modules, Research Assistant
23 * @version $Id: menu.php 6316 2009-11-06 23:08:17Z fisharebest $

Lines 63, 73, 83 contain the following code:

if(!empty($PGV_IMAGES['ra_folder']['small'])){$menu->addIcon("{$PGV_IMAGE_DIR}/{$PGV_IMAGES['ra_folders']['small']}");}

The segment:
.....{$menu->addIcon("{$P......

Should be changed to:
....{.$submenu->addIcon("{$P.....

Discussion

  • Stephen Arnold

    Stephen Arnold - 2010-09-15

    Please advise how we can reproduce this 'bug' so we can examine it prior to changing any code.

     
  • radioace

    radioace - 2010-09-15

    The attached zip file has text file with an explanation and letter ICONs for testing purposes.

     
  • radioace

    radioace - 2010-09-15

    This is a corrected truth table:

    Small Large Directory Used
    Y Y themes/your_theme/images
    N Y themes/your_theme/images
    N N modules/research_assistant/images
    Y N modules/research_assistant/images

    NOTE: In the above truth table 'Y' means the ICON is available, 'N' means the ICON is not available.
    Small = themes/your_theme/images/small
    Large = themes/your_theme/images

     
  • Stephen Arnold

    Stephen Arnold - 2010-09-16

    Ace
    I appreciate your posting and your attachments, and respect your coding skills, but I'm lost on how to produce the 'bug' you say exists within the existing code. You may very well be correct, but I don't want to change anything -> just want to reproduce the bug and know when I'm looking at it. sorry if I didn't make my request clear enough the first time.

    After i can reproduce the bug in the code as written, I'll be happy to experiment with the changes you propose.

    If you can't supply the course of action you take to have the bug present, I'll have to let someone else handle the changes you offer.
    Thanks, [b][i][color=green]-Stephen[/color][/i][/b]

     
  • radioace

    radioace - 2010-09-16

    Sorry if my explanation was inadequate.

    This problem is minor, but does limit the flexibility of the module. This problem is only observable if one tries to use sub-menu ICONs provided by the theme (i.e. cloudy). I don't know of any Themes which supply ICONs for the research_assistant module. The errors do prevent a theme designer or user from using custom ICONs in other than the module's images directory.

    I have re-written the description and corrective measure and knowing that a picture is worth a thousand words, I will upload a zip zile containing the description and two pictures which show the condition.

     
  • radioace

    radioace - 2010-09-16
     
  • Gerry Kroll

    Gerry Kroll - 2010-11-11

    Fixed in SVN 6990

     
  • Gerry Kroll

    Gerry Kroll - 2010-11-11
    • milestone: --> v4.2.3
    • assigned_to: nobody --> canajun2eh
    • status: open --> closed-fixed
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks