#2802 Valid HTML for javascript (function_print.php)

v4.2.3
open
nobody
None
5
2010-04-11
2010-04-11
matthys
No

I removed the "space" behind href="javascript:// (line 1313 & 1324 in functions_print.php) to make valid HTML. Seems a typo or what.

./includes/functions/functions_print.php: $output.=$pgv_lang["help_header"].' '.$pgv_lang[$show_desc].'" href="javascript:// ';
./includes/functions/functions_print.php: $output.=$pgv_lang["help_header"].'" href="javascript:// ';

BTW .. there is a lot of stuff not valid HTML :-(

Discussion

  • Gerry Kroll

    Gerry Kroll - 2010-04-11

    What version of PGV are you talking about?

    I sent one of the pages with those Help links in it to the W3C validator, and it came back as being valid HTML.

    What page isn't valid HTML? What browser is complaining about invalid HTML?

     
  • matthys

    matthys - 2010-04-12

    Sorry ... use PGV 4.2.3 (see Group).

    Myself use HTML Tidy plugin for Firefox. But you are right that the PGV is valid W3C code. Bit strange as Tidy doesn't agree...

    For example the use of Width="50px" where Tidy says px is not valid:
    HTML width and height attributes do not need "px"; their units are always assumed to be pixels.
    And reverse to W3C -> http://www.w3.org/TR/html4/types.html#h-6.2

    All code uses "href="javascript://<name>" but for these it was "href="javascript://(space)<name>" so I guessed the (space) was a typo of some kind...

    I am also not using the default theme (use xenea), maybe this also makes things worse?
    At least I just did a W3C check on the CSS and not valid ... ;-(

     
  • Gerry Kroll

    Gerry Kroll - 2010-04-12

    The "px" unit specification is in there because CSS requires it.

    To avoid confusion about what's implied and what's not, we always use "px" or whatever.

     
  • Gerry Kroll

    Gerry Kroll - 2010-04-12

    I mention CSS only because the "px" unit designation is required there. We're striving for consistency by specifying the "px" unit in plain HTML too.

    We're using the W3C validator as our "authority", since the HTML and CSS languages are maintained by the W3C consortium. We can't possibly maintain the program in such a way that its output will validate against everybody out there.

    When the W3C consortium, by means of updates to their validator, declares that the "px" unit designation shall not be used in HTML, we'll fix PGV.

    We'll also fix PGV when someone points out that a browser doesn't produce correct screens from what PGV is sending it. For this to happen, the browser will have to be a public release -- pre-release, beta, and alpha versions of that browser won't be considered.

    You ask about the Xenea theme: This is one of the themes that is distributed with PGV. That means the PGV team maintains it.

     

Log in to post a comment.