phpesp-devel — Discussion of the development of phpESP

[phpesp-dev] Re: Patch for Auto-publishing

[James E. F. <jf...@ac...>]

On Tue, 16 Apr 2002, flobee wrote:

> where is that: Patch for Auto-publishing ??
>
> very intresting! i build up my own script for that but i have secure holes
> because i needed to disable some things in handler prefix!

You need to use the cvs version of phpESP. There are
instructions on sf.net on obtaining code from the cvs
server here:
  http://sourceforge.net/cvs/?group_id=8956

for example you would say:
 $ cvs -d:pserver:ano...@cv...:/cvsroot/phpesp login
<hit enter at password prompt>
 $ cvs -d:pserver:ano...@cv...:/cvsroot/phpesp co phpesp

Look online for help on using CVS or look back in the
archives for the phpesp-general list for more help.

-James

[phpesp-dev] Re: phpESP-devel digest, Vol 1 #25 - 8 msgs

[flobee <fl...@we...>]

where is that: Patch for Auto-publishing ??

very intresting! i build up my own script for that but i have secure holes
because i needed to disable some things in handler prefix!


----- Original Message -----
From: <php...@li...>
To: <php...@li...>
Sent: Tuesday, April 16, 2002 9:53 PM
Subject: phpESP-devel digest, Vol 1 #25 - 8 msgs


Send phpESP-devel mailing list submissions to
php...@li...

To subscribe or unsubscribe via the World Wide Web, visit
https://lists.sourceforge.net/lists/listinfo/phpesp-devel
or, via email, send a message with subject or body 'help' to
php...@li...

You can reach the person managing the list at
php...@li...

When replying, please edit your Subject line so it is more specific
than "Re: Contents of phpESP-devel digest..."


Today's Topics:

   1. Re: Patch for Auto-publishing (Kon Angelopoulos)
   2. Re: Patch for Auto-publishing (James E. Flemer)
   3. french translaton (James E. Flemer)
   4. Re: Patch for Auto-publishing (Matthew Gregg)
   5. Re: Patch for Auto-publishing (James E. Flemer)
   6. Re: Patch for Auto-publishing (Matthew Gregg)
   7. Re: Patch for Auto-publishing (Matthew Gregg)
   8. Re: Patch for Auto-publishing (James E. Flemer)

--__--__--

Message: 1
From: Kon Angelopoulos <ang...@ip...>
To: "James E. Flemer" <jf...@ac...>,
 Matthew Gregg <gr...@mu...>
Subject: Re: [phpesp-dev] Patch for Auto-publishing
Date: Tue, 16 Apr 2002 19:49:23 +1000
Cc: <php...@li...>
Organization: angek Productions

Hi Guys,

Just downloaded the latest version to have a look at Matthews patch and was
looking at the code for handler.php


     75         $action = $HTTP_SERVER_VARS['PHP_SELF'];
     76         if (!empty($HTTP_SERVER_VARS['QUERY_STRING']))
     77                 $action .= "?" . $HTTP_SERVER_VARS['QUERY_STRING'];

should line 77 read $action = "?" .$HTTP_SERVER_VARS['QUERY_STRING'];
instead?

otherwise couldn't we  have the following scenario when, for example we test
surveys?

..../.../manage.php?where=test&sid=xx - then clicking the submit button
would
generate:
../../manage.php?where=test?where=test&sid=xx


Regards


Kon



On Mon, 15 Apr 2002 05:05, James E. Flemer wrote:
> On Wed, 10 Apr 2002, Matthew Gregg wrote:
> > Attached is first run at a patch to allow publishing of surveys
> > without needing to manually create a php "include" file.
>
> I made a few slight changes, nothing effecting use, and
> committed this patch. Thanks.
>
> > Take a look in handler-prefix.php where the remote user id is found.
> > I commented the QUERY_STRING case because it would grab the
> > query string for survey selection every time.   Can we live without
> > that case?
>
> I changed this so that survey.php removes "name=xxx" from
> the query string, so no mods to handler-prefix were needed.
>
> Thanks for the patch.
>
> -James
>
>
> _______________________________________________
> phpESP-devel mailing list
> php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpesp-devel


--__--__--

Message: 2
Date: Tue, 16 Apr 2002 10:40:17 -0400 (EDT)
From: "James E. Flemer" <jf...@ac...>
Reply-To: "James E. Flemer" <jf...@ac...>
To: <php...@li...>
Subject: Re: [phpesp-dev] Patch for Auto-publishing

Well, I see the problem, but I fixed it in where/test.inc
instead. Now that the handler sanely treats the
QUERY_STRING, I removed the QS mangling code in test.inc,
that made it possible to embed the handler within the
mangagemnt interface. Please checkout the latest revision
of that file and see if your problems go away.

-James

On Tue, 16 Apr 2002, Kon Angelopoulos wrote:

> Hi Guys,
>
> Just downloaded the latest version to have a look at Matthews patch and
was
> looking at the code for handler.php
>
>
>      75         $action = $HTTP_SERVER_VARS['PHP_SELF'];
>      76         if (!empty($HTTP_SERVER_VARS['QUERY_STRING']))
>      77                 $action .= "?" .
$HTTP_SERVER_VARS['QUERY_STRING'];
>
> should line 77 read $action = "?" .$HTTP_SERVER_VARS['QUERY_STRING'];
instead?
>
> otherwise couldn't we  have the following scenario when, for example we
test
> surveys?
>
> ..../.../manage.php?where=test&sid=xx - then clicking the submit button
would
> generate:
> ../../manage.php?where=test?where=test&sid=xx
>
>
> Regards
>
>
> Kon



--__--__--

Message: 3
Date: Tue, 16 Apr 2002 11:00:32 -0400 (EDT)
From: "James E. Flemer" <jf...@ac...>
Reply-To: "James E. Flemer" <jf...@ac...>
To: <php...@li...>
Subject: [phpesp-dev] french translaton

Hey French Translation Team ...
  Did you send me the translated messages.po file? If you
have, I've lost it in my mountain of email. I do have the
translated images though, and will probably get around to
adding code for choosing the right ones pretty soon. (I
have final exams coming up so my time might be limited.)
-James



--__--__--

Message: 4
Date: Tue, 16 Apr 2002 11:07:17 -0400
From: Matthew Gregg <gr...@mu...>
To: "James E. Flemer" <jf...@ac...>
Cc: php...@li...
Subject: Re: [phpesp-dev] Patch for Auto-publishing

The change to remove "name=xxx" from the query string brings up a
small problem.

The first time through a survey the referer is set correctly so that
the "return" link on the "thank you" page works correctly, however, if
you click that link to take the survey again, the "name=xxx" will be
dropped from the referer.  So a second time through the survey the
"return" link fails.


On Sun, Apr 14, 2002 at 03:05:39PM -0400, James E. Flemer wrote:
> On Wed, 10 Apr 2002, Matthew Gregg wrote:
>
> > Attached is first run at a patch to allow publishing of surveys
> > without needing to manually create a php "include" file.
>
> I made a few slight changes, nothing effecting use, and
> committed this patch. Thanks.
>
> > Take a look in handler-prefix.php where the remote user id is found.
> > I commented the QUERY_STRING case because it would grab the
> > query string for survey selection every time.   Can we live without
> > that case?
>
> I changed this so that survey.php removes "name=xxx" from
> the query string, so no mods to handler-prefix were needed.
>
> Thanks for the patch.
>
> -James
>

--
brought to you by, Matthew Gregg...
one of the friendly folks in the IT Lab.
--------------------------------------\
The IT Lab (http://www.itlab.musc.edu) \____________________
Probably the world's premier software development center.
Serving: Programming, Tools, Ice Cream, Seminars



--__--__--

Message: 5
Date: Tue, 16 Apr 2002 11:31:35 -0400 (EDT)
From: "James E. Flemer" <jf...@ac...>
Reply-To: "James E. Flemer" <jf...@ac...>
To: Matthew Gregg <gr...@mu...>
Cc: <php...@li...>
Subject: Re: [phpesp-dev] Patch for Auto-publishing

Well ... Ideally the "return" link is supposed to be to the
page _before_ the survey.

So you've got some index.html somewhere with
  [a href="/survey.php?name=foo"] Take a Survey [/a]
Then the "return" link should take you back to
"index.html".

However if you type http://place.ext/survey.php?name=foo
into the url bar, then there is no referrer, so it sorta
goes back to itself.

What do you all think the policy should be?

Vote:
   http://phpesp.sf.net/demo/test.php?sid=2944&userid=devel
Results:
   http://phpesp.sf.net/demo/test.php?sid=2944&results=1

-James


On Tue, 16 Apr 2002, Matthew Gregg wrote:

> The change to remove "name=xxx" from the query string brings up a
> small problem.
>
> The first time through a survey the referer is set correctly so that
> the "return" link on the "thank you" page works correctly, however, if
> you click that link to take the survey again, the "name=xxx" will be
> dropped from the referer.  So a second time through the survey the
> "return" link fails.



--__--__--

Message: 6
Date: Tue, 16 Apr 2002 11:46:14 -0400
From: Matthew Gregg <gr...@mu...>
To: "James E. Flemer" <jf...@ac...>
Cc: php...@li...
Subject: Re: [phpesp-dev] Patch for Auto-publishing

On Tue, Apr 16, 2002 at 11:31:35AM -0400, James E. Flemer wrote:
> Well ... Ideally the "return" link is supposed to be to the
> page _before_ the survey.
Oh duh, yeah that would make sense.

>
> So you've got some index.html somewhere with
>   [a href="/survey.php?name=foo"] Take a Survey [/a]
> Then the "return" link should take you back to
> "index.html".
>
> However if you type http://place.ext/survey.php?name=foo
> into the url bar, then there is no referrer, so it sorta
> goes back to itself.
>
> What do you all think the policy should be?
>
> Vote:
>    http://phpesp.sf.net/demo/test.php?sid=2944&userid=devel

Vote cast.
> Results:
>    http://phpesp.sf.net/demo/test.php?sid=2944&results=1
>
> -James
>
>
> On Tue, 16 Apr 2002, Matthew Gregg wrote:
>
> > The change to remove "name=xxx" from the query string brings up a
> > small problem.
> >
> > The first time through a survey the referer is set correctly so that
> > the "return" link on the "thank you" page works correctly, however, if
> > you click that link to take the survey again, the "name=xxx" will be
> > dropped from the referer.  So a second time through the survey the
> > "return" link fails.
>

--
brought to you by, Matthew Gregg...
one of the friendly folks in the IT Lab.
--------------------------------------\
The IT Lab (http://www.itlab.musc.edu) \____________________
Probably the world's premier software development center.
Serving: Programming, Tools, Ice Cream, Seminars



--__--__--

Message: 7
Date: Tue, 16 Apr 2002 12:01:55 -0400
From: Matthew Gregg <gr...@mu...>
To: "James E. Flemer" <jf...@ac...>
Cc: php...@li...
Subject: Re: [phpesp-dev] Patch for Auto-publishing

One other thing.
survey.php doesn't take into account private surveys.
I think it's a small change to do this, but larger than I felt safe
committing
to CVS myself :-)

-     $sql = "SELECT id,title FROM survey WHERE name = '$_name'";
+     $sql = "SELECT id, title, public FROM survey WHERE name = '$_name'";
     if ($result = mysql_query($sql)) {
                if (mysql_num_rows($result) > 0)
-                list($sid, $_title) = mysql_fetch_row($result);
+   list($sid, $_title, $public) = mysql_fetch_row($result);
                mysql_free_result($result);
                }
        }
+        if ($public == "N") {
+                include($ESPCONFIG['handler_prefix']);
+        }
?>



On Sun, Apr 14, 2002 at 03:05:39PM -0400, James E. Flemer wrote:
> On Wed, 10 Apr 2002, Matthew Gregg wrote:
>
> > Attached is first run at a patch to allow publishing of surveys
> > without needing to manually create a php "include" file.
>
> I made a few slight changes, nothing effecting use, and
> committed this patch. Thanks.
>
> > Take a look in handler-prefix.php where the remote user id is found.
> > I commented the QUERY_STRING case because it would grab the
> > query string for survey selection every time.   Can we live without
> > that case?
>
> I changed this so that survey.php removes "name=xxx" from
> the query string, so no mods to handler-prefix were needed.
>
> Thanks for the patch.
>
> -James
>

--
brought to you by, Matthew Gregg...
one of the friendly folks in the IT Lab.
--------------------------------------\
The IT Lab (http://www.itlab.musc.edu) \____________________
Probably the world's premier software development center.
Serving: Programming, Tools, Ice Cream, Seminars



--__--__--

Message: 8
Date: Tue, 16 Apr 2002 12:55:44 -0400 (EDT)
From: "James E. Flemer" <jf...@ac...>
Reply-To: "James E. Flemer" <jf...@ac...>
To: Matthew Gregg <gr...@mu...>
Cc: <php...@li...>
Subject: Re: [phpesp-dev] Patch for Auto-publishing

Thanks for pointing that out.
I just committed smaller patch doing the same thing. :-)
There is no need to check public, since the handler prefix
is included by the handler (if it hasn't already) anyway,
so now we just include it explicitly above any content.

     if ($result = mysql_query($sql)) {
                if (mysql_num_rows($result) > 0)
                list($sid, $_title) = mysql_fetch_row($result);
                mysql_free_result($result);
                }
        }
+        include($ESPCONFIG['handler_prefix']);
 ?>

Checkout new revision from cvs.

-James

On Tue, 16 Apr 2002, Matthew Gregg wrote:

> One other thing.
> survey.php doesn't take into account private surveys.
> I think it's a small change to do this, but larger than I felt safe
committing
> to CVS myself :-)
>
> -     $sql = "SELECT id,title FROM survey WHERE name = '$_name'";
> +     $sql = "SELECT id, title, public FROM survey WHERE name = '$_name'";
>      if ($result = mysql_query($sql)) {
>                 if (mysql_num_rows($result) > 0)
> -                list($sid, $_title) = mysql_fetch_row($result);
> +   list($sid, $_title, $public) = mysql_fetch_row($result);
>                 mysql_free_result($result);
>                 }
>         }
> +        if ($public == "N") {
> +                include($ESPCONFIG['handler_prefix']);
> +        }
> ?>




--__--__--

_______________________________________________
phpESP-devel mailing list
php...@li...
https://lists.sourceforge.net/lists/listinfo/phpesp-devel


End of phpESP-devel Digest

Re: [phpesp-dev] Patch for Auto-publishing

[James E. F. <jf...@ac...>]

Thanks for pointing that out.
I just committed smaller patch doing the same thing. :-)
There is no need to check public, since the handler prefix
is included by the handler (if it hasn't already) anyway,
so now we just include it explicitly above any content.

     if ($result = mysql_query($sql)) {
                if (mysql_num_rows($result) > 0)
                list($sid, $_title) = mysql_fetch_row($result);
                mysql_free_result($result);
                }
        }
+        include($ESPCONFIG['handler_prefix']);
 ?>

Checkout new revision from cvs.

-James

On Tue, 16 Apr 2002, Matthew Gregg wrote:

> One other thing.
> survey.php doesn't take into account private surveys.
> I think it's a small change to do this, but larger than I felt safe committing
> to CVS myself :-)
>
> -     $sql = "SELECT id,title FROM survey WHERE name = '$_name'";
> +     $sql = "SELECT id, title, public FROM survey WHERE name = '$_name'";
>      if ($result = mysql_query($sql)) {
>                 if (mysql_num_rows($result) > 0)
> -                list($sid, $_title) = mysql_fetch_row($result);
> +	  	 list($sid, $_title, $public) = mysql_fetch_row($result);
>                 mysql_free_result($result);
>                 }
>         }
> +        if ($public == "N") {
> +                include($ESPCONFIG['handler_prefix']);
> +        }
> ?>

Re: [phpesp-dev] Patch for Auto-publishing

[Matthew G. <gr...@mu...>]

One other thing.
survey.php doesn't take into account private surveys.
I think it's a small change to do this, but larger than I felt safe committing
to CVS myself :-)

-     $sql = "SELECT id,title FROM survey WHERE name = '$_name'";
+     $sql = "SELECT id, title, public FROM survey WHERE name = '$_name'";
     if ($result = mysql_query($sql)) {
                if (mysql_num_rows($result) > 0)
-                list($sid, $_title) = mysql_fetch_row($result);
+	  	 list($sid, $_title, $public) = mysql_fetch_row($result);
                mysql_free_result($result);
                }
        }
+        if ($public == "N") {
+                include($ESPCONFIG['handler_prefix']);
+        }
?>



On Sun, Apr 14, 2002 at 03:05:39PM -0400, James E. Flemer wrote:
> On Wed, 10 Apr 2002, Matthew Gregg wrote:
> 
> > Attached is first run at a patch to allow publishing of surveys
> > without needing to manually create a php "include" file.
> 
> I made a few slight changes, nothing effecting use, and
> committed this patch. Thanks.
> 
> > Take a look in handler-prefix.php where the remote user id is found.
> > I commented the QUERY_STRING case because it would grab the
> > query string for survey selection every time.   Can we live without
> > that case?
> 
> I changed this so that survey.php removes "name=xxx" from
> the query string, so no mods to handler-prefix were needed.
> 
> Thanks for the patch.
> 
> -James
> 

-- 
brought to you by, Matthew Gregg...
one of the friendly folks in the IT Lab.
--------------------------------------\
The IT Lab (http://www.itlab.musc.edu) \____________________
Probably the world's premier software development center.
Serving: Programming, Tools, Ice Cream, Seminars

Re: [phpesp-dev] Patch for Auto-publishing

[Matthew G. <gr...@mu...>]

On Tue, Apr 16, 2002 at 11:31:35AM -0400, James E. Flemer wrote:
> Well ... Ideally the "return" link is supposed to be to the
> page _before_ the survey.
Oh duh, yeah that would make sense.

> 
> So you've got some index.html somewhere with
>   [a href="/survey.php?name=foo"] Take a Survey [/a]
> Then the "return" link should take you back to
> "index.html".
> 
> However if you type http://place.ext/survey.php?name=foo
> into the url bar, then there is no referrer, so it sorta
> goes back to itself.
> 
> What do you all think the policy should be?
> 
> Vote:
>    http://phpesp.sf.net/demo/test.php?sid=2944&userid=devel

Vote cast.
> Results:
>    http://phpesp.sf.net/demo/test.php?sid=2944&results=1
> 
> -James
> 
> 
> On Tue, 16 Apr 2002, Matthew Gregg wrote:
> 
> > The change to remove "name=xxx" from the query string brings up a
> > small problem.
> >
> > The first time through a survey the referer is set correctly so that
> > the "return" link on the "thank you" page works correctly, however, if
> > you click that link to take the survey again, the "name=xxx" will be
> > dropped from the referer.  So a second time through the survey the
> > "return" link fails.
> 

-- 
brought to you by, Matthew Gregg...
one of the friendly folks in the IT Lab.
--------------------------------------\
The IT Lab (http://www.itlab.musc.edu) \____________________
Probably the world's premier software development center.
Serving: Programming, Tools, Ice Cream, Seminars

Re: [phpesp-dev] Patch for Auto-publishing

[James E. F. <jf...@ac...>]

Well ... Ideally the "return" link is supposed to be to the
page _before_ the survey.

So you've got some index.html somewhere with
  [a href="/survey.php?name=foo"] Take a Survey [/a]
Then the "return" link should take you back to
"index.html".

However if you type http://place.ext/survey.php?name=foo
into the url bar, then there is no referrer, so it sorta
goes back to itself.

What do you all think the policy should be?

Vote:
   http://phpesp.sf.net/demo/test.php?sid=2944&userid=devel
Results:
   http://phpesp.sf.net/demo/test.php?sid=2944&results=1

-James


On Tue, 16 Apr 2002, Matthew Gregg wrote:

> The change to remove "name=xxx" from the query string brings up a
> small problem.
>
> The first time through a survey the referer is set correctly so that
> the "return" link on the "thank you" page works correctly, however, if
> you click that link to take the survey again, the "name=xxx" will be
> dropped from the referer.  So a second time through the survey the
> "return" link fails.

Re: [phpesp-dev] Patch for Auto-publishing

[Matthew G. <gr...@mu...>]

The change to remove "name=xxx" from the query string brings up a
small problem.  

The first time through a survey the referer is set correctly so that
the "return" link on the "thank you" page works correctly, however, if
you click that link to take the survey again, the "name=xxx" will be
dropped from the referer.  So a second time through the survey the
"return" link fails.


On Sun, Apr 14, 2002 at 03:05:39PM -0400, James E. Flemer wrote:
> On Wed, 10 Apr 2002, Matthew Gregg wrote:
> 
> > Attached is first run at a patch to allow publishing of surveys
> > without needing to manually create a php "include" file.
> 
> I made a few slight changes, nothing effecting use, and
> committed this patch. Thanks.
> 
> > Take a look in handler-prefix.php where the remote user id is found.
> > I commented the QUERY_STRING case because it would grab the
> > query string for survey selection every time.   Can we live without
> > that case?
> 
> I changed this so that survey.php removes "name=xxx" from
> the query string, so no mods to handler-prefix were needed.
> 
> Thanks for the patch.
> 
> -James
> 

-- 
brought to you by, Matthew Gregg...
one of the friendly folks in the IT Lab.
--------------------------------------\
The IT Lab (http://www.itlab.musc.edu) \____________________
Probably the world's premier software development center.
Serving: Programming, Tools, Ice Cream, Seminars

[phpesp-dev] french translaton

[James E. F. <jf...@ac...>]

Hey French Translation Team ...
  Did you send me the translated messages.po file? If you
have, I've lost it in my mountain of email. I do have the
translated images though, and will probably get around to
adding code for choosing the right ones pretty soon. (I
have final exams coming up so my time might be limited.)
-James

Re: [phpesp-dev] Patch for Auto-publishing

[James E. F. <jf...@ac...>]

Well, I see the problem, but I fixed it in where/test.inc
instead. Now that the handler sanely treats the
QUERY_STRING, I removed the QS mangling code in test.inc,
that made it possible to embed the handler within the
mangagemnt interface. Please checkout the latest revision
of that file and see if your problems go away.

-James

On Tue, 16 Apr 2002, Kon Angelopoulos wrote:

> Hi Guys,
>
> Just downloaded the latest version to have a look at Matthews patch and was
> looking at the code for handler.php
>
>
>      75         $action = $HTTP_SERVER_VARS['PHP_SELF'];
>      76         if (!empty($HTTP_SERVER_VARS['QUERY_STRING']))
>      77                 $action .= "?" . $HTTP_SERVER_VARS['QUERY_STRING'];
>
> should line 77 read $action = "?" .$HTTP_SERVER_VARS['QUERY_STRING']; instead?
>
> otherwise couldn't we  have the following scenario when, for example we test
> surveys?
>
> ..../.../manage.php?where=test&sid=xx - then clicking the submit button would
> generate:
> ../../manage.php?where=test?where=test&sid=xx
>
>
> Regards
>
>
> Kon

Re: [phpesp-dev] Patch for Auto-publishing

[Kon A. <ang...@ip...>]

Hi Guys,

Just downloaded the latest version to have a look at Matthews patch and was 
looking at the code for handler.php


     75         $action = $HTTP_SERVER_VARS['PHP_SELF'];
     76         if (!empty($HTTP_SERVER_VARS['QUERY_STRING']))
     77                 $action .= "?" . $HTTP_SERVER_VARS['QUERY_STRING'];

should line 77 read $action = "?" .$HTTP_SERVER_VARS['QUERY_STRING']; instead?

otherwise couldn't we  have the following scenario when, for example we test 
surveys?

..../.../manage.php?where=test&sid=xx - then clicking the submit button would 
generate:
../../manage.php?where=test?where=test&sid=xx


Regards


Kon



On Mon, 15 Apr 2002 05:05, James E. Flemer wrote:
> On Wed, 10 Apr 2002, Matthew Gregg wrote:
> > Attached is first run at a patch to allow publishing of surveys
> > without needing to manually create a php "include" file.
>
> I made a few slight changes, nothing effecting use, and
> committed this patch. Thanks.
>
> > Take a look in handler-prefix.php where the remote user id is found.
> > I commented the QUERY_STRING case because it would grab the
> > query string for survey selection every time.   Can we live without
> > that case?
>
> I changed this so that survey.php removes "name=xxx" from
> the query string, so no mods to handler-prefix were needed.
>
> Thanks for the patch.
>
> -James
>
>
> _______________________________________________
> phpESP-devel mailing list
> php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpesp-devel

Re: [phpesp-dev] Patch for Auto-publishing

[James E. F. <jf...@ac...>]

On Wed, 10 Apr 2002, Matthew Gregg wrote:

> Attached is first run at a patch to allow publishing of surveys
> without needing to manually create a php "include" file.

I made a few slight changes, nothing effecting use, and
committed this patch. Thanks.

> Take a look in handler-prefix.php where the remote user id is found.
> I commented the QUERY_STRING case because it would grab the
> query string for survey selection every time.   Can we live without
> that case?

I changed this so that survey.php removes "name=xxx" from
the query string, so no mods to handler-prefix were needed.

Thanks for the patch.

-James

[phpesp-dev] Patch for Auto-publishing

[Matthew G. <gr...@mu...>]

Attached is first run at a patch to allow publishing of surveys
without needing to manually create a php "include" file.

Take a look in handler-prefix.php where the remote user id is found.
I commented the QUERY_STRING case because it would grab the
query string for survey selection every time.   Can we live without
that case?

Please point out other gaping holes that are sure to exist.

-- 
brought to you by, Matthew Gregg...
one of the friendly folks in the IT Lab.
--------------------------------------\
The IT Lab (http://www.itlab.musc.edu) \____________________
Probably the world's premier software development center.
Serving: Programming, Tools, Ice Cream, Seminars

Re: [phpesp-dev] yet another phpESP GUI

[Kon A. <ang...@ip...>]

These are not mock but actual web pages and should all fit within an 800px 
window. I want to finish off the graphics work on my 3rd GUI design and then 
I'd be glad to tar everything up and send it to you to get them online.

Kon

On Mon, 8 Apr 2002 23:41, James E. Flemer wrote:
> That looks really good. The image you attached was 946px
> wide, but I assume that layout will also fit into an 800px
> window too. Are those mock up's or screen shots of actual
> web pages? I'd like to get some HTML online somewhere so we
> can try it in a few other browsers at some point.
> -James
>
> On Mon, 8 Apr 2002, Kon Angelopoulos wrote:
> > Guys,
> >
> > I've revised the 2nd GUI I designed and have attached it for your
> > comments.
> >
> > Kon
> > ----------  Forwarded Message  ----------
> >
> > Subject: Re: [phpesp-dev] yet another phpESP GUI
> > Date: Sat, 6 Apr 2002 23:43:08 +1000
> > From: Kon Angelopoulos <ang...@ip...>
> > To: "Sipke" <si...@8a...>
> > Cc: "php...@li..."
> > <php...@li...>
> >
> > Thanks for your feedback Sipke
> > I avoid using frames like the plaque !!!!
> > I'll make the changes and repost.
> >
> > Kon
> >
> > On Sat, 6 Apr 2002 18:13, you wrote:
> > > I like him very much, but a little larger font would be nice. You ca
> > > use a lot of the tilte area for that, because this is kinda large.
> > > Apart from that I like it very much. How are you gonna place it on
> > > screen? Using frames or just a align="center" statement?
> > >
> > > Sipke
>
> _______________________________________________
> phpESP-devel mailing list
> php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpesp-devel

Re: [phpesp-dev] yet another phpESP GUI

[James E. F. <jf...@ac...>]

That looks really good. The image you attached was 946px
wide, but I assume that layout will also fit into an 800px
window too. Are those mock up's or screen shots of actual
web pages? I'd like to get some HTML online somewhere so we
can try it in a few other browsers at some point.
-James

On Mon, 8 Apr 2002, Kon Angelopoulos wrote:

> Guys,
>
> I've revised the 2nd GUI I designed and have attached it for your comments.
>
> Kon
> ----------  Forwarded Message  ----------
>
> Subject: Re: [phpesp-dev] yet another phpESP GUI
> Date: Sat, 6 Apr 2002 23:43:08 +1000
> From: Kon Angelopoulos <ang...@ip...>
> To: "Sipke" <si...@8a...>
> Cc: "php...@li..." <php...@li...>
>
> Thanks for your feedback Sipke
> I avoid using frames like the plaque !!!!
> I'll make the changes and repost.
>
> Kon
>
> On Sat, 6 Apr 2002 18:13, you wrote:
> > I like him very much, but a little larger font would be nice. You ca use
> > a lot of the tilte area for that, because this is kinda large. Apart
> > from that I like it very much. How are you gonna place it on screen?
> > Using frames or just a align="center" statement?
> >
> > Sipke

Fwd: Re: [phpesp-dev] yet another phpESP GUI

[Kon A. <ang...@ip...>]

Guys,

I've revised the 2nd GUI I designed and have attached it for your comments.

Kon
----------  Forwarded Message  ----------

Subject: Re: [phpesp-dev] yet another phpESP GUI
Date: Sat, 6 Apr 2002 23:43:08 +1000
From: Kon Angelopoulos <ang...@ip...>
To: "Sipke" <si...@8a...>
Cc: "php...@li..." <php...@li...>

Thanks for your feedback Sipke
I avoid using frames like the plaque !!!!
I'll make the changes and repost.

Kon

On Sat, 6 Apr 2002 18:13, you wrote:
> I like him very much, but a little larger font would be nice. You ca use
> a lot of the tilte area for that, because this is kinda large. Apart
> from that I like it very much. How are you gonna place it on screen?
> Using frames or just a align="center" statement?
>
> Sipke
>
> -------------------------------------------------
>                   Sipke Overbeeke
>                   http://www.8a.nl
> -------------------------------------------------
>
>
>
> _______________________________________________
> phpESP-devel mailing list
> php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpesp-devel

_______________________________________________
phpESP-devel mailing list
php...@li...
https://lists.sourceforge.net/lists/listinfo/phpesp-devel

-------------------------------------------------------

Re: [phpesp-dev] yet another phpESP GUI

[Kon A. <ang...@ip...>]

Thanks for your feedback Sipke
I avoid using frames like the plaque !!!!
I'll make the changes and repost.

Kon

On Sat, 6 Apr 2002 18:13, you wrote:
> I like him very much, but a little larger font would be nice. You ca use
> a lot of the tilte area for that, because this is kinda large. Apart
> from that I like it very much. How are you gonna place it on screen?
> Using frames or just a align="center" statement?
>
> Sipke
>
> -------------------------------------------------
>                   Sipke Overbeeke
>                   http://www.8a.nl
> -------------------------------------------------
>
>
>
> _______________________________________________
> phpESP-devel mailing list
> php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpesp-devel

RE: [phpesp-dev] yet another phpESP GUI

[Sipke <si...@8a...>]

I like him very much, but a little larger font would be nice. You ca use
a lot of the tilte area for that, because this is kinda large. Apart
from that I like it very much. How are you gonna place it on screen?
Using frames or just a align="center" statement?

Sipke

-------------------------------------------------
                  Sipke Overbeeke
                  http://www.8a.nl 
-------------------------------------------------

[phpesp-dev] yet another phpESP GUI

[Kon A. <ang...@ip...>]

Hi Guys,

	Sorry for the delay , here's the second phpESP GUI I've designed
and posted for your feedback.

Kon

Re: [phpesp-dev] new phpESP GUI

[Kon A. <ang...@ip...>]

The feedback is much appreciated. Keep it comming.

whenever I design a GUI it must meet the following criteria:

1/ when viewed on an 800 x 600 screen resolution there should be no
horizontal scrolling (of course there are times when this can't be helped...).
When using a scroll, the idea is to place the least important info in the 
scroll area. Keeping this in mind which of the headings/links would you 
consider least important and therefore place in the scroll area?

Creating Section headings is always a difficult task. You try to avoid 3 
things:
	1/ clutter
	2/ headings that only contain 1 or two links because this tends to give the 
impression that this section is "underdeveloped".
	3/ headings that do not give a true reflection of its content.
	(assume that we implemented a Survey Deployment section header and placed 
"changing of status" and "change access to survey" links within this heading. 
we then proceed to analyse the functionality of the links.
are archiving, ending, editing considered survey deployments processes?
even testing cannot be truly considered a survey deployment process.


I hope this gives you an idea as to where I'm comming from and the complexity 
of GUI design.

Kon

On Sun, 31 Mar 2002 10:19, Lou Spironello wrote:
> Cool.  Love those colours (Candian spelling!).
> I wondering if the menu items under the main headings
> will have the same colour pallete as the main heading?
>
> :-)
>
> I wish I had that sense of colour maching and design.  :-((
> I guess I'm in the same boat as James on this one.
>
> I don't know if your next mock-up will contain this,
> but I still think there should be a Survey Deployement
> section (i.e. which contains the Changing of status (or publishing the
> survey) and the Change of Access).
>
> I was also thinking that Survey Administration might
> be changed to Survey Creation so then we have
>
>     Survey Creation
>     Survey Deployment
>     Survey Results
>
>     and then the
>
>     Admin
>     Utilites
>     Help
>
> That would balance the display with  3 x 3 with one at the bottom(i.e
> the contact stuff).
>
> I was just wondering about the order of the menu items in the Account
> Admin
> section.  That is, I was thinking that they should be in order of usage
> and I
> don't know what the order should be.  Any ideas?
>
> I noticed the version number!  :-))
> (I guess the reason I'm kinda sensitve about that one is that if users
> are having difficulty
> they can quickly find the version number of the package.  Moreover, it
> also saves
> time for developers when trying to track down bugs).
>
> Regarding the version number, I also think that the version should be
> placed somewhere at the bottom
> of each survey generated (in small font of course)
>
> Thank you.
> Lou.
>
>
> ----- Original Message -----
> From: "Kon Angelopoulos" <ang...@ip...>
> To: "James E. Flemer" <jf...@ac...>; "Lou Spironello"
> <lr...@at...>
> Cc: <php...@li...>
> Sent: Saturday, March 30, 2002 7:44 PM
> Subject: Re: [phpesp-dev] new phpESP GUI
>
> > Thanks for the suggestions Lou, I'll keep them in mind for the final
>
> design.
>
> > In the mean time I've implemented some of your suggestions to the GUI
>
> I posted
>
> > yesterday and have attached a revised version.
> >
> > Do they suite ?
> >
> > Kon
> >
> > On Sun, 31 Mar 2002 02:45, James E. Flemer wrote:
> > > Looks cool. I can't wait to see the rest.
> > > -James
> > >
> > >
> > > _______________________________________________
> > > phpESP-devel mailing list
> > > php...@li...
> > > https://lists.sourceforge.net/lists/listinfo/phpesp-devel
>
> _______________________________________________
> phpESP-devel mailing list
> php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpesp-devel

Re: [phpesp-dev] new phpESP GUI

[Lou S. <lr...@at...>]

----- Original Message -----
From: "James E. Flemer" <jf...@ac...>
To: "Lou Spironello" <lr...@at...>
Cc: <php...@li...>
Sent: Saturday, March 30, 2002 7:46 PM
Subject: Re: [phpesp-dev] new phpESP GUI


> On Sat, 30 Mar 2002, Lou Spironello wrote:
>
> > No complaints about the GUI just another suggestion regarding
> > old interface and the combo boxes for the yes/no options in the
Designer
> > Account page.  I think they should be changed to checkboxes.
> >
> > I was also thinking it would be good to have combo boxes
> > for the Day, Month, and Years.
>
> I was told once that combo boxes are much easier for
> disabled people, see my recent post titled "GUI design
> considerations".
I think w3.org has an accessiblity doc we might look at.

I also think there is an accessability site called bobby???? which
may validate pages regarding disability issues, etc.  I can check into
this one.

> Perhaps this should be a configurable preference.
Sounds good.


> -James
>
>
>
>
> _______________________________________________
> phpESP-devel mailing list
> php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpesp-devel
>

Re: [phpesp-dev] new phpESP GUI

[Lou S. <lr...@at...>]

----- Original Message -----
From: "James E. Flemer" <jf...@ac...>
Cc: <php...@li...>
Sent: Saturday, March 30, 2002 7:49 PM
Subject: Re: [phpesp-dev] new phpESP GUI


> On Sat, 30 Mar 2002, Lou Spironello wrote:
>
> > I noticed the version number!  :-))
> > (I guess the reason I'm kinda sensitve about that one
> > is that if users are having difficulty they can quickly
> > find the version number of the package.  Moreover, it
> > also saves time for developers when trying to track
> > down bugs).
> >
> > Regarding the version number, I also think that the
> > version should be placed somewhere at the bottom of
> > each survey generated (in small font of course)
>
> I want the generated survey to be free of all
> advertisements. Or at the least have it be "opt-in" (ie.
> default to no advertisement).
I think a configurable option would be good considering that this would
make
phpESP more generalized.

Lou.
> -James
>
>
> _______________________________________________
> phpESP-devel mailing list
> php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpesp-devel
>

Re: [phpesp-dev] GUI design considerations

[Lou S. <lr...@at...>]

----- Original Message -----
From: "James E. Flemer" <jf...@ac...>
To: <php...@li...>
Sent: Saturday, March 30, 2002 7:44 PM
Subject: [phpesp-dev] GUI design considerations


> When doing any GUI design please keep these points in mind.
> I do want phpESP to have a nice "look-and-feel" but at the
> same time I want it to be usable by as many people as
> possible. I use lynx from time to time myself...
Yes.  (lynx)  Hmmm. I'm not going to touch this one.

However, issues of looking forward to WAP/WML enabled phpESP surveys
or portable device output should be considered (again, xslt would be
ideal for
this stuff however, things can get very very messy and complex when
dealing with complex forms and surveys)

I think we need a brainstorming session about these things.

Lou.

> -James
>
> ---------- Forwarded message ----------
> Date: Mon, 22 Oct 2001 16:16:16 -0500
> From: Matt Campbell <ma...@fr...>
> To: jf...@ac...
> Subject: Great job on phpESP!
>
> Hello,
>
> I work for InHouse Radio Networks, Inc., and we're working on a
product
> called the Freedom Box which gives blind and other disabled people
> access to the Internet through speech synthesis and speech
recognition.
> We're going to run a market survey to find out about our potential
> customers, and I was put in charge of setting it up.  I was going to
> write my own custom PHP scripts to do it, but thought I'd first look
to
> see if a PHP survey package was already available.
>
> I found phpESP (1.2beta3), and decided to check it out.  I've got it
up
> and running, and the president of the company is very pleased with it.
> Great job, and thanks for making this package available for free!
>
> A few suggestions:
>
> 1.  Include alt attributes for all your images, especially the form
> buttons for the tabs on the survey creation/editing pages.  This way
> people using text-only browsers such as Lynx, as well as blind people
> using screen readers, can tell what these images are.
>
> 2.  Use drop-down menus instead of radio buttons whenever possible
> (e.g. on the page for creating or editing a survey question).
> The president of this company that I'm working for is blind himself,
> and he says that drop-down menus are much easier to use with his
screen
> reader than radio buttons are.  Besides, drop-down menus take up less
> space on the page.
>
> 3.  When rendering a survey question with "!other" as the last choice,
> it would be best if phpESP displayed "other" or "Other" without the
> exclamation mark.  Also would it be possible to include an "Other"
> choice and an accompanying text field for questions where the choices
> are presented in a drop-down menu?  That way we don't have to use
radio
> buttons at all.
>
> I've implemented #1 and #2 in our local copy, and will work on #3
soon.
>
> Thanks,
> --
> Matt Campbell
> Programmer and System Administrator
> InHouse Radio Networks, Inc.
> http://www.freedombox.cc/
>
>
> _______________________________________________
> phpESP-devel mailing list
> php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpesp-devel
>

Re: [phpesp-dev] Bugs in latest devel CVS

[Kon A. <ang...@ip...>]

Sorry James,

I misunderstood your question.

I'm in desperate need of a php update.
My current version is 4.0.4pl1 which made me realise that the php super 
global  $_REQUEST is not available prior to php4.1.0.

I just found the latest source files for php on my box but I've forgotten to 
update.


Kon

On Sun, 31 Mar 2002 08:41, Kon Angelopoulos wrote:
> James,
>
> I'm using the latest version - ckecked out from devel cvs yesterday.
>
> Kon
>
> On Sun, 31 Mar 2002 02:26, James E. Flemer wrote:
> > What version of PHP do you have? I used $_REQUEST[] in the
> > updates for download/export. That is available only in
> > PHP4.1.0 or later. If you have an older version I would
> > suggest upgrading (security holes), though if you cannot.
> > then replace $_REQUEST[] with $GLOBALS['HTTP_GET_VARS'][].
> >
> > -James
> >
> > On Sat, 30 Mar 2002, Kon Angelopoulos wrote:
> > > OK,
> > >
> > > 	I've made the correction (updated my CVS copy) but still get an
> > > "Invalid survey ID" error whenever I try to download any survey
> > > results.
> > >
> > > Any ideas ????
> > > Kon

Re: [phpesp-dev] new phpESP GUI

[James E. F. <jf...@ac...>]

On Sat, 30 Mar 2002, Lou Spironello wrote:

> I noticed the version number!  :-))
> (I guess the reason I'm kinda sensitve about that one
> is that if users are having difficulty they can quickly
> find the version number of the package.  Moreover, it
> also saves time for developers when trying to track
> down bugs).
>
> Regarding the version number, I also think that the
> version should be placed somewhere at the bottom of
> each survey generated (in small font of course)

I want the generated survey to be free of all
advertisements. Or at the least have it be "opt-in" (ie.
default to no advertisement).

-James

Re: [phpesp-dev] new phpESP GUI

[James E. F. <jf...@ac...>]

On Sat, 30 Mar 2002, Lou Spironello wrote:

> No complaints about the GUI just another suggestion regarding
> old interface and the combo boxes for the yes/no options in the Designer
> Account page.  I think they should be changed to checkboxes.
>
> I was also thinking it would be good to have combo boxes
> for the Day, Month, and Years.

I was told once that combo boxes are much easier for
disabled people, see my recent post titled "GUI design
considerations".

Perhaps this should be a configurable preference.
-James