phpesp-devel — Discussion of the development of phpESP

[phpesp-dev] [ phpesp-Bugs-2897990 ] uninitialized GLOBALS array breaks esp_setlocale()

[SourceForge.net <no...@so...>]

Bugs item #2897990, was opened at 2009-11-15 13:34
Message generated for change (Comment added) made by bochoven
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108956&aid=2897990&group_id=8956

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: User
Group: 2.1.3
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Arjen van Bochoven (bochoven)
Assigned to: Nobody/Anonymous (nobody)
Summary: uninitialized GLOBALS array breaks esp_setlocale()

Initial Comment:
On line 94 of php.ini.fixed, a call is made to esp_setlocale_ex() which in turn calls esp_setlocale() (both live in espi18n.inc). 
On line 110, 114 and 115 of espi18n.inc, esp_setlocale() accesses $ESPCONFIG as a global variable, which is not initialized yet.
Initialization of $GLOBALS['ESPCONFIG'] happens at the end of php.ini.fixed, so after the part that references esp_setlocale();

As a quick fix I moved the initialization part above the esp_setlocale() calls. As a consequence, all references to the ESPCONFIG array that come after that have to be changed to $GLOBALS['ESPCONFIG']

here's my changed code for php.ini.fixed starting on line 91 till the end of the file:

if (isset($GLOBALS)) {
    $GLOBALS['ESPCONFIG'] = $ESPCONFIG;
} else {
    global $ESPCONFIG;
}

// Load I18N support
require_once($GLOBALS['ESPCONFIG']['include_path'] . '/lib/espi18n' . $GLOBALS['ESPCONFIG']['extension']);
if (isset($_REQUEST['lang'])) { 
   esp_setlocale_ex($_REQUEST['lang']);
   $_SESSION['language']=$_REQUEST['lang'];
} elseif (isset($lang)) {
   esp_setlocale_ex($lang);
   $_SESSION['language']=$lang;
} elseif (isset($_SESSION['language'])) {
   esp_setlocale_ex($_SESSION['language']);
} else {
   esp_setlocale_ex();
}


// default thank you messages
$GLOBALS['ESPCONFIG']['thank_head'] = _('Thank You For Completing This Survey.');
$GLOBALS['ESPCONFIG']['thank_body'] = _('Please do not use the back button on your browser to go
back.');

if (!file_exists($GLOBALS['ESPCONFIG']['include_path']. '/funcs'. $GLOBALS['ESPCONFIG']['extension'])) {
    printf('<b>'. _('Unable to find the phpESP %s directory.
			Please check %s to ensure that all paths are set correctly.') .
			'</b>', 'include', 'phpESP.ini.php');
    exit;
}
if (!file_exists($GLOBALS['ESPCONFIG']['css_path'])) {
    printf('<b>'. _('Unable to find the phpESP %s directory.
			Please check %s to ensure that all paths are set correctly.') .
			'</b>', 'css', 'phpESP.ini.php');
    exit;
}



require_once($GLOBALS['ESPCONFIG']['include_path'].'/funcs'.$GLOBALS['ESPCONFIG']['extension']);

?>


----------------------------------------------------------------------

>Comment By: Arjen van Bochoven (bochoven)
Date: 2009-11-21 12:11

Message:
Solved: when I declare the following inside the function:

global $ESPCONFIG;

all is fine, my previous hacking of the config files is unnecessary.

Maybe update documentation to state that when the include is done inside a
function, you have to declare the $ESPCONFIG array as global. 

I am including phpESP in a CMS based on CodeIgniter, a MVC framework. In
CI, views (templates) don't exist in global scope so setting global
$ESPCONFIG; fixes the variable problem.

----------------------------------------------------------------------

Comment By: Arjen van Bochoven (bochoven)
Date: 2009-11-21 12:04

Message:
Moving the phpESP.first.php to the top of the script does not make a
difference, please mind that I am including /public/handler.php inside a
function. This is indeed a matter of scope, variables that are declared
outside the function are not available within it. In your example, if I
replace

<?php
include("/path/phpESP/public/handler.php");
?>

with

<?php
function survey(){include("/path/phpESP/public/handler.php");}
survey();
?>

I get these messages:

Notice: Undefined variable: ESPCONFIG in /path/phpESP/public/handler.php
on line 26
Notice: Undefined variable: ESPCONFIG in /path/phpESP/public/handler.php
on line 26
Warning: require_once(/funcs) [function.require-once]: failed to open
stream: No such file or directory in /path/phpESP/public/handler.php on
line 26



----------------------------------------------------------------------

Comment By: Franky Van Liedekerke (liedekef)
Date: 2009-11-18 22:35

Message:
Look at the comments in the examples php files: the include of
public/phpESP.first.php needs to happen BEFORE any output begins (reason:
session initialization etc)
Try this:

<?php
ini_set( 'display_errors', true );
error_reporting(E_ALL);
$lang='nl_NL';
$sid=9;
include("/home/bochoven/php/phpESP/public/phpESP.first.php");
?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">

<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8"/>

<title>survey</title>

</head>

<body>

<?php
include("/home/bochoven/php/phpESP/public/handler.php");
?>

</body>
</html>

----------------------------------------------------------------------

Comment By: Franky Van Liedekerke (liedekef)
Date: 2009-11-18 22:16

Message:
I found this one weird, so I took a deeper look at it. First of all: I
don't like the use of global variables, but that put aside, I believe this
remark to be wrong:
in php, using "global <variablename>", refers to the value of the variable
outside the function, see
http://php.net/manual/en/language.variables.scope.php (example 2).
Using $GLOBALS should be removed as much as possible, but I didn't get
around to doing that (yet), but still it doesn't change the fact that it
remains the same.
What did you see as an error when you claim that "uninitialized GLOBALS
array breaks esp_setlocale()"?

----------------------------------------------------------------------

Comment By: Arjen van Bochoven (bochoven)
Date: 2009-11-15 20:28

Message:
Hmm, further investigation showed that this problem only arises when you
don't include the handler.php in global space (eg in a function or a
class). I would still want to flag this as a bug. Example code below:

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
	"http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">

<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
<head>
	<meta http-equiv="Content-Type" content="text/html; charset=utf-8"/>

	<title>survey</title>
	
</head>

<body>
	
	<?php 
	
	ini_set( 'display_errors', true );
	error_reporting(E_ALL);
	
	function survey()
	{
		$lang='nl_NL';
		$sid=9;
		include("/home/bochoven/php/phpESP/public/phpESP.first.php");
		include("/home/bochoven/php/phpESP/public/handler.php");
	}
	
	survey();
		
	?>

</body>
</html>

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108956&aid=2897990&group_id=8956

[phpesp-dev] [ phpesp-Bugs-2897990 ] uninitialized GLOBALS array breaks esp_setlocale()

[SourceForge.net <no...@so...>]

Bugs item #2897990, was opened at 2009-11-15 13:34
Message generated for change (Comment added) made by bochoven
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108956&aid=2897990&group_id=8956

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: User
Group: 2.1.3
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Arjen van Bochoven (bochoven)
Assigned to: Nobody/Anonymous (nobody)
Summary: uninitialized GLOBALS array breaks esp_setlocale()

Initial Comment:
On line 94 of php.ini.fixed, a call is made to esp_setlocale_ex() which in turn calls esp_setlocale() (both live in espi18n.inc). 
On line 110, 114 and 115 of espi18n.inc, esp_setlocale() accesses $ESPCONFIG as a global variable, which is not initialized yet.
Initialization of $GLOBALS['ESPCONFIG'] happens at the end of php.ini.fixed, so after the part that references esp_setlocale();

As a quick fix I moved the initialization part above the esp_setlocale() calls. As a consequence, all references to the ESPCONFIG array that come after that have to be changed to $GLOBALS['ESPCONFIG']

here's my changed code for php.ini.fixed starting on line 91 till the end of the file:

if (isset($GLOBALS)) {
    $GLOBALS['ESPCONFIG'] = $ESPCONFIG;
} else {
    global $ESPCONFIG;
}

// Load I18N support
require_once($GLOBALS['ESPCONFIG']['include_path'] . '/lib/espi18n' . $GLOBALS['ESPCONFIG']['extension']);
if (isset($_REQUEST['lang'])) { 
   esp_setlocale_ex($_REQUEST['lang']);
   $_SESSION['language']=$_REQUEST['lang'];
} elseif (isset($lang)) {
   esp_setlocale_ex($lang);
   $_SESSION['language']=$lang;
} elseif (isset($_SESSION['language'])) {
   esp_setlocale_ex($_SESSION['language']);
} else {
   esp_setlocale_ex();
}


// default thank you messages
$GLOBALS['ESPCONFIG']['thank_head'] = _('Thank You For Completing This Survey.');
$GLOBALS['ESPCONFIG']['thank_body'] = _('Please do not use the back button on your browser to go
back.');

if (!file_exists($GLOBALS['ESPCONFIG']['include_path']. '/funcs'. $GLOBALS['ESPCONFIG']['extension'])) {
    printf('<b>'. _('Unable to find the phpESP %s directory.
			Please check %s to ensure that all paths are set correctly.') .
			'</b>', 'include', 'phpESP.ini.php');
    exit;
}
if (!file_exists($GLOBALS['ESPCONFIG']['css_path'])) {
    printf('<b>'. _('Unable to find the phpESP %s directory.
			Please check %s to ensure that all paths are set correctly.') .
			'</b>', 'css', 'phpESP.ini.php');
    exit;
}



require_once($GLOBALS['ESPCONFIG']['include_path'].'/funcs'.$GLOBALS['ESPCONFIG']['extension']);

?>


----------------------------------------------------------------------

>Comment By: Arjen van Bochoven (bochoven)
Date: 2009-11-21 12:04

Message:
Moving the phpESP.first.php to the top of the script does not make a
difference, please mind that I am including /public/handler.php inside a
function. This is indeed a matter of scope, variables that are declared
outside the function are not available within it. In your example, if I
replace

<?php
include("/path/phpESP/public/handler.php");
?>

with

<?php
function survey(){include("/path/phpESP/public/handler.php");}
survey();
?>

I get these messages:

Notice: Undefined variable: ESPCONFIG in /path/phpESP/public/handler.php
on line 26
Notice: Undefined variable: ESPCONFIG in /path/phpESP/public/handler.php
on line 26
Warning: require_once(/funcs) [function.require-once]: failed to open
stream: No such file or directory in /path/phpESP/public/handler.php on
line 26



----------------------------------------------------------------------

Comment By: Franky Van Liedekerke (liedekef)
Date: 2009-11-18 22:35

Message:
Look at the comments in the examples php files: the include of
public/phpESP.first.php needs to happen BEFORE any output begins (reason:
session initialization etc)
Try this:

<?php
ini_set( 'display_errors', true );
error_reporting(E_ALL);
$lang='nl_NL';
$sid=9;
include("/home/bochoven/php/phpESP/public/phpESP.first.php");
?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">

<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8"/>

<title>survey</title>

</head>

<body>

<?php
include("/home/bochoven/php/phpESP/public/handler.php");
?>

</body>
</html>

----------------------------------------------------------------------

Comment By: Franky Van Liedekerke (liedekef)
Date: 2009-11-18 22:16

Message:
I found this one weird, so I took a deeper look at it. First of all: I
don't like the use of global variables, but that put aside, I believe this
remark to be wrong:
in php, using "global <variablename>", refers to the value of the variable
outside the function, see
http://php.net/manual/en/language.variables.scope.php (example 2).
Using $GLOBALS should be removed as much as possible, but I didn't get
around to doing that (yet), but still it doesn't change the fact that it
remains the same.
What did you see as an error when you claim that "uninitialized GLOBALS
array breaks esp_setlocale()"?

----------------------------------------------------------------------

Comment By: Arjen van Bochoven (bochoven)
Date: 2009-11-15 20:28

Message:
Hmm, further investigation showed that this problem only arises when you
don't include the handler.php in global space (eg in a function or a
class). I would still want to flag this as a bug. Example code below:

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
	"http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">

<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
<head>
	<meta http-equiv="Content-Type" content="text/html; charset=utf-8"/>

	<title>survey</title>
	
</head>

<body>
	
	<?php 
	
	ini_set( 'display_errors', true );
	error_reporting(E_ALL);
	
	function survey()
	{
		$lang='nl_NL';
		$sid=9;
		include("/home/bochoven/php/phpESP/public/phpESP.first.php");
		include("/home/bochoven/php/phpESP/public/handler.php");
	}
	
	survey();
		
	?>

</body>
</html>

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108956&aid=2897990&group_id=8956

[phpesp-dev] [ phpesp-Feature Requests-2900957 ] Add Tool Tips

[SourceForge.net <no...@so...>]

Feature Requests item #2900957, was opened at 2009-11-20 06:33
Message generated for change (Tracker Item Submitted) made by nobody
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=358956&aid=2900957&group_id=8956

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: gui
Group: None
Status: Open
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: Add Tool Tips

Initial Comment:
I think a great feature to add to each question as an option would be "Tool Tips" a pop up balloon giving you the capability 
to type in support for an individual question. In my case I would have used it to put in a different language for each question...
Rather than having to make two separate surveys of one in each language, it would have been much easier to have 
English as the primary survey and the tool tips to be in a secondary language.

-- Just a though

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=358956&aid=2900957&group_id=8956

[phpesp-dev] [ phpesp-Bugs-2898674 ] language dropdown shown at login

[SourceForge.net <no...@so...>]

Bugs item #2898674, was opened at 2009-11-16 21:47
Message generated for change (Comment added) made by liedekef
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108956&aid=2898674&group_id=8956

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Arjen van Bochoven (bochoven)
Assigned to: Nobody/Anonymous (nobody)
Summary: language dropdown shown at login

Initial Comment:
When including phpESP using /public/handler.php you can specify the language of your survey by supplying the language in a $lang variable. If you specify this variable, the login screen should not show the language chooser dropdown, unfortunately this does not work.

Reason is the fact that the language variable is not available within the function show_login() that is part of admin/include/lib/esphtml.forms.inc

Solution is to change the variable $lang into $_SESSION['language'] on line 194:

    # if the variable $lang is set, we assume we don't need to ask for the language
    if ((!isset($_REQUEST['lang']) && !isset($lang)) || empty($lang)) {

fixed:

    # if the variable $lang is set, we assume we don't need to ask for the language
    if ((!isset($_REQUEST['lang']) && !$_SESSION['language']) || empty($_SESSION['language'])) {



Arjen



----------------------------------------------------------------------

>Comment By: Franky Van Liedekerke (liedekef)
Date: 2009-11-18 22:50

Message:
Well, I was right about the localization, but indeed the $lang needs to be
replaced with $_SESSION['language'], fixed in svn

----------------------------------------------------------------------

Comment By: Franky Van Liedekerke (liedekef)
Date: 2009-11-18 22:43

Message:
The login box *is* localized, but I suspect the same reason counts as in
bugreport 2897990: you need to include phpESP.first.php before any other
html output.
The words "Username:" and "Password:" weren't localized though, I fixed
that in SVN

Franky

----------------------------------------------------------------------

Comment By: Arjen van Bochoven (bochoven)
Date: 2009-11-17 21:24

Message:
I would really like a way to loose the dropdown, so the respondents don't
get confused. I assumed from the comment that supplying the $lang variable
was the proper way to do just that.

Eventually I think a MVC approach would be better (separating presentation
logic from business logic) so anyone could switch in their own templates,
but that would require a large rewrite.

As a minor point I noticed that the login box is not localized, maybe a
todo item?

cheers

Arjen

----------------------------------------------------------------------

Comment By: bishop (bishopb)
Date: 2009-11-17 21:00

Message:
Might we want the drop-down to remain, even though the value is preset? 
Argument from usability: that gives the user the option to choosing the
language that is appropriate for them.

Of course, we don't handle multi-language survey questions anyway, so this
usability argument may be specious.  Or maybe this should be handled at
configuration time (either static in the .ini files or in the survey
itself)?

----------------------------------------------------------------------

Comment By: Franky Van Liedekerke (liedekef)
Date: 2009-11-16 21:52

Message:
will take a look at it asap :-)
Tx for the work already!

Franky

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108956&aid=2898674&group_id=8956

[phpesp-dev] [ phpesp-Bugs-2898674 ] language dropdown shown at login

[SourceForge.net <no...@so...>]

Bugs item #2898674, was opened at 2009-11-16 21:47
Message generated for change (Comment added) made by liedekef
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108956&aid=2898674&group_id=8956

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Arjen van Bochoven (bochoven)
Assigned to: Nobody/Anonymous (nobody)
Summary: language dropdown shown at login

Initial Comment:
When including phpESP using /public/handler.php you can specify the language of your survey by supplying the language in a $lang variable. If you specify this variable, the login screen should not show the language chooser dropdown, unfortunately this does not work.

Reason is the fact that the language variable is not available within the function show_login() that is part of admin/include/lib/esphtml.forms.inc

Solution is to change the variable $lang into $_SESSION['language'] on line 194:

    # if the variable $lang is set, we assume we don't need to ask for the language
    if ((!isset($_REQUEST['lang']) && !isset($lang)) || empty($lang)) {

fixed:

    # if the variable $lang is set, we assume we don't need to ask for the language
    if ((!isset($_REQUEST['lang']) && !$_SESSION['language']) || empty($_SESSION['language'])) {



Arjen



----------------------------------------------------------------------

>Comment By: Franky Van Liedekerke (liedekef)
Date: 2009-11-18 22:43

Message:
The login box *is* localized, but I suspect the same reason counts as in
bugreport 2897990: you need to include phpESP.first.php before any other
html output.
The words "Username:" and "Password:" weren't localized though, I fixed
that in SVN

Franky

----------------------------------------------------------------------

Comment By: Arjen van Bochoven (bochoven)
Date: 2009-11-17 21:24

Message:
I would really like a way to loose the dropdown, so the respondents don't
get confused. I assumed from the comment that supplying the $lang variable
was the proper way to do just that.

Eventually I think a MVC approach would be better (separating presentation
logic from business logic) so anyone could switch in their own templates,
but that would require a large rewrite.

As a minor point I noticed that the login box is not localized, maybe a
todo item?

cheers

Arjen

----------------------------------------------------------------------

Comment By: bishop (bishopb)
Date: 2009-11-17 21:00

Message:
Might we want the drop-down to remain, even though the value is preset? 
Argument from usability: that gives the user the option to choosing the
language that is appropriate for them.

Of course, we don't handle multi-language survey questions anyway, so this
usability argument may be specious.  Or maybe this should be handled at
configuration time (either static in the .ini files or in the survey
itself)?

----------------------------------------------------------------------

Comment By: Franky Van Liedekerke (liedekef)
Date: 2009-11-16 21:52

Message:
will take a look at it asap :-)
Tx for the work already!

Franky

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108956&aid=2898674&group_id=8956

[phpesp-dev] [ phpesp-Bugs-2897990 ] uninitialized GLOBALS array breaks esp_setlocale()

[SourceForge.net <no...@so...>]

Bugs item #2897990, was opened at 2009-11-15 13:34
Message generated for change (Comment added) made by liedekef
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108956&aid=2897990&group_id=8956

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: User
Group: 2.1.3
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Arjen van Bochoven (bochoven)
Assigned to: Nobody/Anonymous (nobody)
Summary: uninitialized GLOBALS array breaks esp_setlocale()

Initial Comment:
On line 94 of php.ini.fixed, a call is made to esp_setlocale_ex() which in turn calls esp_setlocale() (both live in espi18n.inc). 
On line 110, 114 and 115 of espi18n.inc, esp_setlocale() accesses $ESPCONFIG as a global variable, which is not initialized yet.
Initialization of $GLOBALS['ESPCONFIG'] happens at the end of php.ini.fixed, so after the part that references esp_setlocale();

As a quick fix I moved the initialization part above the esp_setlocale() calls. As a consequence, all references to the ESPCONFIG array that come after that have to be changed to $GLOBALS['ESPCONFIG']

here's my changed code for php.ini.fixed starting on line 91 till the end of the file:

if (isset($GLOBALS)) {
    $GLOBALS['ESPCONFIG'] = $ESPCONFIG;
} else {
    global $ESPCONFIG;
}

// Load I18N support
require_once($GLOBALS['ESPCONFIG']['include_path'] . '/lib/espi18n' . $GLOBALS['ESPCONFIG']['extension']);
if (isset($_REQUEST['lang'])) { 
   esp_setlocale_ex($_REQUEST['lang']);
   $_SESSION['language']=$_REQUEST['lang'];
} elseif (isset($lang)) {
   esp_setlocale_ex($lang);
   $_SESSION['language']=$lang;
} elseif (isset($_SESSION['language'])) {
   esp_setlocale_ex($_SESSION['language']);
} else {
   esp_setlocale_ex();
}


// default thank you messages
$GLOBALS['ESPCONFIG']['thank_head'] = _('Thank You For Completing This Survey.');
$GLOBALS['ESPCONFIG']['thank_body'] = _('Please do not use the back button on your browser to go
back.');

if (!file_exists($GLOBALS['ESPCONFIG']['include_path']. '/funcs'. $GLOBALS['ESPCONFIG']['extension'])) {
    printf('<b>'. _('Unable to find the phpESP %s directory.
			Please check %s to ensure that all paths are set correctly.') .
			'</b>', 'include', 'phpESP.ini.php');
    exit;
}
if (!file_exists($GLOBALS['ESPCONFIG']['css_path'])) {
    printf('<b>'. _('Unable to find the phpESP %s directory.
			Please check %s to ensure that all paths are set correctly.') .
			'</b>', 'css', 'phpESP.ini.php');
    exit;
}



require_once($GLOBALS['ESPCONFIG']['include_path'].'/funcs'.$GLOBALS['ESPCONFIG']['extension']);

?>


----------------------------------------------------------------------

>Comment By: Franky Van Liedekerke (liedekef)
Date: 2009-11-18 22:35

Message:
Look at the comments in the examples php files: the include of
public/phpESP.first.php needs to happen BEFORE any output begins (reason:
session initialization etc)
Try this:

<?php
ini_set( 'display_errors', true );
error_reporting(E_ALL);
$lang='nl_NL';
$sid=9;
include("/home/bochoven/php/phpESP/public/phpESP.first.php");
?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">

<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8"/>

<title>survey</title>

</head>

<body>

<?php
include("/home/bochoven/php/phpESP/public/handler.php");
?>

</body>
</html>

----------------------------------------------------------------------

Comment By: Franky Van Liedekerke (liedekef)
Date: 2009-11-18 22:16

Message:
I found this one weird, so I took a deeper look at it. First of all: I
don't like the use of global variables, but that put aside, I believe this
remark to be wrong:
in php, using "global <variablename>", refers to the value of the variable
outside the function, see
http://php.net/manual/en/language.variables.scope.php (example 2).
Using $GLOBALS should be removed as much as possible, but I didn't get
around to doing that (yet), but still it doesn't change the fact that it
remains the same.
What did you see as an error when you claim that "uninitialized GLOBALS
array breaks esp_setlocale()"?

----------------------------------------------------------------------

Comment By: Arjen van Bochoven (bochoven)
Date: 2009-11-15 20:28

Message:
Hmm, further investigation showed that this problem only arises when you
don't include the handler.php in global space (eg in a function or a
class). I would still want to flag this as a bug. Example code below:

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
	"http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">

<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
<head>
	<meta http-equiv="Content-Type" content="text/html; charset=utf-8"/>

	<title>survey</title>
	
</head>

<body>
	
	<?php 
	
	ini_set( 'display_errors', true );
	error_reporting(E_ALL);
	
	function survey()
	{
		$lang='nl_NL';
		$sid=9;
		include("/home/bochoven/php/phpESP/public/phpESP.first.php");
		include("/home/bochoven/php/phpESP/public/handler.php");
	}
	
	survey();
		
	?>

</body>
</html>

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108956&aid=2897990&group_id=8956

[phpesp-dev] [ phpesp-Bugs-2897990 ] uninitialized GLOBALS array breaks esp_setlocale()

[SourceForge.net <no...@so...>]

Bugs item #2897990, was opened at 2009-11-15 13:34
Message generated for change (Comment added) made by liedekef
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108956&aid=2897990&group_id=8956

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: User
Group: 2.1.3
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Arjen van Bochoven (bochoven)
Assigned to: Nobody/Anonymous (nobody)
Summary: uninitialized GLOBALS array breaks esp_setlocale()

Initial Comment:
On line 94 of php.ini.fixed, a call is made to esp_setlocale_ex() which in turn calls esp_setlocale() (both live in espi18n.inc). 
On line 110, 114 and 115 of espi18n.inc, esp_setlocale() accesses $ESPCONFIG as a global variable, which is not initialized yet.
Initialization of $GLOBALS['ESPCONFIG'] happens at the end of php.ini.fixed, so after the part that references esp_setlocale();

As a quick fix I moved the initialization part above the esp_setlocale() calls. As a consequence, all references to the ESPCONFIG array that come after that have to be changed to $GLOBALS['ESPCONFIG']

here's my changed code for php.ini.fixed starting on line 91 till the end of the file:

if (isset($GLOBALS)) {
    $GLOBALS['ESPCONFIG'] = $ESPCONFIG;
} else {
    global $ESPCONFIG;
}

// Load I18N support
require_once($GLOBALS['ESPCONFIG']['include_path'] . '/lib/espi18n' . $GLOBALS['ESPCONFIG']['extension']);
if (isset($_REQUEST['lang'])) { 
   esp_setlocale_ex($_REQUEST['lang']);
   $_SESSION['language']=$_REQUEST['lang'];
} elseif (isset($lang)) {
   esp_setlocale_ex($lang);
   $_SESSION['language']=$lang;
} elseif (isset($_SESSION['language'])) {
   esp_setlocale_ex($_SESSION['language']);
} else {
   esp_setlocale_ex();
}


// default thank you messages
$GLOBALS['ESPCONFIG']['thank_head'] = _('Thank You For Completing This Survey.');
$GLOBALS['ESPCONFIG']['thank_body'] = _('Please do not use the back button on your browser to go
back.');

if (!file_exists($GLOBALS['ESPCONFIG']['include_path']. '/funcs'. $GLOBALS['ESPCONFIG']['extension'])) {
    printf('<b>'. _('Unable to find the phpESP %s directory.
			Please check %s to ensure that all paths are set correctly.') .
			'</b>', 'include', 'phpESP.ini.php');
    exit;
}
if (!file_exists($GLOBALS['ESPCONFIG']['css_path'])) {
    printf('<b>'. _('Unable to find the phpESP %s directory.
			Please check %s to ensure that all paths are set correctly.') .
			'</b>', 'css', 'phpESP.ini.php');
    exit;
}



require_once($GLOBALS['ESPCONFIG']['include_path'].'/funcs'.$GLOBALS['ESPCONFIG']['extension']);

?>


----------------------------------------------------------------------

>Comment By: Franky Van Liedekerke (liedekef)
Date: 2009-11-18 22:16

Message:
I found this one weird, so I took a deeper look at it. First of all: I
don't like the use of global variables, but that put aside, I believe this
remark to be wrong:
in php, using "global <variablename>", refers to the value of the variable
outside the function, see
http://php.net/manual/en/language.variables.scope.php (example 2).
Using $GLOBALS should be removed as much as possible, but I didn't get
around to doing that (yet), but still it doesn't change the fact that it
remains the same.
What did you see as an error when you claim that "uninitialized GLOBALS
array breaks esp_setlocale()"?

----------------------------------------------------------------------

Comment By: Arjen van Bochoven (bochoven)
Date: 2009-11-15 20:28

Message:
Hmm, further investigation showed that this problem only arises when you
don't include the handler.php in global space (eg in a function or a
class). I would still want to flag this as a bug. Example code below:

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
	"http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">

<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
<head>
	<meta http-equiv="Content-Type" content="text/html; charset=utf-8"/>

	<title>survey</title>
	
</head>

<body>
	
	<?php 
	
	ini_set( 'display_errors', true );
	error_reporting(E_ALL);
	
	function survey()
	{
		$lang='nl_NL';
		$sid=9;
		include("/home/bochoven/php/phpESP/public/phpESP.first.php");
		include("/home/bochoven/php/phpESP/public/handler.php");
	}
	
	survey();
		
	?>

</body>
</html>

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108956&aid=2897990&group_id=8956

[phpesp-dev] [ phpesp-Bugs-2898674 ] language dropdown shown at login

[SourceForge.net <no...@so...>]

Bugs item #2898674, was opened at 2009-11-16 21:47
Message generated for change (Comment added) made by bochoven
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108956&aid=2898674&group_id=8956

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Arjen van Bochoven (bochoven)
Assigned to: Nobody/Anonymous (nobody)
Summary: language dropdown shown at login

Initial Comment:
When including phpESP using /public/handler.php you can specify the language of your survey by supplying the language in a $lang variable. If you specify this variable, the login screen should not show the language chooser dropdown, unfortunately this does not work.

Reason is the fact that the language variable is not available within the function show_login() that is part of admin/include/lib/esphtml.forms.inc

Solution is to change the variable $lang into $_SESSION['language'] on line 194:

    # if the variable $lang is set, we assume we don't need to ask for the language
    if ((!isset($_REQUEST['lang']) && !isset($lang)) || empty($lang)) {

fixed:

    # if the variable $lang is set, we assume we don't need to ask for the language
    if ((!isset($_REQUEST['lang']) && !$_SESSION['language']) || empty($_SESSION['language'])) {



Arjen



----------------------------------------------------------------------

>Comment By: Arjen van Bochoven (bochoven)
Date: 2009-11-17 21:24

Message:
I would really like a way to loose the dropdown, so the respondents don't
get confused. I assumed from the comment that supplying the $lang variable
was the proper way to do just that.

Eventually I think a MVC approach would be better (separating presentation
logic from business logic) so anyone could switch in their own templates,
but that would require a large rewrite.

As a minor point I noticed that the login box is not localized, maybe a
todo item?

cheers

Arjen

----------------------------------------------------------------------

Comment By: bishop (bishopb)
Date: 2009-11-17 21:00

Message:
Might we want the drop-down to remain, even though the value is preset? 
Argument from usability: that gives the user the option to choosing the
language that is appropriate for them.

Of course, we don't handle multi-language survey questions anyway, so this
usability argument may be specious.  Or maybe this should be handled at
configuration time (either static in the .ini files or in the survey
itself)?

----------------------------------------------------------------------

Comment By: Franky Van Liedekerke (liedekef)
Date: 2009-11-16 21:52

Message:
will take a look at it asap :-)
Tx for the work already!

Franky

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108956&aid=2898674&group_id=8956

[phpesp-dev] [ phpesp-Bugs-2898674 ] language dropdown shown at login

[SourceForge.net <no...@so...>]

Bugs item #2898674, was opened at 2009-11-16 15:47
Message generated for change (Comment added) made by bishopb
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108956&aid=2898674&group_id=8956

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Arjen van Bochoven (bochoven)
Assigned to: Nobody/Anonymous (nobody)
Summary: language dropdown shown at login

Initial Comment:
When including phpESP using /public/handler.php you can specify the language of your survey by supplying the language in a $lang variable. If you specify this variable, the login screen should not show the language chooser dropdown, unfortunately this does not work.

Reason is the fact that the language variable is not available within the function show_login() that is part of admin/include/lib/esphtml.forms.inc

Solution is to change the variable $lang into $_SESSION['language'] on line 194:

    # if the variable $lang is set, we assume we don't need to ask for the language
    if ((!isset($_REQUEST['lang']) && !isset($lang)) || empty($lang)) {

fixed:

    # if the variable $lang is set, we assume we don't need to ask for the language
    if ((!isset($_REQUEST['lang']) && !$_SESSION['language']) || empty($_SESSION['language'])) {



Arjen



----------------------------------------------------------------------

>Comment By: bishop (bishopb)
Date: 2009-11-17 15:00

Message:
Might we want the drop-down to remain, even though the value is preset? 
Argument from usability: that gives the user the option to choosing the
language that is appropriate for them.

Of course, we don't handle multi-language survey questions anyway, so this
usability argument may be specious.  Or maybe this should be handled at
configuration time (either static in the .ini files or in the survey
itself)?

----------------------------------------------------------------------

Comment By: Franky Van Liedekerke (liedekef)
Date: 2009-11-16 15:52

Message:
will take a look at it asap :-)
Tx for the work already!

Franky

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108956&aid=2898674&group_id=8956

[phpesp-dev] [ phpesp-Bugs-2898674 ] language dropdown shown at login

[SourceForge.net <no...@so...>]

Bugs item #2898674, was opened at 2009-11-16 21:47
Message generated for change (Comment added) made by liedekef
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108956&aid=2898674&group_id=8956

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Arjen van Bochoven (bochoven)
Assigned to: Nobody/Anonymous (nobody)
Summary: language dropdown shown at login

Initial Comment:
When including phpESP using /public/handler.php you can specify the language of your survey by supplying the language in a $lang variable. If you specify this variable, the login screen should not show the language chooser dropdown, unfortunately this does not work.

Reason is the fact that the language variable is not available within the function show_login() that is part of admin/include/lib/esphtml.forms.inc

Solution is to change the variable $lang into $_SESSION['language'] on line 194:

    # if the variable $lang is set, we assume we don't need to ask for the language
    if ((!isset($_REQUEST['lang']) && !isset($lang)) || empty($lang)) {

fixed:

    # if the variable $lang is set, we assume we don't need to ask for the language
    if ((!isset($_REQUEST['lang']) && !$_SESSION['language']) || empty($_SESSION['language'])) {



Arjen



----------------------------------------------------------------------

>Comment By: Franky Van Liedekerke (liedekef)
Date: 2009-11-16 21:52

Message:
will take a look at it asap :-)
Tx for the work already!

Franky

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108956&aid=2898674&group_id=8956

[phpesp-dev] [ phpesp-Bugs-2898674 ] language dropdown shown at login

[SourceForge.net <no...@so...>]

Bugs item #2898674, was opened at 2009-11-16 21:47
Message generated for change (Tracker Item Submitted) made by bochoven
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108956&aid=2898674&group_id=8956

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Arjen van Bochoven (bochoven)
Assigned to: Nobody/Anonymous (nobody)
Summary: language dropdown shown at login

Initial Comment:
When including phpESP using /public/handler.php you can specify the language of your survey by supplying the language in a $lang variable. If you specify this variable, the login screen should not show the language chooser dropdown, unfortunately this does not work.

Reason is the fact that the language variable is not available within the function show_login() that is part of admin/include/lib/esphtml.forms.inc

Solution is to change the variable $lang into $_SESSION['language'] on line 194:

    # if the variable $lang is set, we assume we don't need to ask for the language
    if ((!isset($_REQUEST['lang']) && !isset($lang)) || empty($lang)) {

fixed:

    # if the variable $lang is set, we assume we don't need to ask for the language
    if ((!isset($_REQUEST['lang']) && !$_SESSION['language']) || empty($_SESSION['language'])) {



Arjen



----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108956&aid=2898674&group_id=8956

[phpesp-dev] [ phpesp-Bugs-2897990 ] uninitialized GLOBALS array breaks esp_setlocale()

[SourceForge.net <no...@so...>]

Bugs item #2897990, was opened at 2009-11-15 13:34
Message generated for change (Comment added) made by bochoven
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108956&aid=2897990&group_id=8956

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: User
Group: 2.1.3
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Arjen van Bochoven (bochoven)
Assigned to: Nobody/Anonymous (nobody)
Summary: uninitialized GLOBALS array breaks esp_setlocale()

Initial Comment:
On line 94 of php.ini.fixed, a call is made to esp_setlocale_ex() which in turn calls esp_setlocale() (both live in espi18n.inc). 
On line 110, 114 and 115 of espi18n.inc, esp_setlocale() accesses $ESPCONFIG as a global variable, which is not initialized yet.
Initialization of $GLOBALS['ESPCONFIG'] happens at the end of php.ini.fixed, so after the part that references esp_setlocale();

As a quick fix I moved the initialization part above the esp_setlocale() calls. As a consequence, all references to the ESPCONFIG array that come after that have to be changed to $GLOBALS['ESPCONFIG']

here's my changed code for php.ini.fixed starting on line 91 till the end of the file:

if (isset($GLOBALS)) {
    $GLOBALS['ESPCONFIG'] = $ESPCONFIG;
} else {
    global $ESPCONFIG;
}

// Load I18N support
require_once($GLOBALS['ESPCONFIG']['include_path'] . '/lib/espi18n' . $GLOBALS['ESPCONFIG']['extension']);
if (isset($_REQUEST['lang'])) { 
   esp_setlocale_ex($_REQUEST['lang']);
   $_SESSION['language']=$_REQUEST['lang'];
} elseif (isset($lang)) {
   esp_setlocale_ex($lang);
   $_SESSION['language']=$lang;
} elseif (isset($_SESSION['language'])) {
   esp_setlocale_ex($_SESSION['language']);
} else {
   esp_setlocale_ex();
}


// default thank you messages
$GLOBALS['ESPCONFIG']['thank_head'] = _('Thank You For Completing This Survey.');
$GLOBALS['ESPCONFIG']['thank_body'] = _('Please do not use the back button on your browser to go
back.');

if (!file_exists($GLOBALS['ESPCONFIG']['include_path']. '/funcs'. $GLOBALS['ESPCONFIG']['extension'])) {
    printf('<b>'. _('Unable to find the phpESP %s directory.
			Please check %s to ensure that all paths are set correctly.') .
			'</b>', 'include', 'phpESP.ini.php');
    exit;
}
if (!file_exists($GLOBALS['ESPCONFIG']['css_path'])) {
    printf('<b>'. _('Unable to find the phpESP %s directory.
			Please check %s to ensure that all paths are set correctly.') .
			'</b>', 'css', 'phpESP.ini.php');
    exit;
}



require_once($GLOBALS['ESPCONFIG']['include_path'].'/funcs'.$GLOBALS['ESPCONFIG']['extension']);

?>


----------------------------------------------------------------------

>Comment By: Arjen van Bochoven (bochoven)
Date: 2009-11-15 20:28

Message:
Hmm, further investigation showed that this problem only arises when you
don't include the handler.php in global space (eg in a function or a
class). I would still want to flag this as a bug. Example code below:

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
	"http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">

<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
<head>
	<meta http-equiv="Content-Type" content="text/html; charset=utf-8"/>

	<title>survey</title>
	
</head>

<body>
	
	<?php 
	
	ini_set( 'display_errors', true );
	error_reporting(E_ALL);
	
	function survey()
	{
		$lang='nl_NL';
		$sid=9;
		include("/home/bochoven/php/phpESP/public/phpESP.first.php");
		include("/home/bochoven/php/phpESP/public/handler.php");
	}
	
	survey();
		
	?>

</body>
</html>

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108956&aid=2897990&group_id=8956

[phpesp-dev] [ phpesp-Bugs-2897990 ] uninitialized GLOBALS array breaks esp_setlocale()

[SourceForge.net <no...@so...>]

Bugs item #2897990, was opened at 2009-11-15 13:34
Message generated for change (Tracker Item Submitted) made by bochoven
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108956&aid=2897990&group_id=8956

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: User
Group: 2.1.3
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Arjen van Bochoven (bochoven)
Assigned to: Nobody/Anonymous (nobody)
Summary: uninitialized GLOBALS array breaks esp_setlocale()

Initial Comment:
On line 94 of php.ini.fixed, a call is made to esp_setlocale_ex() which in turn calls esp_setlocale() (both live in espi18n.inc). 
On line 110, 114 and 115 of espi18n.inc, esp_setlocale() accesses $ESPCONFIG as a global variable, which is not initialized yet.
Initialization of $GLOBALS['ESPCONFIG'] happens at the end of php.ini.fixed, so after the part that references esp_setlocale();

As a quick fix I moved the initialization part above the esp_setlocale() calls. As a consequence, all references to the ESPCONFIG array that come after that have to be changed to $GLOBALS['ESPCONFIG']

here's my changed code for php.ini.fixed starting on line 91 till the end of the file:

if (isset($GLOBALS)) {
    $GLOBALS['ESPCONFIG'] = $ESPCONFIG;
} else {
    global $ESPCONFIG;
}

// Load I18N support
require_once($GLOBALS['ESPCONFIG']['include_path'] . '/lib/espi18n' . $GLOBALS['ESPCONFIG']['extension']);
if (isset($_REQUEST['lang'])) { 
   esp_setlocale_ex($_REQUEST['lang']);
   $_SESSION['language']=$_REQUEST['lang'];
} elseif (isset($lang)) {
   esp_setlocale_ex($lang);
   $_SESSION['language']=$lang;
} elseif (isset($_SESSION['language'])) {
   esp_setlocale_ex($_SESSION['language']);
} else {
   esp_setlocale_ex();
}


// default thank you messages
$GLOBALS['ESPCONFIG']['thank_head'] = _('Thank You For Completing This Survey.');
$GLOBALS['ESPCONFIG']['thank_body'] = _('Please do not use the back button on your browser to go
back.');

if (!file_exists($GLOBALS['ESPCONFIG']['include_path']. '/funcs'. $GLOBALS['ESPCONFIG']['extension'])) {
    printf('<b>'. _('Unable to find the phpESP %s directory.
			Please check %s to ensure that all paths are set correctly.') .
			'</b>', 'include', 'phpESP.ini.php');
    exit;
}
if (!file_exists($GLOBALS['ESPCONFIG']['css_path'])) {
    printf('<b>'. _('Unable to find the phpESP %s directory.
			Please check %s to ensure that all paths are set correctly.') .
			'</b>', 'css', 'phpESP.ini.php');
    exit;
}



require_once($GLOBALS['ESPCONFIG']['include_path'].'/funcs'.$GLOBALS['ESPCONFIG']['extension']);

?>


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108956&aid=2897990&group_id=8956

[phpesp-dev] [ phpesp-Bugs-2897816 ] Copying an existing survey does not copy conditions

[SourceForge.net <no...@so...>]

Bugs item #2897816, was opened at 2009-11-14 22:43
Message generated for change (Comment added) made by liedekef
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108956&aid=2897816&group_id=8956

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Admin
Group: 2.1.3
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Arjen van Bochoven (bochoven)
Assigned to: Nobody/Anonymous (nobody)
Summary: Copying an existing survey does not copy conditions 

Initial Comment:
I would like to reopen SFID 2669428, but I can't seem to find a way to do that.

The sql statement in survey_aggregate.inc on line 152 to 165 contains hardcoded tablenames which will fail when used together with prefixed tables:

 // copy conditions
    $sql =<<<EOSQL
INSERT INTO conditions
       (id,  survey_id, q1_id,    q2_id,    cond, cond_value)
SELECT NULL, $new_sid,  qnew1.id, qnew2.id, cond, cond_value
  FROM question qold1, question qold2, question qnew1, question qnew2, conditions c
 WHERE qold1.id=c.q1_id AND qold2.id=c.q2_id AND
       qold1.survey_id=$sid AND qold2.survey_id=$sid AND
       qnew1.survey_id=$new_sid AND qnew1.position=qold1.position AND
       qnew1.deleted=qold1.deleted AND
       qnew2.survey_id=$new_sid AND
       qnew2.position=qold2.position AND
       qnew2.deleted=qold2.deleted
EOSQL;

Arjen

----------------------------------------------------------------------

Comment By: Franky Van Liedekerke (liedekef)
Date: 2009-11-15 00:06

Message:
The latest development code contains the fix, please update to the
development code or wait for an official release.

----------------------------------------------------------------------

Comment By: Arjen van Bochoven (bochoven)
Date: 2009-11-14 23:07

Message:
My proposed fix:

    // copy conditions
    $sql = "
INSERT INTO ".$GLOBALS['ESPCONFIG']['condition_table']."
       (id,  survey_id, q1_id,    q2_id,    cond, cond_value)
SELECT NULL, $new_sid,  qnew1.id, qnew2.id, cond, cond_value
  FROM ".$GLOBALS['ESPCONFIG']['question_table']." qold1, 
		".$GLOBALS['ESPCONFIG']['question_table']." qold2, 
		".$GLOBALS['ESPCONFIG']['question_table']." qnew1,
		".$GLOBALS['ESPCONFIG']['question_table']." qnew2, 
		".$GLOBALS['ESPCONFIG']['condition_table']." c
 WHERE qold1.id=c.q1_id AND qold2.id=c.q2_id AND
       qold1.survey_id=$sid AND qold2.survey_id=$sid AND
       qnew1.survey_id=$new_sid AND qnew1.position=qold1.position AND
       qnew1.deleted=qold1.deleted AND
       qnew2.survey_id=$new_sid AND
       qnew2.position=qold2.position AND
       qnew2.deleted=qold2.deleted
";

Arjen

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108956&aid=2897816&group_id=8956

[phpesp-dev] [ phpesp-Bugs-2897816 ] Copying an existing survey does not copy conditions

[SourceForge.net <no...@so...>]

Bugs item #2897816, was opened at 2009-11-14 22:43
Message generated for change (Comment added) made by bochoven
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108956&aid=2897816&group_id=8956

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Admin
Group: 2.1.3
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Arjen van Bochoven (bochoven)
Assigned to: Nobody/Anonymous (nobody)
Summary: Copying an existing survey does not copy conditions 

Initial Comment:
I would like to reopen SFID 2669428, but I can't seem to find a way to do that.

The sql statement in survey_aggregate.inc on line 152 to 165 contains hardcoded tablenames which will fail when used together with prefixed tables:

 // copy conditions
    $sql =<<<EOSQL
INSERT INTO conditions
       (id,  survey_id, q1_id,    q2_id,    cond, cond_value)
SELECT NULL, $new_sid,  qnew1.id, qnew2.id, cond, cond_value
  FROM question qold1, question qold2, question qnew1, question qnew2, conditions c
 WHERE qold1.id=c.q1_id AND qold2.id=c.q2_id AND
       qold1.survey_id=$sid AND qold2.survey_id=$sid AND
       qnew1.survey_id=$new_sid AND qnew1.position=qold1.position AND
       qnew1.deleted=qold1.deleted AND
       qnew2.survey_id=$new_sid AND
       qnew2.position=qold2.position AND
       qnew2.deleted=qold2.deleted
EOSQL;

Arjen

----------------------------------------------------------------------

>Comment By: Arjen van Bochoven (bochoven)
Date: 2009-11-14 23:07

Message:
My proposed fix:

    // copy conditions
    $sql = "
INSERT INTO ".$GLOBALS['ESPCONFIG']['condition_table']."
       (id,  survey_id, q1_id,    q2_id,    cond, cond_value)
SELECT NULL, $new_sid,  qnew1.id, qnew2.id, cond, cond_value
  FROM ".$GLOBALS['ESPCONFIG']['question_table']." qold1, 
		".$GLOBALS['ESPCONFIG']['question_table']." qold2, 
		".$GLOBALS['ESPCONFIG']['question_table']." qnew1,
		".$GLOBALS['ESPCONFIG']['question_table']." qnew2, 
		".$GLOBALS['ESPCONFIG']['condition_table']." c
 WHERE qold1.id=c.q1_id AND qold2.id=c.q2_id AND
       qold1.survey_id=$sid AND qold2.survey_id=$sid AND
       qnew1.survey_id=$new_sid AND qnew1.position=qold1.position AND
       qnew1.deleted=qold1.deleted AND
       qnew2.survey_id=$new_sid AND
       qnew2.position=qold2.position AND
       qnew2.deleted=qold2.deleted
";

Arjen

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108956&aid=2897816&group_id=8956

[phpesp-dev] [ phpesp-Bugs-2897816 ] Copying an existing survey does not copy conditions

[SourceForge.net <no...@so...>]

Bugs item #2897816, was opened at 2009-11-14 22:43
Message generated for change (Tracker Item Submitted) made by bochoven
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108956&aid=2897816&group_id=8956

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Admin
Group: 2.1.3
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Arjen van Bochoven (bochoven)
Assigned to: Nobody/Anonymous (nobody)
Summary: Copying an existing survey does not copy conditions 

Initial Comment:
I would like to reopen SFID 2669428, but I can't seem to find a way to do that.

The sql statement in survey_aggregate.inc on line 152 to 165 contains hardcoded tablenames which will fail when used together with prefixed tables:

 // copy conditions
    $sql =<<<EOSQL
INSERT INTO conditions
       (id,  survey_id, q1_id,    q2_id,    cond, cond_value)
SELECT NULL, $new_sid,  qnew1.id, qnew2.id, cond, cond_value
  FROM question qold1, question qold2, question qnew1, question qnew2, conditions c
 WHERE qold1.id=c.q1_id AND qold2.id=c.q2_id AND
       qold1.survey_id=$sid AND qold2.survey_id=$sid AND
       qnew1.survey_id=$new_sid AND qnew1.position=qold1.position AND
       qnew1.deleted=qold1.deleted AND
       qnew2.survey_id=$new_sid AND
       qnew2.position=qold2.position AND
       qnew2.deleted=qold2.deleted
EOSQL;

Arjen

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108956&aid=2897816&group_id=8956

[phpesp-dev] [ phpesp-Bugs-1998323 ] Survey Hangs when 0 entered for Numeric Required

[SourceForge.net <no...@so...>]

Bugs item #1998323, was opened at 2008-06-19 19:18
Message generated for change (Comment added) made by bishopb
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108956&aid=1998323&group_id=8956

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: User
Group: None
Status: Closed
Resolution: Fixed
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Franky Van Liedekerke (liedekef)
Summary: Survey Hangs when 0 entered for Numeric Required

Initial Comment:
Version: 2.1.1

When a user enters 0 (zero) for a field defined as a numeric and required field, the survey hangs until PHP max execution time is reached.



----------------------------------------------------------------------

>Comment By: bishop (bishopb)
Date: 2009-11-06 07:28

Message:
@mlven:

Yes, the bug report was filed for version 2.1.1 (see initial comment).  It
was, therefore, fixed in releases 2.1.2 and later.  Are you reporting that
it occurs in a version later than 2.1.1?

----------------------------------------------------------------------

Comment By: M V (mlven)
Date: 2009-11-06 07:16

Message:
This same error is occurring in release 2.1.1

----------------------------------------------------------------------

Comment By: Franky Van Liedekerke (liedekef)
Date: 2008-06-28 07:25

Message:
Logged In: YES 
user_id=109671
Originator: NO

Problem solved and fix commited to svn. If you want to fix it yourself,
check the svn differences for admin/include/lib/espresponse.inc (just one
line).

Franky

----------------------------------------------------------------------

Comment By: Franky Van Liedekerke (liedekef)
Date: 2008-06-28 07:19

Message:
Logged In: YES 
user_id=109671
Originator: NO

Bug confirmed, working on it.

Franky

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108956&aid=1998323&group_id=8956

[phpesp-dev] [ phpesp-Bugs-1998323 ] Survey Hangs when 0 entered for Numeric Required

[SourceForge.net <no...@so...>]

Bugs item #1998323, was opened at 2008-06-19 19:18
Message generated for change (Comment added) made by mlven
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108956&aid=1998323&group_id=8956

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: User
Group: None
Status: Closed
Resolution: Fixed
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Franky Van Liedekerke (liedekef)
Summary: Survey Hangs when 0 entered for Numeric Required

Initial Comment:
Version: 2.1.1

When a user enters 0 (zero) for a field defined as a numeric and required field, the survey hangs until PHP max execution time is reached.



----------------------------------------------------------------------

Comment By: M V (mlven)
Date: 2009-11-06 07:16

Message:
This same error is occurring in release 2.1.1

----------------------------------------------------------------------

Comment By: Franky Van Liedekerke (liedekef)
Date: 2008-06-28 07:25

Message:
Logged In: YES 
user_id=109671
Originator: NO

Problem solved and fix commited to svn. If you want to fix it yourself,
check the svn differences for admin/include/lib/espresponse.inc (just one
line).

Franky

----------------------------------------------------------------------

Comment By: Franky Van Liedekerke (liedekef)
Date: 2008-06-28 07:19

Message:
Logged In: YES 
user_id=109671
Originator: NO

Bug confirmed, working on it.

Franky

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108956&aid=1998323&group_id=8956

[phpesp-dev] [ phpesp-Bugs-2884726 ] http 503 Service Unavailable [ Connection to database failed

[SourceForge.net <no...@so...>]

Bugs item #2884726, was opened at 2009-10-23 10:25
Message generated for change (Comment added) made by bishopb
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108956&aid=2884726&group_id=8956

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Closed
Resolution: Invalid
Priority: 5
Private: No
Submitted By: Saffron  (saffronangeliq)
Assigned to: Nobody/Anonymous (nobody)
Summary: http 503 Service Unavailable [ Connection to database failed

Initial Comment:
v2.1.1
I haven't been able to see a consistency on the appearance of this error message, I do not always see it.
I made a survey, edited it,  saw this message, but was able to get around it by going back, then I put the survey in test mode, tested fine and received results
tried to use the link produced for public use/respondants and I get that error, I also randomly get this error at all other intervals working with the survey editor and management interface. is this phpesp or is this my server and/or db?

----------------------------------------------------------------------

>Comment By: bishop (bishopb)
Date: 2009-10-23 16:52

Message:
Also, try upgrading to the latest version of phpESP.

----------------------------------------------------------------------

Comment By: bishop (bishopb)
Date: 2009-10-23 16:51

Message:
Thank you for the report, but I'm inclined to think this is not a phpESP
bug, as it's a connection to the database problem which is handled by
layers outside phpESP.

I suggest checking the number of threads connecting to your database and
ensure that the maximum hasn't been reached.  If not a connection to
database issue, it could be a server issue (eg too many files open), which
has an upstream impact on the database server.

Check those out and if you can absolutely eliminate those at not the
source of problem, we can reopen this case (I've left comment posting on).

----------------------------------------------------------------------

Comment By: Saffron  (saffronangeliq)
Date: 2009-10-23 10:29

Message:
?where=manage   

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108956&aid=2884726&group_id=8956

[phpesp-dev] [ phpesp-Bugs-2884726 ] http 503 Service Unavailable [ Connection to database failed

[SourceForge.net <no...@so...>]

Bugs item #2884726, was opened at 2009-10-23 10:25
Message generated for change (Comment added) made by bishopb
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108956&aid=2884726&group_id=8956

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Invalid
Priority: 5
Private: No
Submitted By: Saffron  (saffronangeliq)
Assigned to: Nobody/Anonymous (nobody)
Summary: http 503 Service Unavailable [ Connection to database failed

Initial Comment:
v2.1.1
I haven't been able to see a consistency on the appearance of this error message, I do not always see it.
I made a survey, edited it,  saw this message, but was able to get around it by going back, then I put the survey in test mode, tested fine and received results
tried to use the link produced for public use/respondants and I get that error, I also randomly get this error at all other intervals working with the survey editor and management interface. is this phpesp or is this my server and/or db?

----------------------------------------------------------------------

>Comment By: bishop (bishopb)
Date: 2009-10-23 16:51

Message:
Thank you for the report, but I'm inclined to think this is not a phpESP
bug, as it's a connection to the database problem which is handled by
layers outside phpESP.

I suggest checking the number of threads connecting to your database and
ensure that the maximum hasn't been reached.  If not a connection to
database issue, it could be a server issue (eg too many files open), which
has an upstream impact on the database server.

Check those out and if you can absolutely eliminate those at not the
source of problem, we can reopen this case (I've left comment posting on).

----------------------------------------------------------------------

Comment By: Saffron  (saffronangeliq)
Date: 2009-10-23 10:29

Message:
?where=manage   

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108956&aid=2884726&group_id=8956

[phpesp-dev] [ phpesp-Bugs-2884726 ] http 503 Service Unavailable [ Connection to database failed

[SourceForge.net <no...@so...>]

Bugs item #2884726, was opened at 2009-10-23 09:25
Message generated for change (Comment added) made by saffronangeliq
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108956&aid=2884726&group_id=8956

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Saffron  (saffronangeliq)
Assigned to: Nobody/Anonymous (nobody)
Summary: http 503 Service Unavailable [ Connection to database failed

Initial Comment:
v2.1.1
I haven't been able to see a consistency on the appearance of this error message, I do not always see it.
I made a survey, edited it,  saw this message, but was able to get around it by going back, then I put the survey in test mode, tested fine and received results
tried to use the link produced for public use/respondants and I get that error, I also randomly get this error at all other intervals working with the survey editor and management interface. is this phpesp or is this my server and/or db?

----------------------------------------------------------------------

>Comment By: Saffron  (saffronangeliq)
Date: 2009-10-23 09:29

Message:
?where=manage   

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108956&aid=2884726&group_id=8956

[phpesp-dev] [ phpesp-Bugs-2884726 ] http 503 Service Unavailable [ Connection to database failed

[SourceForge.net <no...@so...>]

Bugs item #2884726, was opened at 2009-10-23 09:25
Message generated for change (Tracker Item Submitted) made by saffronangeliq
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108956&aid=2884726&group_id=8956

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Saffron  (saffronangeliq)
Assigned to: Nobody/Anonymous (nobody)
Summary: http 503 Service Unavailable [ Connection to database failed

Initial Comment:
v2.1.1
I haven't been able to see a consistency on the appearance of this error message, I do not always see it.
I made a survey, edited it,  saw this message, but was able to get around it by going back, then I put the survey in test mode, tested fine and received results
tried to use the link produced for public use/respondants and I get that error, I also randomly get this error at all other intervals working with the survey editor and management interface. is this phpesp or is this my server and/or db?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=108956&aid=2884726&group_id=8956

[phpesp-dev] [ phpesp-Feature Requests-2170859 ] code for survey continue, without email (keeping anonymity)

[SourceForge.net <no...@so...>]

Feature Requests item #2170859, was opened at 2008-10-16 09:45
Message generated for change (Comment added) made by liedekef
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=358956&aid=2170859&group_id=8956

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: gui
Group: None
Status: Open
Priority: 5
Private: No
Submitted By: Jurgis Pralgauskis (dz0)
Assigned to: Nobody/Anonymous (nobody)
Summary: code for survey continue, without email (keeping anonymity)

Initial Comment:
in long surveys  people get bored and tend to drop answering...

could there be a temporary pseudologin function?

on closing unifinished window, a dialog would appear proposing the pseudologincode

that  can be entered later to continue the survey.. 
the respond could optionally enter his own code to be easier to remember... 

more about this issue http://www.limesurvey.org/index.php/Can-I-do-this-with-LimeSurvey-/20024-anonymous-with-GeneratedCode-to-let-continue-later.html

----------------------------------------------------------------------

>Comment By: Franky Van Liedekerke (liedekef)
Date: 2009-09-23 11:03

Message:
How about a php-script at the beginning of the survey, that creates a user
for eg. 3 days, gives that info to the person taking the survey and then
autologin the user? It's not something I'm going to write now, but seems
very easy to do.

Franky

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=358956&aid=2170859&group_id=8956

[phpesp-dev] [ phpesp-Feature Requests-2771716 ] Allow possible answers to have associated "credit"

[SourceForge.net <no...@so...>]

Feature Requests item #2771716, was opened at 2009-04-18 03:08
Message generated for change (Comment added) made by liedekef
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=358956&aid=2771716&group_id=8956

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: survey format
Group: None
Status: Closed
Priority: 5
Private: No
Submitted By: bishop (bishopb)
Assigned to: bishop (bishopb)
Summary: Allow possible answers to have associated "credit"

Initial Comment:
The core of phpESP functionality is "ask question, record answer."  This
functionality applies to surveys ("tell me your opinion") and to
examinations ("tell me what you know").

However, examinations get graded, which means each possible answer contributes
numerically to an overall score.  For example, say you have a 20 question exam
with a 100 point scale.  Each question is worth 5 points.  Some questions may
have a strictly right answer (credit=5), while the rest are strictly wrong
(credit=0).  Other questions may have strictly right, partially right
(credit=4, 3, 2, or 1), and strictly wrong answers.  The survey designer makes
these decisions when creating their examination.

The scope of this feature request is to add a "credit" value for each possible
answer in a question supporting possible answers (Yes/No, Radio, Checkbox,
Rate, etc.)  This would be added as an additional column in the answer matrix
on the question definition of the survey creator.  For every answer entry box,
there would be an entry box into which a number may be entered.  This is the
response "credit".  For example:

    LABEL                     CREDIT
 1. [_____________________]   [____]
 2. [_____________________]   [____]
 3. [_____________________]   [____]
 4. [_____________________]   [____]
 5. [_____________________]   [____]
 6. [_____________________]   [____]
 7. [_____________________]   [____]
 8. [_____________________]   [____]
 9. [_____________________]   [____]
10. [_____________________]   [____]


The "possible score" is the sum of the all maximum possible response credits.
For example, 20 questions, each with a maximum credit of 5, yields a "possible
score" of 100.  Since the "possible score" is constant, it should be computed
and stored in the survey definition.

For a completed survey, the "score" is the sum of all specific response's credit.
For example, 20 questions, each with a maximum credit of 5, all strictly
right/strictly wrong questions, missing one would yield a "score" of 95.
Since this is constant once the response is marked as complete, store this in the
response definition.

Allow the admin to enter any numeric value, including negative and floating
point numbers.  (Because we cannot predict exotic uses, we should be
maximally flexible.)  Deny any value that is not numeric.  Any question
without credits, or any question that does not make use of possible
answers, contributes nothing (that is, 0) to the score and possible score.

Show the score on the "thank you" page after completing a survey, as
"Score: N out of M (P%)".  For example, "Score 95 out of 100 (95%)".

Also show the score on the "Navigate Individual Respondent Submissions" page,
at the top of the page, in the same format as for the thank you page.

----------------------------------------------------------------------

>Comment By: Franky Van Liedekerke (liedekef)
Date: 2009-09-23 10:56

Message:
I disagree on expnding this further. Using a survey software for
examinations is getting a bit too far for me, there's better software
available for that, eg: tcexam (http://www.tcexam.com/)

Franky

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2009-09-23 05:26

Message:
I'm interested.  If you are going down this route, then have you considered
adding QTI XML 2.0 Support (http://www.imsglobal.org/question/) which would
allow instructors to import question databases provided by 3rd parties or
to author their questions in desktop software such as "Respondus"
(http://www.respondus.com/products/respondus.shtml).

QTI's xml formats are well documented and well thought out covering many
instructional question formats that are useful to all levels of education,
including multiple choice, ordering, matching, gap matching, inline choice,
text entry, hottext, hotspot, slider, etc.

Many of these formats would also work as survey formats, such as slider as
an alternate to Likert style questions (i.e. 1= Agree 3 = neutral
5=Disagree).  Even ordering for a questions like "If stranded on a desert
island, put these items in the order from most important to least important
for survival" would be great.

----------------------------------------------------------------------

Comment By: bishop (bishopb)
Date: 2009-05-29 20:59

Message:
Thanks Franky!

i'd like to note that the implementation differs from the requirements
above, as follows:
1. The score is not cached in the response.
2. The respondent's score is not shown on the thank you page; however, the
score is shown on each summary page, along with any feedback.
3. The score is not shown on the "Navigate Individual Respondent
Submissions".
4. There is no concept of "total possible score".

I decided not to implement these "admin" type features until further use
cases present themselves.  For example, instead of computing the total
possible score as the sum of all credit, it may make sense to allow the
admin to enter the total possible score on the survey definition page.

Since there isn't any voting capability in SourceForge (AFAIK), anyone
wishing to see particular functionality please comment in this ticket.

----------------------------------------------------------------------

Comment By: Franky Van Liedekerke (liedekef)
Date: 2009-05-28 23:04

Message:
nice work!

Franky

----------------------------------------------------------------------

Comment By: bishop (bishopb)
Date: 2009-05-28 20:55

Message:
I have committed this to SVN. It will be publically available in the next
release; anyone wanting a preview now should export the phpesp trunk.

----------------------------------------------------------------------

Comment By: bishop (bishopb)
Date: 2009-05-28 16:45

Message:
Revised design: only question types of radio buttons, check boxes, and
dropdown box will be able to assign credit to possible answers.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=358956&aid=2771716&group_id=8956

[phpesp-dev] [ phpesp-Feature Requests-2072351 ] Labels for ratings grid

[SourceForge.net <no...@so...>]

Feature Requests item #2072351, was opened at 2008-08-25 00:24
Message generated for change (Comment added) made by liedekef
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=358956&aid=2072351&group_id=8956

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: gui
Group: None
Status: Open
Priority: 5
Private: No
Submitted By: Sam Karpluk (skarpluk)
Assigned to: Nobody/Anonymous (nobody)
Summary: Labels for ratings grid

Initial Comment:
I think it would be a good addition to optionally apply labels to the rating grid options. Right now they are numbered 1...n, so you can have a scale of, say, 1, 2, 3, 4, 5 as your headings on the grid. I think it would be useful to label these, such as Strongly Disagree(1), Disagree(2), Neutral(3), Agree(4), Strongly Agree(5).

 

----------------------------------------------------------------------

>Comment By: Franky Van Liedekerke (liedekef)
Date: 2009-09-23 10:48

Message:
There's now a patch for this, but not complete ...

----------------------------------------------------------------------

Comment By: Jim Brown (jimbysf)
Date: 2009-08-29 10:54

Message:
I have some code that does this. I'll post it as a patch.  Be aware that it
performs well on the back-end (i.e. survey display, and input) but there is
no support for adding labels in the management GUI.  

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=358956&aid=2072351&group_id=8956