Re: [phpBT-dev] Patches for phpBT 1.0

[Benjamin C. <php...@be...>]

With all the patches flying in to HEAD (thanks!) should we go for a
1.1 release (which would include all the patches) rather than a 1.0.1
(which would just include bug fixes)?


On Aug 29, 2005, at 12:50 PM, Ulf Erikson wrote:

> * Ulf Erikson [2005-08-29 21:42]:
>
>> Could you please look at the attached patch for inclusion in the  
>> 1.0 branch?
>>
>
> Almost forgot.. when updating the various schemas I also found two  
> faults in the old Oracle support.
>
>  1) There are two syntax errors in inc/db/oci8.php
>  2) There is no EditAssignment permission in schemas/oci8.in
>
> /Ulf
> Index: schemas/oci8.in
> ===================================================================
> RCS file: /cvsroot/phpbt/phpbt/schemas/oci8.in,v
> retrieving revision 1.28
> diff -u -w -r1.28 oci8.in
> --- schemas/oci8.in    20 Jun 2005 01:05:29 -0000    1.28
> +++ schemas/oci8.in    29 Aug 2005 19:49:27 -0000
> @@ -297,6 +297,7 @@
>  -- ... and only two permissions
>  INSERT INTO TBL_AUTH_PERM (perm_id, perm_name) VALUES (1, 'Admin');
>  INSERT INTO TBL_AUTH_PERM (perm_id, perm_name) VALUES (2, 'Editbug');
> +INSERT INTO TBL_AUTH_PERM (perm_id, perm_name) VALUES (3,  
> 'EditAssignment');
>
>  -- Admins can do all the admin stuff and users can edit bugs
>  INSERT INTO TBL_GROUP_PERM (group_id, perm_id) VALUES (1, 1);
> Index: inc/db/oci8.php
> ===================================================================
> RCS file: /cvsroot/phpbt/phpbt/inc/db/oci8.php,v
> retrieving revision 1.18
> diff -u -w -r1.18 oci8.php
> --- inc/db/oci8.php    30 May 2005 19:59:35 -0000    1.18
> +++ inc/db/oci8.php    29 Aug 2005 19:49:27 -0000
> @@ -115,11 +115,11 @@
>          'where p.project_id = pg.project_id(+) and active = 1 '.
>          'and (pg.project_id is null or pg.group_id in (%s)) '.
>          'group by p.project_id, p.project_name order by  
> project_name',
> -    'include-template-owner' => SELECT sum(decode( s.status_id in  
> (".OPEN_BUG_STATUSES.") , 1, 1, 0 )), ".
> +    'include-template-owner' => "SELECT sum(decode( s.status_id in  
> (".OPEN_BUG_STATUSES.") , 1, 1, 0 )), ".
>          "sum(decode( s.status_id not in (".OPEN_BUG_STATUSES.") ,  
> 1, 1, 0 )), ".
>          'from '.TBL_BUG.' b, '.TBL_STATUS.' s '.
>          'where  b.status_id = s.status_id (+) and b.assigned_to = % 
> s',
> -    'include-template-reporter' => SELECT sum(decode( s.status_id  
> in (".OPEN_BUG_STATUSES.") , 1, 1, 0 )) , ".
> +    'include-template-reporter' => "SELECT sum(decode( s.status_id  
> in (".OPEN_BUG_STATUSES.") , 1, 1, 0 )) , ".
>          "sum(decode( s.status_id not in (".OPEN_BUG_STATUSES.") ,  
> 1, 1, 0 )) ".
>          'from '.TBL_BUG.' b, ' . TBL_STATUS.' s '.
>          'where  b.status_id = s.status_id (+) and b.created_by = %s',
>