|
From: Ulf E. <ulf...@fa...> - 2005-02-10 19:24:37
|
Hoi Ben, I have gather a few thoughts and comments from the last week.. Permission is checked in several different ways: $perm->have_*, $perm->is_*, $perm->in_*, $perm->check_* The check_* functions often, but not always, show an error page if the permission is not granted. The other functions return a boolean. Will you please take a look at this and make it more consistent to make things easier to understand? The permission bits checked for are not always the correct ones: Manager, Administrator, Users Since the "Admin" bit automatically grants permission to everything are those functions still available. Please check again what requirements you had intended at those points. The User group is somewhat "magic". Everyone is included be default, and it never shows up in the administrator tools. Could this (that it doesn't show up) please be changed? It "breaks" the group editor somewhat that the User group is missing, and since a Developer has all permissions a User has is there no need to be member of both.. From admin/user.php: // Get user's groups (without dropping the user group) $user_groups = $db->getCol(sprintf($QUERY['admin-user-groups'], $userid)); but 'admin-user-group' DOES drop the user group. It shouldn't. (i think things went wrong when not everyone is a "User", or maybe even before) There is no error.html in the templates/admin/ directory. This is needed when/if something goes wrong with the database queries (which it at least does when i play with trial-and-error). Could this please be added? -- Ulf |