|
From: Benjamin C. <bc...@us...> - 2001-12-19 13:38:06
|
Update of /cvsroot/phpbt/phpbt
In directory usw-pr-cvs1:/tmp/cvs-serv19853
Modified Files:
bug.php
Log Message:
Call-time pass by reference is deprecated -- fixes bug #494267
Index: bug.php
===================================================================
RCS file: /cvsroot/phpbt/phpbt/bug.php,v
retrieving revision 1.68
retrieving revision 1.69
diff -u -r1.68 -r1.69
--- bug.php 2001/12/12 14:42:57 1.68
+++ bug.php 2001/12/19 13:33:14 1.69
@@ -79,7 +79,7 @@
///
/// Send the email about changes to the bug and log the changes in the DB
-function do_changedfields($userid, $buginfo, $cf = array(), $comments = '') {
+function do_changedfields($userid, &$buginfo, $cf = array(), $comments = '') {
global $q, $t, $u, $select, $now, $STRING;
// It's a new bug if the changedfields array is empty and there are no comments
@@ -360,7 +360,7 @@
$q->query("update ".TBL_BUG." set title = '$title', url = '$url', severity_id = $severity_id, priority = $priority, ".(isset($status_id) ? "status_id = $status_id, " : ''). ($changeresolution ? "resolution_id = $resolution_id, " : ''). (isset($assignedto) ? "assigned_to = $assignedto, " : '')." project_id = $project_id, version_id = $version_id, component_id = $component_id, os_id = $os_id, last_modified_by = $u, last_modified_date = $now where bug_id = $bugid");
if (count($changedfields) or !empty($comments)) {
- do_changedfields($u, &$buginfo, $changedfields, $comments);
+ do_changedfields($u, $buginfo, $changedfields, $comments);
}
header("Location: bug.php?op=show&bugid=$bugid&pos=$pos");
}
@@ -405,7 +405,7 @@
$now, $u, $now, $project, $version, $component, '$os',
'{$GLOBALS['HTTP_USER_AGENT']}')");
$buginfo = $q->grab('select * from '.TBL_BUG." where bug_id = $bugid");
- do_changedfields($u, &$buginfo);
+ do_changedfields($u, $buginfo);
} else {
$q->query("update ".TBL_BUG." set title = '$title', description = '$description', url = '$url', severity_id = '$severity', priority = '$priority', status_id = $status, assigned_to = '$assignedto', project_id = $project, version_id = $version, component_id = $component, os_id = '$os', browser_string = '{$GLOBALS['HTTP_USER_AGENT']}' last_modified_by = $u, last_modified_date = $time where bug_id = '$bugid'");
}
|