Re: [phpBT-dev] Coding Standards

[Patrick M. <mai...@st...>]

> Well, grep does let you display lines after the match -- but how many should I specify when grepping?  Two, four?  Some queries are only one line -- some are four.  I don't want non-query lines when grepping for queries, and I certainly don't want to cut off part of one.

right, but it's a thing I could live with.

> Looking at query.php, even the queries that are wrapped don't abide an 80 character limit -- most lines are still going past 80 columns.  So, indenting here did little to improve editing in a terminal editor.  Additionally, the indenting is not consistent and looks rather haphazard.  If we are going to break-up and indent queries, I at least want them to look consistent and strictly abide the 80 column limit (as the rest of the code should).

I agree. when I splitted the queries, it was just to make them
readable and understandable for me. making it in a consistant manner
would be better. I usually split befor 'from', 'where', 'left join', 'and', 'group',
'order', 'having' and where lines just are too long.

-- 
http://home.nikocity.de/mairif
http://caravan-network.de
ICQ# 96716515