[Phpbb-checkins] CVS: phpBB2 viewonline.php,1.47,1.48

[Paul S. O. <ps...@us...>]

Update of /cvsroot/phpbb/phpBB2
In directory usw-pr-cvs1:/tmp/cvs-serv25076

Modified Files:
	viewonline.php 
Log Message:
Ignore duplicate IP's for guest counts ... keep in mind this swings 100% the other way from keeping them all, you'll not count some users.

Index: viewonline.php
===================================================================
RCS file: /cvsroot/phpbb/phpBB2/viewonline.php,v
retrieving revision 1.47
retrieving revision 1.48
diff -C2 -r1.47 -r1.48
*** viewonline.php	14 Feb 2002 02:22:42 -0000	1.47
--- viewonline.php	1 Mar 2002 16:39:56 -0000	1.48
***************
*** 94,103 ****
  // Get user list
  //
! $sql = "SELECT u.user_id, u.username, u.user_session_time, u.user_session_page, u.user_allow_viewonline, u.user_level, s.session_logged_in, s.session_time, s.session_page  
  	FROM " . USERS_TABLE . " u, " . SESSIONS_TABLE . " s
  	WHERE u.user_id = s.session_user_id 
  		AND ( u.user_session_time >= " . ( time() - 300 ) . " 
  			OR s.session_time >= " . ( time() - 300 ) . " )  
! 	ORDER BY u.username ASC, u.user_session_time DESC, s.session_time DESC";
  if ( !($result = $db->sql_query($sql)) )
  {
--- 94,103 ----
  // Get user list
  //
! $sql = "SELECT u.user_id, u.username, u.user_session_time, u.user_session_page, u.user_allow_viewonline, u.user_level, s.session_logged_in, s.session_time, s.session_page, s.session_ip 
  	FROM " . USERS_TABLE . " u, " . SESSIONS_TABLE . " s
  	WHERE u.user_id = s.session_user_id 
  		AND ( u.user_session_time >= " . ( time() - 300 ) . " 
  			OR s.session_time >= " . ( time() - 300 ) . " )  
! 	ORDER BY u.username ASC, s.session_ip";
  if ( !($result = $db->sql_query($sql)) )
  {
***************
*** 114,117 ****
--- 114,118 ----
  	$guest_counter = 0;
  	$prev_user = 0;
+ 	$prev_ip = 0;
  
  	do
***************
*** 160,172 ****
  		else
  		{
! 			$view_online = 1;
! 			$guest_users++;
! 	
! 			$username = $lang['Guest'];
! 			$last_update = $row['session_time'];
! 			$user_page = $row['session_page'];
  
! 			$which_counter = 'guest_counter';
! 			$which_row = 'guest_user_row';
  		}
  
--- 161,178 ----
  		else
  		{
! 			if ( $row['session_ip'] != $prev_ip )
! 			{
! 				$view_online = 1;
! 				$guest_users++;
! 		
! 				$username = $lang['Guest'];
! 				$last_update = $row['session_time'];
! 				$user_page = $row['session_page'];
! 
! 				$which_counter = 'guest_counter';
! 				$which_row = 'guest_user_row';
  
! 				$prev_ip = $row['session_ip'];
! 			}
  		}