Menu

#14 Missing error handling, incorrect config parsing

open-accepted
nobody
5
2009-05-15
2008-07-07
jbtibor
No

If config file has windows newlines, API key will be incorrect (it has %0D appended).
In this case flickr returns error 100, Invalid API Key (Key not found). However, this error is not handled by Request.execute method, empty string is returned.

How to reproduce: create a config file with windows new line after api key.

Discussion

  • jbtibor

    jbtibor - 2009-02-14
    • summary: Missing error handling --> Missing error handling, incorrect config parsing
     
  • jbtibor

    jbtibor - 2009-02-14
     
  • jbtibor

    jbtibor - 2009-02-14

    I'm not sure if this is the right fix: Api.php.patch.
    File Added: Api.php.patch

     
  • Graham Christensen

    Patch works, implemented in #542.

     
  • Graham Christensen

    • status: open --> closed-fixed
     
  • Graham Christensen

    My mistake - the error is not handle, however the %0D is. Changed to Open and Accepted.

     
  • Graham Christensen

    • status: closed-fixed --> open-accepted
     

Log in to post a comment.

MongoDB Logo MongoDB