[Pgsqlformac-commits] pgCocoaDB ChangeLog, 1.16, 1.17 Connection.m, 1.13, 1.14 ExplorerModel.m, 1.11, 1.12 Schema.m, 1.18, 1.19

[Neil T. <nt...@us...>]

Update of /cvsroot/pgsqlformac/pgCocoaDB
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv28029

Modified Files:
	ChangeLog Connection.m ExplorerModel.m Schema.m 
Log Message:
Add some comments and reformat functions.

Index: Schema.m
===================================================================
RCS file: /cvsroot/pgsqlformac/pgCocoaDB/Schema.m,v
retrieving revision 1.18
retrieving revision 1.19
diff -C2 -d -r1.18 -r1.19
*** Schema.m	19 Aug 2006 12:06:48 -0000	1.18
--- Schema.m	26 Aug 2006 12:25:33 -0000	1.19
***************
*** 40,44 ****
  		// TODO not found raise error?
  
! 		NSLog(@"Did not find PostgreSQL version 8.1");
  		NSLog(sql);
  		NSLog(pgVersionFound);
--- 40,44 ----
  		// TODO not found raise error?
  
! 		NSLog(@"Did not find PostgreSQL version 8.1: %@", pgVersionFound);
  		NSLog(sql);
  		NSLog(pgVersionFound);

Index: Connection.m
===================================================================
RCS file: /cvsroot/pgsqlformac/pgCocoaDB/Connection.m,v
retrieving revision 1.13
retrieving revision 1.14
diff -C2 -d -r1.13 -r1.14
*** Connection.m	12 Aug 2006 16:38:16 -0000	1.13
--- Connection.m	26 Aug 2006 12:25:33 -0000	1.14
***************
*** 93,100 ****
      }
  	
  	if (errorDescription)
  		[errorDescription release];
! 	errorDescription = nil;
! 	
  	// set up notification
  	PQsetNoticeProcessor(pgconn, handle_pq_notice, self);
--- 93,106 ----
      }
  	
+ 	// TODO if good connection should we remove password from memory
+ 	//	or should it be encrypted?
+ 	
+ 	// TODO password should be asked for in dialog used and then erased?
+ 	
  	if (errorDescription)
+ 	{
  		[errorDescription release];
! 		errorDescription = nil;
! 	}
  	// set up notification
  	PQsetNoticeProcessor(pgconn, handle_pq_notice, self);

Index: ExplorerModel.m
===================================================================
RCS file: /cvsroot/pgsqlformac/pgCocoaDB/ExplorerModel.m,v
retrieving revision 1.11
retrieving revision 1.12
diff -C2 -d -r1.11 -r1.12
*** ExplorerModel.m	19 Aug 2006 12:06:48 -0000	1.11
--- ExplorerModel.m	26 Aug 2006 12:25:33 -0000	1.12
***************
*** 134,138 ****
  		[self createColumnNodes:newNode fromSchemaName:schemaName fromTableName:viewName];
  
! 		// TODO get indexes and other ??
  		[aParent addChild:newNode];
  
--- 134,138 ----
  		[self createColumnNodes:newNode fromSchemaName:schemaName fromTableName:viewName];
  
! 		// TODO get indexes and other for views?
  		[aParent addChild:newNode];
  
***************
*** 257,261 ****
  		[newNode setBaseTable:tableName];
  		[newNode setBaseSchema:schemaName];
- 		// TODO this should only display column names.
  		[newNode setDisplayColumn2:[schema getIndexSQLFromSchema:schemaName fromTableName:tableName fromIndexName:indexName]];
  		[titleNode addChild:newNode];
--- 257,260 ----
***************
*** 324,327 ****
--- 323,327 ----
  	[super init];
  	
+ 	// TODO clone this connection so we can multi-thread
  	connection = theConnection;
  	schema = [[Schema alloc] initWithConnection:connection];

Index: ChangeLog
===================================================================
RCS file: /cvsroot/pgsqlformac/pgCocoaDB/ChangeLog,v
retrieving revision 1.16
retrieving revision 1.17
diff -C2 -d -r1.16 -r1.17
*** ChangeLog	19 Aug 2006 12:06:48 -0000	1.16
--- ChangeLog	26 Aug 2006 12:25:33 -0000	1.17
***************
*** 1,2 ****
--- 1,8 ----
+ 2006-08-19 07:06  ntiffin
+ 
+ 	* ChangeLog, ExplorerModel.m, Schema.h, Schema.m,
+ 	  UnitTest/pgCocoaDBSchemaTest.m: Add display of index column
+ 	  names.
+ 
  2006-08-13 18:50  ntiffin