[Pgsqlformac-commits] QueryTool ChangeLog, 1.11, 1.12 SqlDocument.m, 1.17, 1.18 TODO.txt, 1.5, 1.6

[Neil T. <nt...@us...>]

Update of /cvsroot/pgsqlformac/QueryTool
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv29417

Modified Files:
	ChangeLog SqlDocument.m TODO.txt 
Log Message:
Fix bug associated with releaseing explorer too early.

Index: SqlDocument.m
===================================================================
RCS file: /cvsroot/pgsqlformac/QueryTool/SqlDocument.m,v
retrieving revision 1.17
retrieving revision 1.18
diff -C2 -d -r1.17 -r1.18
*** SqlDocument.m	12 Aug 2006 16:39:04 -0000	1.17
--- SqlDocument.m	13 Aug 2006 23:54:30 -0000	1.18
***************
*** 168,178 ****
  -(void)setNewExplorerConn
  {
! 	// create the schema explorer
! 	[explorer release];
  	explorer =[[ExplorerModel alloc] initWithConnection: conn];
- 	[schemaView setDataSource:explorer]; // explorer does the work.
- 	[schemaView setMenuActionTarget:self];
- 	//[explorer printLog];
- 
  	// set explorer display defaults from NSUserDefaults
  	NSUserDefaults * userDefaults = [NSUserDefaults standardUserDefaults];
--- 168,177 ----
  -(void)setNewExplorerConn
  {
! 	ExplorerModel *newExplorer = [[ExplorerModel alloc] initRebuilding];
! 	[schemaView setDataSource:newExplorer];
! 	[explorer autorelease];
! 	
! 	// change the schema explorer
  	explorer =[[ExplorerModel alloc] initWithConnection: conn];
  	// set explorer display defaults from NSUserDefaults
  	NSUserDefaults * userDefaults = [NSUserDefaults standardUserDefaults];
***************
*** 181,184 ****
--- 180,189 ----
  	[explorer setShowPGToast:[userDefaults  boolForKey:@"PGSqlForMac_QueryTool_ShowPGToastSchema"]];
  	[explorer setShowPGTemps:[userDefaults  boolForKey:@"PGSqlForMac_QueryTool_ShowPGTempsSchema"]];
+ 
+ 	[explorer buildSchema];
+ 	[schemaView setDataSource:explorer]; // explorer does the work.
+ 	[schemaView setMenuActionTarget:self];
+ 	[newExplorer autorelease];
+ 	//[explorer printLog];
  }	
  

Index: TODO.txt
===================================================================
RCS file: /cvsroot/pgsqlformac/QueryTool/TODO.txt,v
retrieving revision 1.5
retrieving revision 1.6
diff -C2 -d -r1.5 -r1.6
*** TODO.txt	16 Jul 2006 23:17:39 -0000	1.5
--- TODO.txt	13 Aug 2006 23:54:30 -0000	1.6
***************
*** 12,16 ****
--- 12,18 ----
  - 2006-06-24 Add command to clear SQL Log.
  
+ - 2006-08-13 SQL Log does not contain enough information.
  
+ - 2006-08-13 Move Schema reading to another thread.  Make it load in parallel.
  
  FIXME (Known Errors)
***************
*** 22,25 ****
--- 24,31 ----
  Completed
  =========
+ - 2006-08-13 Fix bug with incorrect release of explorer whil display was still using it.
+ 
+ - 2006-08-13 Restructure ExplorerModel initWithConnection to respect display user defaults (ie setShowPGCatalog).
+ 
  - 2006-07-16 Fix TODO for autoincrementing index names
  

Index: ChangeLog
===================================================================
RCS file: /cvsroot/pgsqlformac/QueryTool/ChangeLog,v
retrieving revision 1.11
retrieving revision 1.12
diff -C2 -d -r1.11 -r1.12
*** ChangeLog	12 Aug 2006 16:39:04 -0000	1.11
--- ChangeLog	13 Aug 2006 23:54:30 -0000	1.12
***************
*** 1,2 ****
--- 1,6 ----
+ 2006-08-12 11:39  ntiffin
+ 
+ 	* ChangeLog, DataSource.m, SqlDocument.m: More memory cleanup.
+ 
  2006-08-11 13:03  ntiffin