In frontendlayer/tikz/libraries/datavisualization/tikzlibrarydatavisualization.code.tex line 1167 \rmfamily should be used to avoid complaining of other packages such as KOMA-scripts and the like.
--- old+++ new@@ -1 +1 @@-In frontendlayer/tikz/libraries/datavisualization/tikzlibrarydatavisualization.code.tex line 1167 \rmfamily should be used to avoid complaining of other packages such as koma-scripts and the like.+In frontendlayer/tikz/libraries/datavisualization/tikzlibrarydatavisualization.code.tex line 1167 `\rmfamily` should be used to avoid complaining of other packages such as `KOMA-scripts` and the like.
status: open --> closed-wont-fix
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
datavisualization also does provide compatibility with LaTeX as mentioned in the manual. But here, \rm, \bf, ... are deprecated in Latex2e so I don't think "wont-fix" is the correct way to go with this.
Why not some branch having \rm when using Plain Tex and \rmfamily when using LaTeX (or the other supported TeX-variants).
👍
1
Last edit: Robert Spillner 2018-12-21
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Maybe \rm, \bf, etc. are considered deprecated but they are still available in LaTeX. It's not that datavisualization is incompatible with LaTeX, but rather that KOMA-Script is incompatible with datavisualization. You should open a bug there, because \rm, \bf, etc. are part of LaTeX2e and should not be “disabled”. Raising a warning is okay, but making them into an error is not acceptable. You can't just break random things from the LaTeX2e core, just because you don't like them.
👎
1
Last edit: Henri Menke 2018-12-23
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
That's wong! LaTeX2e does not provide \rm, \bf etc. These commands are not part of LaTeX since LaTeX2e (about 1993/94). These commands are provided only by some classes, e.g., the standard classes. Try:
It just does not provide them. Instead it provides a better error message instead of the the standard "undefined control sequence". And the KOMA-Script classes are not the only classes that do not provide these deprecated font commands by default. memoir also does not. Try
If you insist in using such deprecated font commands in datavisualization, you also should define them. Using commands, that are not part of the LaTeX kernel, without defining them and without loading a package, that defines them, is usually not the best idea. To shift the blame to others is neither nice nor smart.
BTW: I do not know much about the internals of pgf but, maybe you could replace the hard coded \rm by \pgfutil@font@normalfont, that is \rm im case of plainTeX or ConteXt and \normalfont in case of LaTeX. With this the library would also respect a \renewcommand{\familydefault}{…}, e.g., to use sans serif fonts instead of roman fonts for a document. But I really do not know, whether or not this would be a suggestion. Another idea would be to extend pgfutil-… or datavisualization by a \pgfutil@font@rm.
Last edit: Markus Kohm 2018-12-28
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I apologize, it looks like I was too hasty jumping to conclusions. I have fixed this bug in an upcoming merge request and it should therefore be marked as fixed. Nevertheless, I don't think it is a good idea for KOMA-Skript to break compatibility with the standard classes, but that is something to discuss elsewhere.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
.... i.e. \mathrm should actually be used...
datavisualizationprovides compatibility with Plain TeX. Close as wont-fix.Diff:
datavisualizationalso does provide compatibility with LaTeX as mentioned in the manual. But here, \rm, \bf, ... are deprecated in Latex2e so I don't think "wont-fix" is the correct way to go with this.Why not some branch having
\rmwhen using Plain Tex and\rmfamilywhen using LaTeX (or the other supported TeX-variants).Last edit: Robert Spillner 2018-12-21
Maybe
\rm,\bf, etc. are considered deprecated but they are still available in LaTeX. It's not thatdatavisualizationis incompatible with LaTeX, but rather that KOMA-Script is incompatible withdatavisualization. You should open a bug there, because\rm,\bf, etc. are part of LaTeX2e and should not be “disabled”. Raising a warning is okay, but making them into an error is not acceptable. You can't just break random things from the LaTeX2e core, just because you don't like them.Last edit: Henri Menke 2018-12-23
That's wong! LaTeX2e does not provide
\rm,\bfetc. These commands are not part of LaTeX since LaTeX2e (about 1993/94). These commands are provided only by some classes, e.g., the standard classes. Try:You will find, that
\bfis undefined before loading the class (a standard class, that defines the command itself, in the example above).And KOMA-Script does not disable these commands. Try:
It just does not provide them. Instead it provides a better error message instead of the the standard "undefined control sequence". And the KOMA-Script classes are not the only classes that do not provide these deprecated font commands by default. memoir also does not. Try
If you insist in using such deprecated font commands in
datavisualization, you also should define them. Using commands, that are not part of the LaTeX kernel, without defining them and without loading a package, that defines them, is usually not the best idea. To shift the blame to others is neither nice nor smart.BTW: I do not know much about the internals of
pgfbut, maybe you could replace the hard coded\rmby\pgfutil@font@normalfont, that is\rmim case of plainTeX or ConteXt and\normalfontin case of LaTeX. With this the library would also respect a\renewcommand{\familydefault}{…}, e.g., to use sans serif fonts instead of roman fonts for a document. But I really do not know, whether or not this would be a suggestion. Another idea would be to extendpgfutil-…ordatavisualizationby a\pgfutil@font@rm.Last edit: Markus Kohm 2018-12-28
I apologize, it looks like I was too hasty jumping to conclusions. I have fixed this bug in an upcoming merge request and it should therefore be marked as fixed. Nevertheless, I don't think it is a good idea for KOMA-Skript to break compatibility with the standard classes, but that is something to discuss elsewhere.