Attached which is a patch against the development branch which adds a "use" clause for whatever suite-wide fixture is in use.
This is necessary as the driver operates under "implicit none" and therefore must identify any external code it is going to make use of. It can not be left to the link stage.
Also in the patch I have removed what appear to be mistaken "allocatable" on maxTimeoutDuration and maxLaunchDuration. Mistaken as the next thing which happens with these variables is not allocation but assignment.
Matthew - here's another patch that I missed and/or resolved and forgot to clear.
Please let me know if it is still an issue - as it is over a year old.
Cheers,
- Tom
From: Tom Clune [mailto:tom_clune@users.sf.net]
I've had a quick look at the head of trunk and it looks like both changes this patch represents have been implemented.
Therefore I think you can close this ticket as "done".
--
Matthew
Thanks for doing my homework for me. :-)
Should have the other item pushed in the morning. Just waiting for the regression tests to report that there were no surprises.
Cheers,
On Sep 5, 2016, at 10:20 AM, Matthew Hambley matthewhambley@users.sf.netamp#109;amp#97;amp#116;amp#116;amp#104;amp#101;amp#119;amp#104;amp#97;amp#109;amp#98;amp#108;amp#101;amp#121;amp#64;amp#117;amp#115;amp#101;amp#114;amp#115;amp#46;amp#115;amp#102;amp#46;amp#110;amp#101;amp#116; wrote:
From: Tom Clune [mailto:tom_clune@users.sf.net]
Matthew - here's another patch that I missed and/or resolved and forgot
to clear.
Please let me know if it is still an issue - as it is over a year old.
I've had a quick look at the head of trunk and it looks like both changes this patch represents have been implemented.
Therefore I think you can close this ticket as "done".
--
Matthew
[patches:#8]https://sourceforge.net/p/pfunit/patches/8/ Minor tweaks for suite fixtures and durations.
Status: open
Group: 3.1 development
Created: Fri Jun 05, 2015 10:01 AM UTC by Matthew Hambley
Last Updated: Mon Sep 05, 2016 01:21 PM UTC
Owner: Matthew Hambley
Attachments:
Attached which is a patch against the development branch which adds a "use" clause for whatever suite-wide fixture is in use.
This is necessary as the driver operates under "implicit none" and therefore must identify any external code it is going to make use of. It can not be left to the link stage.
Also in the patch I have removed what appear to be mistaken "allocatable" on maxTimeoutDuration and maxLaunchDuration. Mistaken as the next thing which happens with these variables is not allocation but assignment.
Sent from sourceforge.nethttp://sourceforge.net because you indicated interest in https://sourceforge.net/p/pfunit/patches/8/
To unsubscribe from further messages, please visit https://sourceforge.net/auth/subscriptions/
Related
Patches: #8