#49 Build failure against new octave 6.2 API

[eatdirt]

Hi there,
as usual, the punks from Octave, had broken various API calls and pfstools does not compile anymore.

Even in the Changelog of Octave, they do not mention that is_map() has been removed!?

 Generating pfsget.oct
cd /root/repos/pfstools/BUILD/pfstools-2.1.0/build/src/octave && /usr/bin/mkoctfile /root/repos/pfstools/BUILD/pfstools-2.1.0/src/octave/pfsget.cpp -I/root/repos/pfstools/BUILD/pfstools-2.1.0/src/pfs/ -I/root/repos/pfstools/BUILD/pfstools-2.1.0/src/octave/help_files -L/root/repos/pfstools/BUILD/pfstools-2.1.0/build/src/pfs -lpfs
/root/repos/pfstools/BUILD/pfstools-2.1.0/src/octave/pfsget.cpp: In function ‘octave_value_list Fpfsget(const octave_value_list&, int)’:
/root/repos/pfstools/BUILD/pfstools-2.1.0/src/octave/pfsget.cpp:49:31: error: ‘const class octave_value’ has no member named ‘is_map’
   49 |   if( nargin != 1 || !args(0).is_map() )

Best,
Chris.

[Alex Shpilkin]

FWIW, octave_value::is_map() and similar methods have been deprecated since 4.4 and caused compilation warnings, so maybe the Octave people thought they had already given adequate notice. They were removed in Octave changeset f23f27e78aa2. The deprecation notices (which the changeset removes along with the methods themselves) do mention seemingly straighforward replacements (for is_map(), it’s isstruct()), but I’m not up to doing a patch today, sorry.

[Orion Poplawski]

octave 6.1 has been released and I'm hoping to update it in Fedora. Any chance a patch could be developed soon? Thanks.

[Michal Suchanek]

patch

[Rafal Mantiuk]

Thank you for the patch. It is now applied and merged with master.