#42 build error with gcc-6

[Andreas Metzler]

pfstools 2.0.4 FTBFS with gcc-6:

[ 28%] Building CXX object src/filter/CMakeFiles/pfsclamp.dir/pfsclamp.cpp.o
cd /tmp/PFS/pfstools-2.0.4/obj-x86_64-linux-gnu/src/filter && /usr/lib/ccache/g++-6    -I/tmp/PFS/pfstools-2.0.4/obj-x86_64-linux-gnu -I/tmp/PFS/pfstools-2.0.4/src/pfs  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wall -Wdate-time -D_FORTIFY_SOURCE=2    -o CMakeFiles/pfsclamp.dir/pfsclamp.cpp.o -c /tmp/PFS/pfstools-2.0.4/src/filter/pfsclamp.cpp
/tmp/PFS/pfstools-2.0.4/src/filter/pfsclamp.cpp: In function 'void clamp(pfs::Array2D*, float, float, bool, bool)':
/tmp/PFS/pfstools-2.0.4/src/filter/pfsclamp.cpp:78:20: error: 'isfinite' was not declared in this scope
     if( !isfinite(v) )
                    ^

/tmp/PFS/pfstools-2.0.4/src/filter/pfsclamp.cpp:78:20: note: suggested alternative:
In file included from /usr/include/c++/6/random:38:0,
                 from /usr/include/c++/6/bits/stl_algo.h:66,
                 from /usr/include/c++/6/algorithm:62,
                 from /tmp/PFS/pfstools-2.0.4/src/filter/pfsclamp.cpp:29:
/usr/include/c++/6/cmath:601:5: note:   'std::isfinite'
     isfinite(_Tp __x)
     ^~~~~~~~

src/filter/CMakeFiles/pfsclamp.dir/build.make:65: recipe for target 'src/filter/CMakeFiles/pfsclamp.dir/pfsclamp.cpp.o' failed
make[4]: *** [src/filter/CMakeFiles/pfsclamp.dir/pfsclamp.cpp.o] Error 1
make[4]: Leaving directory '/tmp/PFS/pfstools-2.0.4/obj-x86_64-linux-gnu'
CMakeFiles/Makefile2:771: recipe for target 'src/filter/CMakeFiles/pfsclamp.dir/all' failed
make[3]: *** [src/filter/CMakeFiles/pfsclamp.dir/all] Error 2

See https://bugs.debian.org/811903 and https://wiki.debian.org/GCC6

cu Andreas

[Rafal Mantiuk]

The code was fixed to compile with c++-11 (in git). It was not tested with g++-6 though.

[Andreas Metzler]

A recent Gcc snapshot has managed to build 2.0.4, so it looks no further changes are necessary.