#40 2.0.4 build error against octave 4.0

[Andreas Metzler]

Hello,

pfstfools FTBFS against octave 4.0 with the following error:

[ 64%] Generating pfsput.oct
cd /tmp/PFS/pfstools-2.0.4/obj-i586-linux-gnu/src/octave && /usr/bin/mkoctfile /tmp/PFS/pfstools-2.0.4/src/octave/pfsput.cpp -I/tmp/PFS/pfstools-2.0.4/src/pfs/ -I/tmp/PFS/pfstools-2.0.4/src/octave/help_files -L/tmp/PFS/pfstools-2.0.4/obj-i586-linux-gnu/src/pfs -lpfs
/tmp/PFS/pfstools-2.0.4/src/octave/pfsput.cpp: In function 'octave_value_list Fpfsput(const octave_value_list&, int)':
/tmp/PFS/pfstools-2.0.4/src/octave/pfsput.cpp:55:51: error: conversion from 'octave_map' to non-scalar type 'octave_scalar_map' requested
octave_scalar_map pfsStream = args(0).map_value();
^
/tmp/PFS/pfstools-2.0.4/src/octave/pfsput.cpp:59:34: error: no match for call to '(octave_value) (int)'
!pfsStream.contents( itFH )(0).is_real_scalar() )
^
/tmp/PFS/pfstools-2.0.4/src/octave/pfsput.cpp:64:57: error: no match for call to '(octave_value) (int)'
FILE fh = (FILE)((long)(pfsStream.contents( itFH )(0).double_value()));
^
/tmp/PFS/pfstools-2.0.4/src/octave/pfsput.cpp:69:69: error: no match for call to '(octave_value) (int)'
if( itMode == pfsStream.end() || !pfsStream.contents( itMode )(0).is_string() )
^
/tmp/PFS/pfstools-2.0.4/src/octave/pfsput.cpp:74:39: error: no match for call to '(octave_value) (int)'
if( pfsStream.contents( itMode )(0).string_value() != "W" ) {
^
/tmp/PFS/pfstools-2.0.4/src/octave/pfsput.cpp:86:38: error: no match for call to '(octave_value) (int)'
!pfsStream.contents( itCols )(0).is_real_scalar() ||
^
/tmp/PFS/pfstools-2.0.4/src/octave/pfsput.cpp:87:38: error: no match for call to '(octave_value) (int)'
!pfsStream.contents( itRows )(0).is_real_scalar() )
^
/tmp/PFS/pfstools-2.0.4/src/octave/pfsput.cpp:92:48: error: no match for call to '(octave_value) (int)'
width = (int)pfsStream.contents( itCols )(0).double_value();
^
/tmp/PFS/pfstools-2.0.4/src/octave/pfsput.cpp:93:49: error: no match for call to '(octave_value) (int)'
height = (int)pfsStream.contents( itRows )(0).double_value();
^
/tmp/PFS/pfstools-2.0.4/src/octave/pfsput.cpp:101:42: error: no match for call to '(octave_value) (int)'
!pfsStream.contents( itChannels )(0).is_map() )
^
/tmp/PFS/pfstools-2.0.4/src/octave/pfsput.cpp:106:50: error: no match for call to '(octave_value) (int)'
channels = pfsStream.contents( itChannels )(0).map_value();
^
/tmp/PFS/pfstools-2.0.4/src/octave/pfsput.cpp:117:39: error: no match for call to '(octave_value) (int)'
if( !channels.contents( itCh )(0).is_real_matrix() ) {
^
/tmp/PFS/pfstools-2.0.4/src/octave/pfsput.cpp:121:55: error: no match for call to '(octave_value) (int)'
Matrix channelData = channels.contents( itCh )(0).matrix_value();
^
/tmp/PFS/pfstools-2.0.4/src/octave/pfsput.cpp:140:44: error: no match for call to '(octave_value) (int)'
if( !pfsStream.contents( itTags )(0).is_map() )
^
/tmp/PFS/pfstools-2.0.4/src/octave/pfsput.cpp:145:9: error: 'octave_scalar_map_map' was not declared in this scope
octave_scalar_map_map tags = pfsStream.contents( itTags )(0).map_value();
^
/tmp/PFS/pfstools-2.0.4/src/octave/pfsput.cpp:146:50: error: 'tags' was not declared in this scope
for( octave_scalar_map::iterator itTag = tags.begin(); itTag != tags.end(); itTag++ ) {
^
/tmp/PFS/pfstools-2.0.4/src/octave/pfsput.cpp:161:46: error: no match for call to '(octave_value) (int)'
if( !pfsStream.contents( itChTags )(0).is_map() )
^
/tmp/PFS/pfstools-2.0.4/src/octave/pfsput.cpp:165:73: error: no match for call to '(octave_value) (int)'
octave_scalar_map tagChannels = pfsStream.contents( itChTags )(0).map_value();
^
/tmp/PFS/pfstools-2.0.4/src/octave/pfsput.cpp:168:46: error: no match for call to '(octave_value) (int)'
if( !tagChannels.contents( itCh )(0).is_map() ) {
^
/tmp/PFS/pfstools-2.0.4/src/octave/pfsput.cpp:176:66: error: no match for call to '(octave_value) (int)'
octave_scalar_map tags = tagChannels.contents( itCh )(0).map_value();
^
/tmp/PFS/pfstools-2.0.4/src/octave/pfsput.cpp:179:42: error: no match for call to '(octave_value) (int)'
if( !tags.contents( itTag )(0).is_string() )
^
/tmp/PFS/pfstools-2.0.4/src/octave/pfsput.cpp:181:60: error: no match for call to '(octave_value) (int)'
std::string tagValue = tags.contents( itTag )(0).string_value();
^
src/octave/CMakeFiles/pfsput.mkoct.dir/build.make:54: recipe for target 'src/octave/pfsput.oct' failed
make[3]: *** [src/octave/pfsput.oct] Error 1

cu Andreas

[Andreas Metzler]

Fedora's pfstools-2.0.4-1.fc24.src.rpm as a patch.

[Rafal Mantiuk]

Should be fixed now (in git). Tested with Octave 3.8.1.