Re: [Petri-foo-devel] news on development

[James M. <ja...@jw...>]

Hi Jean-Pierre,

Some nice work there, the exponential envelope and logarithmic sliders 
are great.

The only thing I have issue with is what you've tried to do with the 
sample load dialog - I don't think it is the best approach.

I much prefer the raw data options to remain hidden until the user 
wishes to load a raw sample, it's less cluttered. Using these options to 
display the currently selected sample is confusing and unexpected, at 
least in my mind.

It would make more sense to have a seperate area for displaying the 
sample data format.

So that is the only thing I'd like to see changed about what you've done.

Incidentally, I've found the cause of Petri-Foo failing to load raw 
data, it was #ifdef'd out in libpetrifoo/sample.c for some unfathomable 
reason.


Best regards,
James.


On 12/12/15 20:33, James Morris wrote:
> Hi Jean-Pierre,
>
> Your work on Petri-Foo looks interesting, I'll try and look through it,
> and incorporate the modifications.
>
> I'm not particularly experienced in collaborative programming either,
> and have taken similar approaches to the changes also, no worries.
>
> It's motivating to have others to collaborate with.
>
> I've noticed in your fork the sample load dialog always has the options
> for raw data on show which I found confusing. In my version the raw data
> options are only available when the raw data check box is ticked - I
> prefer that.
>
> Anyway, raw data loading is broken in Petri-Foo itself, see issue #35:
> https://github.com/jwm-art-net/Petri-Foo/issues/35
>
> Cheers,
> James.
>
>
>
> On 12/12/15 10:48, Jean-Pierre Haenlin wrote:
>> Hi,
>>
>> I have made some modifications to PF on a Github fork.
>> I'm afraid that I don't have followed the best procedure to do that. I
>> should have send to James each evolution one after the other. But I'm
>> not an expert at "collaborative programming".
>> Now, Olivier is asking me how he can do to insert my version of PF in
>> the Linux distribution he wants to make. I don't know how I can help
>> him. I think James can incorporate in PF my modifications when he wants,
>> and in the meantime, everybody can use my version since it is freely
>> downloadable. How do you see the best way to evolve for PF.
>>
>> Jean-Pierre
>>
>> (https://github.com/jphaenlin/Petri-Foo)