|
From: Markus R. <god...@us...> - 2009-11-12 12:49:36
|
Module: performous
Branch: master
Commit: ea4bc0ed90f9c65313083d6ce02b33e3f2d38497
Author: Markus Raab <un...@ma...>
Date: Wed Nov 11 11:10:33 2009 +0100
remove unused rnd function
(which is implemented in a wrong way)
genious comment added :-)
---
game/songs.cc | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/game/songs.cc b/game/songs.cc
index f98ce87..65bce0c 100644
--- a/game/songs.cc
+++ b/game/songs.cc
@@ -129,6 +129,7 @@ void Songs::randomize() {
void Songs::randomize_internal() {
/* TR1-based random number generation
+ TODO: it is enough that random_device is initialized once and not for every randomize_internal
namespace rnd = std::tr1;
rnd::random_device gendev; // Random number generator (using /dev/urandom usually)
rnd::mt19937 gen(gendev); // Make Mersenne Twister random number generator, seeded with random_device.
@@ -225,10 +226,6 @@ void Songs::sortChange(int diff) {
sort_internal();
}
-namespace {
- int rnd(int n) { return rand() % n; }
-}
-
void Songs::sort_internal() {
switch (m_order) {
case 0: std::stable_sort(m_filtered.begin(), m_filtered.end(), comparator(&Song::randomIdx)); break;
|