#7 Thermal energy for an isothermal equation of state

[Anonymous]

Originally created by: tobias.h...@gmail.com
Originally owned by: tobias.h...@gmail.com

The mean thermal energy per unit volume is calculated in the code like this:

if (idiag_eth/=0) call sum_mn_name(p%rho*p%ee,idiag_eth)

Here, p%ee is calculated in the EOS module and given by p%ee=p%cs2 in the
case of an isothermal equation of state.

However, the correct expression for the isothermal energy per unit volume
is actually

p%eth = p%cs2*p%rho*p%lnrho

So the question is, should we simply add an if statement when idiag_eth is
calculated, or should we modify p%ee so that it actually is the mean
thermal energy per unit mass?

[Anonymous]

Originally posted by: wdobler@gmail.com

Given that p%ee is apparently only used for diagnostic purposes, we should fix both,
p%eth and p%ee.