#3 wdamp defined in Density and Hydro gives problem with IDL

[Anonymous]

Originally created by: boris.di...@gmail.com
Originally owned by: wdobler@gmail.com

Dear all,

There is an entry in the density namelist, called wdamp, which seems to be
in conflict with the one in the entropy namelist with has the same name
'wdamp', i.e. when one call the 'nl2idl' perl script, one gets:

./data/param2.nml WARNING: Conflicting slots wdamp = [5.0000001E-02] vs.
[0.0000000E+00]

    at /home/dintrans/f90/pencil-code/bin/nl2idl line 123

I don't know who is actually using this 'wdamp' density entry but, in order
to remove this WARNING (quite irritating when one reads a lot of snapshots)
, is there a consensus to rename it in order to remove this WARNING?

Cheers, Boris

[Anonymous]

Originally posted by: wdobler@gmail.com

I think you are talking about hydro and density -- entropy does not seem to have a
wdamp variable.

There was at least once the suggestion to parse the different namelists
(density_init_pars, hydro_run_pars, etc) into separate IDL structs (say,
param_density, or even param.density), so we would have param.density.wdamp and
param.hydro.wdamp here.

The downside is that a lot of IDL code would need to be adapted to find the parameters.

If we really want to go in that direction, we can have both systems in parallel for
some time. But still, once we phase out the global param struct, a lot of IDL scripts
will stop working until fixed.

Maybe the global vs. per-module structs could just remain configurable for users...

[Sorry, I think I am hijacking your bug here. If more people think we should go
towards per-module structs, I'll move this discussion on a separate ticket.]

[Anonymous]

Originally posted by: anders.j...@gmail.com

There are two possible solutions:

1. Add a flag to pc_read_param that suppresses such warnings
2. Add an additional layer of structures to the param structure so that two name
lists can indeed have the same variable names

Under all circumstances pc_read_param shpuld by default still read the full list of
variables into the param structure, to not mess up existing usage of pc_read_param.

Labels: -Priority-Medium Priority-Low
Owner: wdobler