From: Michal H. <ms...@gm...> - 2011-08-23 08:51:37
|
On Tue, Aug 23, 2011 at 06:49:22AM +0000, Jozef Misutka wrote: > > On Thu, Aug 11, 2011 at 09:36:53AM +0200, Michal Hocko wrote: [...] > > > Sorry it took so long but I've been busy recently. > > > I have looked at Lexer and how it handles name objects and found out > > > that the patch I have sent last time is not sufficient (albeit we need it). > > > The other problem is in makeNamePdfValid itself. > > > We follow a PDF specification recommendation to represent all characters > > > out of range [~, !] as #hexa numbers. This is not sufficient, though > > > (just consider `(', `)' and there are others). The attached patch fixes > > > that. > > > > > > I've tested both patches by delinearizator and pdf_object_printer tools > > > as I am still not able to build gui now. ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > > > > > Both patches are attached for reference. > > > > Did you have time to look at those patches? Should I push them to the > > repository? > Have you tried the patch with the specific file from my email? if yes then ok. > thx for the work,jm I can push it but I would rather have somebody to double check those patches (that's why I have post them in the first place). -- Michal Hocko |