Re: Edit page metrics coordinates are wrong?

[Michal H. <ms...@gm...>]

On Mon, Jan 24, 2011 at 12:05:54AM +0100, Martin Petricek wrote:
> On Thu, 20 Jan 2011 18:10:57 +0100, Michal Hocko <ms...@gm...>
> wrote:
> >On Sat, Jan 15, 2011 at 06:04:36PM +0100, Michal Hocko wrote:
> >>On Tue, Dec 07, 2010 at 04:12:23PM +0100, Michal Hocko wrote:
> >>> Hi Martin,
> >>> could you review the attached patch please?
> >>> We have had a report about improper bottom and upper labels
> >>and I can
> >>> confirm that I can reproduce that with many of my pdfs. In fact I
> >>> haven't found any that would behave in a different way.
> >>>
> >>> I am not sure whether this patch is correct, so I want you to
> >>check it.
> >>
> >>Did you have time to look at this, Martin?
> >
> >Scratch that. This doesn't work correctly for rotated documents.
> >Have a look at bt#367.
> 
> I think the patch is fine, though after rotation, the media box is
> still relative to original unrotated coordinates (well, the rotation
> works by setting one parameter of the page to a multiple of 90,
> which is then interpreted by viewers). I think adding extra line of
> text like
> "The coordinates are based on bottom left corner of the page, before
> applying page rotation specified for the page" to the dialog may
> clarify the things a bit more.

This is not very much helpful. The transformation after rotation is far
from being trivial. What do you think about the attached patch instead
(please note that you still need the first patch in this thread -
attached in the bugtracker).

The patch still needs a cleanup (I would like to have it less
if-else-set and there are some other things to think about). So this is
just make a proof-of-concept thingy.

Any thoughts?

> 
> Martin Petricek

-- 
Michal Hocko