Menu

#11 Remove optimization/warning/debug CFLAGS from default CFLAGS

v1.0_(example)
open
nobody
None
1
2017-10-13
2017-10-13
No

Currently:

CFLAGS += -Wall -Wextra -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -O3 -g

Adds optimization, warning and debug CFLAGS which forces down stream such as Gentoo to patch package to remove these every package.

Please consider to separate this into:

CFLAGS ?= -O -g -Wall -Wextra
PACKAGE_CFLAGS += $(CFLAGS) -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE

And use PACKAGE_CFLAGS all over, so that downstream can safely override the CFLAGS per its needs.

Thanks,

Discussion


Log in to post a comment.

MongoDB Logo MongoDB