Menu

#187 imageMAGICK plugin Inverted Colors on file read

0.94
closed-fixed
OSX
5
2014-08-28
2012-03-29
megrimm
No

pd-extended 64bit osx 10.7.3

When opening a file the Red channel and the Green channel were inverted.

FIX:

Line 54: GL_RGB
Line 60: "BGR"

...that fix took me half the day to figure out. anyway, i know i should be submitting a patch but im not too illiterate yet on the git systems and was failing quite miserably in my attempts to create a suitable patch....

m

Discussion

  • IOhannes m zmölnig

    • labels: --> Pixes (pix_ objects)
    • milestone: --> osx
     
  • IOhannes m zmölnig

    the problem with that fix is, that we are potentially losing the alpha channel of the image, which is not so good.

     
  • megrimm

    megrimm - 2012-05-02

    yeah I am not sure what to say. I realize this is probably a larger problem. I just added the alpha channel and compiled only to get the same discoloration. the solution i presented seemed to be the only one that get adequate results.

    for the 64 bit builds ive been looking at starting an native cocoa plugin for images but i would need some direction. I am not so sure how to utilize Objective-C code (in cocoa we would be using NSImage) in a C++ application. This could just be the easy better solution?

    let me know what you need for me to work all this out....

    m

     
  • IOhannes m zmölnig

    • Owner: Anonymous --> IOhannes m zmölnig
    • OS: --> OSX
     
  • IOhannes m zmölnig

    • Release: osx --> unknown
     
  • IOhannes m zmölnig

    • labels: Pixes (pix_ objects) --> Pixes (pix_ objects), imageMagick, plugins
    • Release: unknown --> 0.93-git
     
  • IOhannes m zmölnig

    • Release: 0.93-git --> 0.94
     
  • IOhannes m zmölnig

    • status: open --> closed-fixed
     
  • IOhannes m zmölnig

    fixed with [ddb94f]

     

    Related

    Commit: [ddb94f]

Anonymous
Anonymous

Add attachments
Cancel