#404 Does not remeber window dimension after reboot

1.0.1
closed-fixed
pcmanfm (129)
3
2012-08-13
2010-12-16
Pierre
No

Using Lubuntu 10.10

If you close PCManFM and reopen it, it will remember its dimension (height X width). But if you change dimensions, close it and reboot, it will reopen at the old dimensions, not the new ones that you set. Is this a bug or am I doing something wrong. Same problem on different computers.

Discussion

  • Pierre

    Pierre - 2010-12-22

    Did more checking...

    Other window positions are remembered. So it is a PCManFM problem. It appears that it does not save to pcmanfm.conf:
    win_width=?
    win_height=?
    splitter_pos=?

    AND does not load any new dimensions either if you enter them manually.

    Should be an easy fix. Thanks for the great work. It is a very good piece of software!

     
  • Pierre

    Pierre - 2010-12-22

    Correction:
    It seems to use and load dimensions from lubuntu.conf (works if changed manually) but fails to save new dimensions there upon quitting.

     
  • PCMan

    PCMan - 2011-11-18

    Version 1.0 is in feature freeze and string freeze now.
    Let's fix this later in 1.5.

     
  • PCMan

    PCMan - 2011-11-18
    • milestone: --> 2297538
    • priority: 5 --> 4
     
  • PCMan

    PCMan - 2011-11-18
    • assigned_to: nobody --> pcmanx
     
  • Lonely Stranger

    Lonely Stranger - 2012-05-26
    • priority: 4 --> 2
     
  • Lonely Stranger

    Lonely Stranger - 2012-05-26
    • priority: 2 --> 3
     
  • PCMan

    PCMan - 2012-05-27

    If the program is killed, the values are not written to config files.
    Otherwise, it saves the values in config files on program termination.
    We need to find out a better way to do this.

     
  • Lonely Stranger

    Lonely Stranger - 2012-07-16
    • milestone: 2297538 --> 1.0.1
     
  • Lonely Stranger

    Lonely Stranger - 2012-07-17
    • status: open --> open-accepted
     
  • Lonely Stranger

    Lonely Stranger - 2012-07-18
    • labels: --> pcmanfm
     
  • Lonely Stranger

    Lonely Stranger - 2012-08-10
    • assigned_to: pcmanx --> lstranger
     
  • Lonely Stranger

    Lonely Stranger - 2012-08-13
    • status: open-accepted --> closed-fixed
     
  • Lonely Stranger

    Lonely Stranger - 2012-08-13

    We hope this issue is completely fixed in the Git repository recently.
    Check it out when it's possible for you and if the bug still exists then reopen the report, please.
    Thank you very much.

     
  • PCMan

    PCMan - 2012-08-13
    • status: closed-fixed --> open-fixed
     
  • PCMan

    PCMan - 2012-08-13

    I have never fixed this one so I'm sure the bug is still there.
    Fixing this issue is more complicated then it looks like.

    When to save the window position?
    1. If we do it everytime the window is moved, this causes excessive disk writing.
    2. If we do it when a window is closed, if the program is terminated with all window opened, it won't be saved.
    3. If we do it when the program terminates, this sounds reasonable but cannot be implemented. When the user logout the desktop session or reboot, pcmanfm is terminated by SIGKILL generated by disconnecting from X. It's SIGKILL, not SIGTERM and there is no way to intercept that signal.
    4. If we utilize X11 session management and save it when X session logout, this requires XSM support and it only work for currently active desktop session. Sessions of inactive users are not handled by XSM. Besides, lxsession and other WMs has no XSM support.
    5. If we try to interact with session manager, such as register ourself via gnome-session dbus interface, it's possible to get logout signal under gnome, but it's gnome-only.

    To sum up, there is no reliable and efficient way to do it while it's easy to do in Windows since Windows 95. Unfortunately, we're using X11.

     
  • Lonely Stranger

    Lonely Stranger - 2012-08-13

    You're right about killing with the window is opened, I've missed that case. But you should not worry about any excessive disk writing as much config will be saved if and only if the user manually resize window size (not counting moving, maximizing, or fullscreening it) and even that will be done with a little timeout so if user do resize few times in few seconds then config will be rebuilt only once.

     
  • Lonely Stranger

    Lonely Stranger - 2012-08-13
    • status: open-fixed --> closed-fixed
     
  • Lonely Stranger

    Lonely Stranger - 2012-08-13

    Just the note - ticket was about "change dimensions, close it and reboot" and that behavior is fixed in Git but your case is "change dimensions and then reboot" which is another case and that another case may need yet be confirmed if it is ever requested and if it is then it should be discussed with all users as it changes current behavior so therefore the user expectations. So let it be as it is now. Ticket's issue is fixed. Thank you everyone!

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks