Menu
▾
▴
[Pcgen-trackers] [ pcgen-Bugs-888373 ] PRESPELL isn't catching innate spells
|
From: SourceForge.net <no...@so...> - 2005-05-06 01:24:08
|
Bugs item #888373, was opened at 2004-01-31 19:26 Message generated for change (Comment added) made by ericbeaudoin You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=384719&aid=888373&group_id=25576 Category: Spell Support Group: 5.7.11 Status: Closed Resolution: Fixed Priority: 9 Submitted By: mike (brainface) Assigned to: HunterCottage (hunterc) Summary: PRESPELL isn't catching innate spells Initial Comment: PRESPELL doesn't appear to be reading spells given thru the SPELL: tag That is, I had a feat with PRESPELL:Mount, A race with SPELL:Mount|1|Innate, and a character of that race couldn't take the feat. Tried Feats: Test Give Innate Spell SPELL:Mage Hand|1|Innate Copy of Test Give Innate Spell SPELL:Mage Hand|1|Foo Test Prespell Mage Hand PRESPELL:1,Mage Hand A sorcerer couldn't take 'Test Prespell Mage Hand' with either of the 'Test Give Innate Spell' feats, but could as soon as given Mage Hand as a Sorcerer known spell... ---------------------------------------------------------------------- >Comment By: Eric Beaudoin (ericbeaudoin) Date: 2005-05-05 21:24 Message: Logged In: YES user_id=324612 That's good to know. Thanks Hunter. ---------------------------------------------------------------------- Comment By: HunterCottage (hunterc) Date: 2005-05-05 21:13 Message: Logged In: YES user_id=1239235 I've only added a check for racial spell-like ability. I haven't changed anything else. ---------------------------------------------------------------------- Comment By: Devon Jones (soulcatcher) Date: 2005-05-05 19:16 Message: Logged In: YES user_id=107647 Fair enough. Can you call a freeze please? I'll get this tested tonight, and get back to you on this and the other testing you needed. Devon ---------------------------------------------------------------------- Comment By: Eric Beaudoin (ericbeaudoin) Date: 2005-05-05 18:10 Message: Logged In: YES user_id=324612 PRESPELL is also supposed to check if for spell that are added with CLASSES and DOMAINS in the SPELL file and with the SPELLLIST tag. Not to mention that SPELL should still be working even if deprecated. This has the potentiel to that have far reaching effect Devon, I'm surprised you let it go through. I've been waiting for words from you in order to release RC8. If code is still allowed in, we will not see the end of it. All that being said, it is of course your call. ---------------------------------------------------------------------- Comment By: HunterCottage (hunterc) Date: 2005-05-05 18:04 Message: Logged In: YES user_id=1239235 Added racial spell-like ability check to prespell. File changed: java/pcgen/core/prereq PreSpell.java version 1.10 ---------------------------------------------------------------------- Comment By: Devon Jones (soulcatcher) Date: 2005-05-05 17:25 Message: Logged In: YES user_id=107647 Go for it. I don't know of anything else. Devon ---------------------------------------------------------------------- Comment By: HunterCottage (hunterc) Date: 2005-05-05 15:51 Message: Logged In: YES user_id=1239235 I have fixed prespell.java to include racial spell-like abilities, but thought I would ask before I commit, if there is anything else that can give spell-like abilities that prespell could cover. I'm unsure of what other cases could be available... ---------------------------------------------------------------------- Comment By: HunterCottage (hunterc) Date: 2005-05-04 19:13 Message: Logged In: YES user_id=1239235 I did a test with SPELLS and PRESPELL which didn't work. It mirrors the example given initially, only difference is I used SPELLS instead of SPELL. ---------------------------------------------------------------------- Comment By: Devon Jones (soulcatcher) Date: 2005-05-04 12:57 Message: Logged In: YES user_id=107647 Spell is deprecated we only keep it in I believe in order to get people to fix their data. I don't think we should write code to support deprecated tags. that being said, if the person is pointing at the actual innate spell objects, it won't matter, it'll pick it up from both. ---------------------------------------------------------------------- Comment By: Paul W. King (kingpaul) Date: 2005-05-04 12:12 Message: Logged In: YES user_id=277877 I assume that this fix will reference both SPELL and SPELLS? ---------------------------------------------------------------------- Comment By: Devon Jones (soulcatcher) Date: 2005-05-04 12:08 Message: Logged In: YES user_id=107647 ok, guess we need to get this fixed then. P9 ---------------------------------------------------------------------- Comment By: Paul W. King (kingpaul) Date: 2005-05-04 05:42 Message: Logged In: YES user_id=277877 Its been answered in Complete Arcane, p. 72, top of the 2nd column. Since that's not an OGC source, I won't quote here. However, the answer is 'yes, spell-like abilities count'. Paul W. King TM SB, OGL/PL Chimp, Data Gibbon, BoD ---------------------------------------------------------------------- Comment By: James Dempsey (jdempsey) Date: 2005-05-04 05:27 Message: Logged In: YES user_id=558288 Have we had a response on this? Do we have a desired fix for this one yet? James. ---------------------------------------------------------------------- Comment By: Devon Jones (soulcatcher) Date: 2005-03-17 16:48 Message: Logged In: YES user_id=107647 yeah, send to sage. Thanks Kar ---------------------------------------------------------------------- Comment By: Martijn Verburg (karianna) Date: 2005-03-10 10:30 Message: Logged In: YES user_id=252169 Bump - Send this to the sage? ---------------------------------------------------------------------- Comment By: Reed Thornton (rthornton13) Date: 2004-12-13 00:43 Message: Logged In: YES user_id=1001978 I remember this as a different bug. At the time Tir said that Innate spells were *not* supposed to qualify. I differ in my opinion, but do not have text to back up my position. Perhaps this is a question for WotC? Reed QA SB ---------------------------------------------------------------------- Comment By: Reed Thornton (rthornton13) Date: 2004-12-13 00:41 Message: Logged In: YES user_id=1001978 I remember this as a different bug. At the time Tir said that Innate spells were *not* supposed to qualify. I differ in my opinion, but do not have text to back up my position. Perhaps this is a question for WotC? Reed QA SB ---------------------------------------------------------------------- Comment By: Ratheof Blithwyn (blithwyn) Date: 2004-12-09 17:11 Message: Logged In: YES user_id=677457 verified 2004-12-09 5.7.11 as per Devons request. Still there. Tested with SPELL and SPELLS assigned to test races. The spell show up in the Innate spellbook but is not enough to qualify for a feat with PRESPELL:1,.. ---------------------------------------------------------------------- Comment By: Michael Beaver (michaelbeaver) Date: 2004-09-09 14:32 Message: Logged In: YES user_id=23904 Still there in the 5.7.5 autobuild dated: 9/9/2004 ---------------------------------------------------------------------- Comment By: Eric Beaudoin (ericbeaudoin) Date: 2004-07-11 23:08 Message: Logged In: YES user_id=324612 The bug is still there in the lastest CVS build. Assinging to Devon so he can decide what to do with it. The funcitonnality is not needed for 5.8. ---------------------------------------------------------------------- Comment By: Martijn Verburg (karianna) Date: 2004-02-25 17:46 Message: Logged In: YES user_id=252169 Eric can you test to see if this works in RC3? K TM SB ---------------------------------------------------------------------- Comment By: Martijn Verburg (karianna) Date: 2004-02-12 15:57 Message: Logged In: YES user_id=252169 Karianna prods Bryan Probably not needed for prod.. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=384719&aid=888373&group_id=25576 |