[Pcgen-trackers] [ pcgen-Bugs-1174968 ] Character preview does not show ammo in ranged weapons

[SourceForge.net <no...@so...>]

Bugs item #1174968, was opened at 2005-04-01 11:27
Message generated for change (Settings changed) made by soulcatcher
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1174968&group_id=25576

Category: User Interface
Group: None
>Status: Closed
Resolution: Fixed
Priority: 9
Submitted By: Eddy Anthony (eddyanthony)
Assigned to: James Dempsey (jdempsey)
Summary: Character preview does not show ammo in ranged weapons

Initial Comment:
If you equip a plus 5 crossbow and put a plus 5 bolt in it when you 
output to the html sheet the bolts enchantment plus is added to the 
crossbow. However the Preview tab does not do this and it should.

There is also a game mechanics issue here, in 3.0 enchantment 
bonuses DO stack between weapons and ammo but in 3.5 they don't

I mention this because it relevant but we will need a separate FREQ 
to implement that feature. The original issue is still a problem for 3.5 
because if you put +5 ammo in a normal crossbow the preview still 
doesn't transfer the bonus though it is within the rules to do so.

----------------------------------------------------------------------

Comment By: Devon Jones (soulcatcher)
Date: 2005-04-02 09:15

Message:
Logged In: YES 
user_id=107647

James, don't worry about the "don't change that" that's just
an artifact from netbeans - and I've already made most of
these forms netbeans incapable (well, and deleted their.
.fomrs) so it's cool.

Let's get a second tracker for 3.5 stacking.

----------------------------------------------------------------------

Comment By: James Dempsey (jdempsey)
Date: 2005-04-02 01:03

Message:
Logged In: YES 
user_id=558288

Tracker changed to pending until a decision is made on how
and under which tracker the ammo stacking changes should be
made.

James.

----------------------------------------------------------------------

Comment By: James Dempsey (jdempsey)
Date: 2005-04-02 01:02

Message:
Logged In: YES 
user_id=558288

Preview pane has been fixed and now shows the same stats as
the output sheets. The ammo description is only shown when
the weapon contains ammo. This is slightly different from
the output sheets.

Devon, this involved changing code which had "Do not change"
markers around it. As the forms did not appear in the
repositiory I changed it anyway. Hope that's ok - I can redo
it from the form if required.

Files changed:
java/plugin/charactersheet/gui/RangedWeaponPane.java    new
revision: 1.10

----------------------------------------------------------------------

Comment By: James Dempsey (jdempsey)
Date: 2005-04-01 18:45

Message:
Logged In: YES 
user_id=558288

I've done some testing and it looks like the problems are:
*The preview pane doesn't show ammo or its effects at all
for ranged weapons.
* HTML and PDF output sheets show the ammo and its effects.
* Enhancement bonuses to ammo in a ranged weapon stacks with
the weapon's enhancement bonus in both 3.0 and 3.5 modes.

I've changed the title of this bug to reflect the preview
problem. 

I think the ammo bonus stacking in 3.5 mode should be a
different bug, or just sorted out by implementing the freq
that has already been submitted. Devon, which would you
prefer? Note: I checked 5.6.1 and ammo was stacking in 3.5
mode then also, so I have doubts that 3.5 mode ever stopped
the stacking.

James.

----------------------------------------------------------------------

Comment By: Devon Jones (soulcatcher)
Date: 2005-04-01 12:00

Message:
Logged In: YES 
user_id=107647

Eddy, this all used to work - ammo stacking in 3.0 mode, and
ammo not stacking in 3.5 mode.

I'm approving fixing the whole kit & kaboodle.

Devon

----------------------------------------------------------------------

Comment By: Eddy Anthony (eddyanthony)
Date: 2005-04-01 11:53

Message:
Logged In: YES 
user_id=886893

For reference. Feature Request for the 5.9 series:

[ 1174978 ] Enchanted ammo stacking with weapon bonus
<https://sourceforge.net/tracker/index.php?
func=detail&aid=1174978&group_id=25576&atid=384722>

----------------------------------------------------------------------

Comment By: Devon Jones (soulcatcher)
Date: 2005-04-01 11:50

Message:
Logged In: YES 
user_id=107647

approved

----------------------------------------------------------------------

Comment By: Eddy Anthony (eddyanthony)
Date: 2005-04-01 11:47

Message:
Logged In: YES 
user_id=886893

Assigning to Devon for priority review

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=384719&aid=1174968&group_id=25576